New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 773523 link

Starred by 1 user
Status: Verified
Owner:
hbos@chromium.org
Closed: Nov 2017
Cc:
█ deadbeef@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 760107



Sign in to add a comment

When a track is removed it should be removed from its streams and it should be muted

Project Member Reported by hbos@chromium.org, Oct 10 2017 
Currently when a track is removed its remote stream is removed from (not in spec) getRemoteStreams().

According to spec, when processing the removal of a remote track...
- the track should be removed from any stream it previously belonged to
- the track should be muted, firing a track.onmute event
https://rawgit.com/w3c/webrtc-pc/master/webrtc.html#process-remote-track-removal
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a0ef3f1c3ce29ce9d1ae2d755e3c04fff08ea1b

commit 5a0ef3f1c3ce29ce9d1ae2d755e3c04fff08ea1b
Author: Henrik Boström <hbos@chromium.org>
Date: Fri Nov 10 17:44:17 2017

When removing a remote track, mute it and fire onmute.

Spec: https://rawgit.com/w3c/webrtc-pc/master/webrtc.html#process-remote-track-removal
This fixes  https://crbug.com/773523 .
Updated the -expected.txt file of the test covering this.

Bug:  773523 , 777526
Change-Id: Icc6e6d45201bec8cfa91ad68f4114d7b3ca66028
Reviewed-on: https://chromium-review.googlesource.com/729523
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515589}
[modify] https://crrev.com/5a0ef3f1c3ce29ce9d1ae2d755e3c04fff08ea1b/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/a87fc3285677f9c3903542925e1fc7f2a1dbacaf/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-remove-tracks.https.html
[modify] https://crrev.com/5a0ef3f1c3ce29ce9d1ae2d755e3c04fff08ea1b/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https-expected.txt
[modify] https://crrev.com/5a0ef3f1c3ce29ce9d1ae2d755e3c04fff08ea1b/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html
[modify] https://crrev.com/5a0ef3f1c3ce29ce9d1ae2d755e3c04fff08ea1b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Comment 2 by hbos@chromium.org, Nov 13 2017

Status: Verified (was: Assigned)
►

Sign in to add a comment