New issue
Advanced search Search tips

Issue 773516 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 769910



Sign in to add a comment

V8 CQ is blocked because CQ doesn't recognize triggered (child) tryjobs due to extra "project": "" property

Project Member Reported by gsat...@chromium.org, Oct 10 2017

Issue description

What steps will reproduce the problem?
https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/707902/10 has been running for over 2 hrs 

What is the expected result?
CQ completes and merges patch

What happens instead?
CQ has been running for over 2 hrs

 
Labels: Infra-Troopers
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
Andrii, PTAL.

Looks like all trybots are green, but CQ is not submitting the CL.
Status: Started (was: Assigned)
let's see.
Ok, so V8 CQ stopped "seeing" this Gerrit CL after restart. I'm not yet sure why.
CQ logs say that CL is actually seen and worked on. However,

[pid:27568 tid:140646778332928 infra_internal.services.cq.buildbucket_util:562] Skipping bucket result 8966091546213331872 for  issue 707902  patchset 10: project is "" but not equal to patch_project "v8/v8". 

gsathya@chromium.org: if this is urgent for you to land, please do so manually (more -> submit).
Also, this message started before CQ restart I think. I think the problem is actually in recipes which do triggering parent -> child build.
Manual submit destroyed the V8 tree https://build.chromium.org/p/client.v8/console
OK, this actually started happening at 7:07 AM:

07:07:29.734
[pid:27754 tid:140080685508352 infra_internal.services.cq.buildbucket_util:562] Skipping bucket result 8966113940219022960 for  issue 708801  patchset 2: project is "" but not equal to patch_project "v8/v8". INFO:googleapiclient.discovery:URL being requested: GET https://cr-buildbucket.appspot.com/api/buildbucket/v1/search?max_builds=40&alt=json&tag=buildset%3Apatch%2Fgerrit%2Fchromium-review.googlesource.com%2F708801%2F1&start_cursor= DEBUG:root:fetched 34 builds for patch/gerrit/chromium-review.googlesource.com/709354/1 [prior Stats(fetched: 34, triggered: 23)]


This is exactly when https://chromium-review.googlesource.com/c/chromium/tools/build/+/707249 landed.
Cc: serg...@chromium.org machenb...@chromium.org
Components: -Infra>Client Infra>Client>V8
Labels: -Pri-3 Pri-1
Summary: V8 CQ is blocked because CQ doesn't recognize triggered (child) tryjobs due to extra "project": "" property (was: CQ unresponsive)
New CQ attempts which don't re-use prior tryjobs should be working fine.

However, for prior attempts - I've made a workaround in CQ https://chrome-internal-review.googlesource.com/c/infra/infra_internal/+/476112
I'll need ~30 minutes to deploy them.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e

commit 209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Oct 11 00:04:46 2017

Revert "Reland "Replace trigger module with buildbucket-put module""

This reverts commit 0a70f39f70c91a2d318dc72260d2b4cc15fcb8aa.

Reason for revert: sets incomplete properties on child builds.

Original change's description:
> Reland "Replace trigger module with buildbucket-put module"
> 
> Original change: https://crrev.com/c/677443
> Revert: https://crrev.com/c/686854
> Re-land: https://crrev.com/c/686756
> Revert: https://crrev.com/c/686855
> Re-land: https://crrev.com/c/687497
> Revent: https://crrev.com/c/687634
> Re-land: https://crrev.com/c/688276
> Revent: https://crrev.com/c/707254
> 
> R=​machenbach@chromium.org
> 
> Bug: 769910
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Change-Id: I6d07475efadc3d67470dd691db0e568a2efb158b
> Reviewed-on: https://chromium-review.googlesource.com/707249
> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>

TBR=machenbach@chromium.org,sergiyb@chromium.org

Change-Id: I5dcf7cc00562f66917d24ca07fb2896b9c494eca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 769910,  773516 
Reviewed-on: https://chromium-review.googlesource.com/710867
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_gyp_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_tsan_concurrent_marking_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_verify_csa_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipe_modules/v8/api.py
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipe_modules/v8/__init__.py
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_verify_csa_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_asan_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_ubsan_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng_test_filter_builder.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/README.recipes.md
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_nosnap_shared_rel_ng.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_gerrit.json
[modify] https://crrev.com/209ffd8f1bd1e1a034fadc31a063b4d19f7efe7e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_with_cache.json

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/ca5b545d6c69f8a800c483a3f739067836812503

commit ca5b545d6c69f8a800c483a3f739067836812503
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Oct 11 00:31:01 2017

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/386d3f1d80c5217d1af096f884f5aa311648e931

commit 386d3f1d80c5217d1af096f884f5aa311648e931
Author: Andrii Shyshkalov <tandrii@google.com>
Date: Wed Oct 11 01:04:14 2017

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/0bbfa0673278e6e8af12ec53937e0e53b76d1771

commit 0bbfa0673278e6e8af12ec53937e0e53b76d1771
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Oct 11 01:24:12 2017

Thanks Andrii for resolving this!

@Sergiy: So, IIUC buildbucket recipe module sets an extra "project" property? Or is it your CL that sets it?
Blocking: 769910
Status: Fixed (was: Started)
Thanks Andrii, indeed! I'll investigate, fix the root cause and test entire CQ run instead of just have it trigger trybots and then land with No-Try.

Marking this bug is fixed. I'll continue working on this in issue 769910.
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/58f56305c0c580b5308e97ef9843eb0fde4d7086

commit 58f56305c0c580b5308e97ef9843eb0fde4d7086
Author: Sergiy Byelozyorov <sergiyb@google.com>
Date: Wed Oct 11 13:57:40 2017

Sign in to add a comment