New issue
Advanced search Search tips

Issue 773503 link

Starred by 1 user
Status: Fixed
Owner:
yuweih@chromium.org
Closed: Dec 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] Use ScopedCFTypeRef to simplify memory management of CFObjects

Project Member Reported by yuweih@chromium.org, Oct 10 2017 
Currently CFObjects are manually freed by calling CFRelease. This is potentially error prone. We should use ScopedCFTypeRef instead to simplify memory management.

Especially for KeychainWrapper
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e349345e584764cf9c219c3a2ae4ca2f639e554d

commit e349345e584764cf9c219c3a2ae4ca2f639e554d
Author: Yuwei Huang <yuweih@chromium.org>
Date: Mon Nov 20 20:26:58 2017

[CRD iOS] Wrap raw CFTypeRefs with ScopedCFTypeRef

This simplifies some memory management works.

Bug:  773503 
Change-Id: I00ddaab4f2e6709115741cdf796acda1021fd24d
Reviewed-on: https://chromium-review.googlesource.com/777973
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517911}
[modify] https://crrev.com/e349345e584764cf9c219c3a2ae4ca2f639e554d/remoting/ios/app/remoting_view_controller.mm
[modify] https://crrev.com/e349345e584764cf9c219c3a2ae4ca2f639e554d/remoting/ios/keychain_wrapper.mm

Comment 2 by yuweih@chromium.org, Dec 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment