New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773497 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 789997



Sign in to add a comment

Show local files within search results

Project Member Reported by omrilio@chromium.org, Oct 10 2017

Issue description

Right now launcher shows Drive files, but it does not show local ones, this feels like a bug. 

Weifang, what do you think?
 

Comment 1 by fukino@chromium.org, Oct 11 2017

Cc: -fukino@chromium.org weifangsun@chromium.org yawano@chromium.org
Owner: fukino@chromium.org
Status: Assigned (was: Untriaged)
When we integrated Google Drive files to the launcher, we excluded local files to avoid privacy concerns.
https://bugs.chromium.org/p/chromium/issues/detail?id=474291

We should revisit it and go through the launch review by taking care of the privacy.

Comment 2 by fukino@chromium.org, Oct 11 2017

Components: Platform>Apps>FileManager
Blocking: 789997

Comment 4 by warx@chromium.org, Dec 5 2017

Cc: warx@chromium.org
Labels: M-65
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/571c8566c2eb0aa945c5b44bef061c26c953f7f6

commit 571c8566c2eb0aa945c5b44bef061c26c953f7f6
Author: Naoki Fukino <fukino@chromium.org>
Date: Tue Dec 26 10:14:58 2017

Show files/directories from Downloads volume in launcher search resutls.

This change adds local entries to the result of launcher search.
Finding local entries is done by recursive reads for the Downloads
volume in JS side. Now that both foreground and background do the
similar recursive reads, the common implementation is moved from
LocalSearchContentScanner to a common util function.
As a part of this change, I added a logic to prefer files which have
the search query as their prefixes in reply to omri's request.

Bug:  773497 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I22921e6c141aa9014198446ea8a562c6b5154fbf
Reviewed-on: https://chromium-review.googlesource.com/842365
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526189}
[modify] https://crrev.com/571c8566c2eb0aa945c5b44bef061c26c953f7f6/ui/file_manager/file_manager/background/js/launcher_search.js
[modify] https://crrev.com/571c8566c2eb0aa945c5b44bef061c26c953f7f6/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/571c8566c2eb0aa945c5b44bef061c26c953f7f6/ui/file_manager/file_manager/foreground/js/directory_contents.js

Comment 7 by fukino@chromium.org, Jan 10 2018

Status: Fixed (was: Assigned)

Comment 8 by fukino@chromium.org, Jan 22 2018

Issue 753970 has been merged into this issue.
Status: Verified (was: Fixed)
Verified on M65 dev build (10323.2.0, 65.0.3325.11) cave device.

Sign in to add a comment