New issue
Advanced search Search tips

Issue 773494 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 715364


Participants' hotlists:
franky-backlog


Sign in to add a comment

Franky: fix the recipe autoroller

Project Member Reported by sergeybe...@chromium.org, Oct 10 2017

Issue description

Currently, the franky repo doesn't automatically roll its recipes, resulting in breakages e.g. https://crrev.com/c/701926
and need for manual fixes like these: https://crrev.com/c/671637


 
Labels: -Restrict-View-Google
Blocking: 715364
In theory, the autoroller should work after https://crrev.com/c/495047 (landed back in May'17). But it doesn't... This may be worth a visit to the Foundations team.
Cc: linds...@chromium.org
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 12

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/a9ed864dbf1cc3c398983c0f521e630f80e998d6

commit a9ed864dbf1cc3c398983c0f521e630f80e998d6
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Dec 17 20:19:53 2018

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/292d2585a7d64bee8c552b639c89c13b14efd9a7

commit 292d2585a7d64bee8c552b639c89c13b14efd9a7
Author: Robert Iannucci <iannucci@google.com>
Date: Mon Dec 17 20:21:15 2018

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/tools/franky/+/6be4abc4b5f56797109164de175201b326a47150

commit 6be4abc4b5f56797109164de175201b326a47150
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Dec 17 23:10:55 2018

Manually roll recipes to close-to-latest

R=bjoyce@chromium.org, sergeyberezin@chromium.org, tandrii@chromium.org

Bug:  773494 
Change-Id: I8fa9373c339da9fc96b63347931942f36d416f2a
Reviewed-on: https://chromium-review.googlesource.com/c/1380818
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/6be4abc4b5f56797109164de175201b326a47150/recipes/recipes.py
[modify] https://crrev.com/6be4abc4b5f56797109164de175201b326a47150/recipes/recipes/presubmit.expected/presubmit_master.json
[modify] https://crrev.com/6be4abc4b5f56797109164de175201b326a47150/recipes/README.recipes.md
[modify] https://crrev.com/6be4abc4b5f56797109164de175201b326a47150/recipes/recipes/tests.expected/gerrit_patch.json
[modify] https://crrev.com/6be4abc4b5f56797109164de175201b326a47150/recipes/recipe_modules/franky/examples/full.expected/gerrit_patch.json
[modify] https://crrev.com/6be4abc4b5f56797109164de175201b326a47150/recipes/recipe_modules/franky/api.py
[modify] https://crrev.com/6be4abc4b5f56797109164de175201b326a47150/recipes/recipe_modules/franky/__init__.py
[modify] https://crrev.com/6be4abc4b5f56797109164de175201b326a47150/recipes/recipes/tests.expected/master_branch.json
[modify] https://crrev.com/6be4abc4b5f56797109164de175201b326a47150/recipes/recipes/presubmit.expected/gerrit_patch.json
[modify] https://crrev.com/6be4abc4b5f56797109164de175201b326a47150/infra/config/recipes.cfg
[modify] https://crrev.com/6be4abc4b5f56797109164de175201b326a47150/recipes/recipe_modules/franky/examples/full.expected/master_branch.json

Status: Fixed (was: Available)
Seems to be finally fixed!

Sign in to add a comment