New issue
Advanced search Search tips

Issue 773492 link

Starred by 1 user
Status: Fixed
Owner:
mdjones@chromium.org
Closed: Oct 2017
Cc:
twelling...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Chrome Home] Toolbar uses incorrect color after promo

Project Member Reported by mdjones@chromium.org, Oct 10 2017 
Repro steps:

- Chrome Home is enabled.
- Open promo from menu.
- Switch to non-Chrome Home.
- Toolbar is white instead of default color.

Comment 1 by k...@chromium.org, Oct 11 2017

Labels: Fine-Pri-2.5
Can't seem to repro but seems like a visual oddity if so.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64733ed0523678475f53d3b2307ff41a3d413649

commit 64733ed0523678475f53d3b2307ff41a3d413649
Author: Matthew Jones <mdjones@chromium.org>
Date: Thu Oct 12 23:29:17 2017

[Home] Hande theme color change during tab reparenting

Since tab state is not read during tab reparenting, there is no
opportunity to correct the otherwise invalid theme color that Chrome
Home uses. This change adds a check to attachAndFinishReparenting to
recompute the theme color if invalid.

BUG= 773492 

Change-Id: Icbca4380037abbc6c25a4bfba8b38917487f8faf
Reviewed-on: https://chromium-review.googlesource.com/710655
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508531}
[modify] https://crrev.com/64733ed0523678475f53d3b2307ff41a3d413649/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Comment 3 by mdjones@chromium.org, Oct 12 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment