New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773489 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Feature



Sign in to add a comment

Different Linux channels of Google Chrome should use different icons

Project Member Reported by thomasanderson@chromium.org, Oct 10 2017

Issue description

Currently, all channels use the same menu icon, and the only way to differentiate the channels is by looking at the menu name, which is of the form "Google Chrome (unstable)".  However, even this is insufficient on Gnome because all channels show up as "Google Chrome ...".

about:chrome has a different icon for each channel.  We should start using this icon at least for
* The desktop file, so we can differentiate the menu entries
* The X window hint, to differentiate between instances in the desktop environment
 

Comment 1 by bettes@chromium.org, Oct 27 2017

Sizes needed for Dev and Beta: 22, 24, 32, 48, 64, 128, 256

Isn't this a problem on Windows too now? It too has SxS installs for all channels now. Chrome on Android already has different icons, at least in the Play Store:

https://play.google.com/store/apps/details?id=com.chrome.beta
https://play.google.com/store/apps/details?id=com.chrome.dev

Not sure; I didn't install the different channels on Windows to test.  But I did see the windows resources for the dev and beta icons: https://cs.chromium.org/chromium/src/chrome/BUILD.gn?type=cs&q=win/tiles&sq=package:chromium&l=1516
22, 24, 32, 48, 64, 128, 256 assets for Dev, Beta, and Stable*
https://drive.google.com/open?id=1x80D8MsxFQZDl3IQi0oTt-AUTyDUc_HZ



* Slight modification to the Stable icon so please update as well. 
Screen Shot 2017-11-03 at 2.51.57 PM.png
65.3 KB View Download
Cc: ainslie@chromium.org
+ainslie@

We're about to land go/8l7nGtVmzFJ5SeVuhAfK56szOYOKLaB4 but before we do, could you give a quick verification that this lg in terms of UI/UX?
Cc: -ainslie@chromium.org hannahs@chromium.org bettes@chromium.org
+bettes@ and +hannahs@ are the right folks to confirm with
pinging hannahs@/bettes@.  Not sure if UX has to sign off on this feature or not
Hey! The drive folder Alan links should be good to use! For posterity (and because I don't have a linux to test this on in the SF office) would you be able to get a quick screenshot of the before and after? Thanks!
Here's a before/after on GNOME and cinnamon.  I think it's a bit hard to read the "dev" and "beta" text with the small icons.
cinnamon_after.png
119 KB View Download
cinnamon_before.png
63.0 KB View Download
gnome_after.png
397 KB View Download
gnome_before.png
396 KB View Download
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/theme/google_chrome/+/630305b542c9ee65514ace89c02ef851543fb518

commit 630305b542c9ee65514ace89c02ef851543fb518
Author: Tom Anderson <thomasanderson@google.com>
Date: Tue Nov 07 21:21:16 2017

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 17 2017

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/d79c2901f5f810e9763cd7a816c3b87482877550

commit d79c2901f5f810e9763cd7a816c3b87482877550
Author: Tom Anderson <thomasanderson@google.com>
Date: Fri Nov 17 19:01:32 2017

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bc834067fd97f425baf62dbde98647c1acc51e1

commit 4bc834067fd97f425baf62dbde98647c1acc51e1
Author: src-internal-roller@chromium.org <src-internal-roller@chromium.org>
Date: Fri Nov 17 20:29:26 2017

Roll src-internal/ 03c0eed54..d79c2901f (1 commit)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03c0eed54814..d79c2901f5f8

$ git log 03c0eed54..d79c2901f --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal
BUG= 773489 


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: I573802b204c6ea717fe5d8ba21ea91d2e7b2616c
Reviewed-on: https://chromium-review.googlesource.com/777387
Reviewed-by: src-internal-roller . <src-internal-roller@chromium.org>
Commit-Queue: src-internal-roller . <src-internal-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517538}
[modify] https://crrev.com/4bc834067fd97f425baf62dbde98647c1acc51e1/DEPS

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3d0956d3c6d189b90ec8e90e72ac088d9fddb1c

commit e3d0956d3c6d189b90ec8e90e72ac088d9fddb1c
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Nov 22 23:06:39 2017

Distinguish Chrome window icons for different channels on Linux

Also, use 128x128 icons to fix  bug 625711 .

BUG= 625711 , 773489 
R=thestig@chromium.org

Change-Id: Ifbe99e82bf29a0838b9322db3c6a3d27bc2b5ed9
Reviewed-on: https://chromium-review.googlesource.com/786531
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518786}
[modify] https://crrev.com/e3d0956d3c6d189b90ec8e90e72ac088d9fddb1c/chrome/app/theme/chrome_unscaled_resources.grd
[modify] https://crrev.com/e3d0956d3c6d189b90ec8e90e72ac088d9fddb1c/chrome/browser/ui/views/chrome_views_delegate_linux.cc

Status: Fixed (was: Assigned)

Sign in to add a comment