New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 773482 link

Starred by 1 user
Status: Fixed
Owner:
█ holte@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Improve thread safety of UkmRecorder APIs

Project Member Reported by holte@chromium.org, Oct 10 2017 
UkmRecorderImpl currently DCHECKs that it is called from a single thread, but we should allow data to be recorded from any thread.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e73c0016909d3bedb5d0778f2b9fa1920297f760

commit e73c0016909d3bedb5d0778f2b9fa1920297f760
Author: Steven Holte <holte@google.com>
Date: Fri Oct 20 19:46:19 2017

Make UkmRecorder::Get's implementation thread-safe.

TBR=petewil,vasilii,mathp,groby

Bug:  773482 
Change-Id: I2b60c23de7dcc4c945878f38b5c76524d3cdb2fb
Reviewed-on: https://chromium-review.googlesource.com/710528
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510526}
[modify] https://crrev.com/e73c0016909d3bedb5d0778f2b9fa1920297f760/chrome/browser/metrics/process_memory_metrics_emitter_unittest.cc
[modify] https://crrev.com/e73c0016909d3bedb5d0778f2b9fa1920297f760/components/offline_pages/core/offline_pages_ukm_reporter_unittest.cc
[modify] https://crrev.com/e73c0016909d3bedb5d0778f2b9fa1920297f760/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc
[modify] https://crrev.com/e73c0016909d3bedb5d0778f2b9fa1920297f760/components/password_manager/core/browser/password_manager_metrics_recorder_unittest.cc
[modify] https://crrev.com/e73c0016909d3bedb5d0778f2b9fa1920297f760/components/payments/core/journey_logger_unittest.cc
[modify] https://crrev.com/e73c0016909d3bedb5d0778f2b9fa1920297f760/components/translate/core/browser/translate_ranker_impl_unittest.cc
[modify] https://crrev.com/e73c0016909d3bedb5d0778f2b9fa1920297f760/components/ukm/test_ukm_recorder.cc
[modify] https://crrev.com/e73c0016909d3bedb5d0778f2b9fa1920297f760/components/ukm/test_ukm_recorder.h
[modify] https://crrev.com/e73c0016909d3bedb5d0778f2b9fa1920297f760/components/ukm/ukm_service.cc
[modify] https://crrev.com/e73c0016909d3bedb5d0778f2b9fa1920297f760/services/metrics/public/cpp/delegating_ukm_recorder.cc
[modify] https://crrev.com/e73c0016909d3bedb5d0778f2b9fa1920297f760/services/metrics/public/cpp/delegating_ukm_recorder.h

Comment 2 by holte@chromium.org, Dec 6 2017

Status: Fixed (was: Started)
►

Sign in to add a comment