New issue
Advanced search Search tips

Issue 773475 link

Starred by 3 users
Status: Fixed
Owner:
beccahughes@chromium.org
Closed: Oct 2017
Cc:
liber...@chromium.org
dalecur...@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

mouse click need be super accurate in seeking video

Project Member Reported by yini...@chromium.org, Oct 10 2017 
Chrome Version: 63.0.3230.0
OS: all

This is a regression from prior build. It not repro on beta build 62.0.3202.45

What steps will reproduce the problem?
(1) navigate to https://ats.sandbox.google.com/static/chrome_test_app/index.html
(2) load any video and play
e.g L3_audio_L3_video.mp4.mpd
(3) seek to anywhere

What is the expected result?
is able to see

What happens instead?
mouse tip click must be exactly on the progress line, otherwise mouse click is not recognized.

Comment 1 by liber...@chromium.org, Oct 10 2017

Cc: liber...@chromium.org
Owner: mlamouri@chromium.org
over to mlamouri.

Comment 2 by mlamouri@chromium.org, Oct 12 2017

Cc: mlamouri@chromium.org
Owner: beccahughes@chromium.org
Becca, could that be a side effects from your recent changes?

Comment 3 by beccahughes@chromium.org, Oct 12 2017 

Yes I think so

Comment 4 by dalecur...@chromium.org, Oct 13 2017

Labels: -Pri-2 ReleaseBlock-Stable M-63 Pri-1
This is a pretty serious regression, the default controls are unusable in their current state. Marking as P1-RBS to reflect this - though I could be convinced this is RBB/RBD.
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 16 2017

Cc: dalecur...@chromium.org
This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label.

All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by dalecur...@chromium.org, Oct 16 2017

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 7 by beccahughes@chromium.org, Oct 17 2017

Status: Started (was: Assigned)
Pending CL to fix: https://chromium-review.googlesource.com/c/chromium/src/+/721319
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c57517d100b88e21f79210fe23746ff11ad16b9

commit 6c57517d100b88e21f79210fe23746ff11ad16b9
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Oct 17 10:38:23 2017

Media Controls: Fix slider touch issue

This fixes a regression where touch/click events are not correctly
being picked up by the slider. This adds padding around the timeline
and volume slider which will pick up gestures in these areas. There
is no visual effect of this change.

BUG= 773475 

Change-Id: Idff48c259438bb776f6794d921625f5340744d1b
Reviewed-on: https://chromium-review.googlesource.com/721319
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509350}
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-in-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-out-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-in-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-out-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/6c57517d100b88e21f79210fe23746ff11ad16b9/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControls.css

Comment 9 by beccahughes@chromium.org, Oct 17 2017

Labels: Merge-Request-63
Project Member

Comment 10 by sheriffbot@chromium.org, Oct 18 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 18 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60

commit 94d371c40c24b6297b4bf0e98a7b5362f9fd8e60
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Oct 18 10:49:24 2017

Media Controls: Fix slider touch issue

This fixes a regression where touch/click events are not correctly
being picked up by the slider. This adds padding around the timeline
and volume slider which will pick up gestures in these areas. There
is no visual effect of this change.

BUG= 773475 

Change-Id: Idff48c259438bb776f6794d921625f5340744d1b
Reviewed-on: https://chromium-review.googlesource.com/721319
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509350}(cherry picked from commit 6c57517d100b88e21f79210fe23746ff11ad16b9)
Reviewed-on: https://chromium-review.googlesource.com/725290
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#50}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/linux/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/linux/media/media-document-audio-repaint-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/linux/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-in-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/media/controls/controls-page-zoom-out-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/media/media-document-audio-repaint-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/mac/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-in-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/media/controls/controls-page-zoom-out-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/http/tests/media/video-buffered-range-contains-currentTime-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-in-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/controls-page-zoom-out-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/lazy-loaded-style-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-custom-bg-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/paint-controls-webkit-appearance-none-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/LayoutTests/platform/win/virtual/new-remote-playback-pipeline/media/controls/video-controls-with-cast-rendering-expected.txt
[modify] https://crrev.com/94d371c40c24b6297b4bf0e98a7b5362f9fd8e60/third_party/WebKit/Source/modules/media_controls/resources/legacyMediaControls.css

Comment 12 by beccahughes@chromium.org, Oct 18 2017

Status: Fixed (was: Started)

Comment 13 by avkodipelli@chromium.org, Oct 24 2017

Labels: -OS-Chrome
Verified on 10032.14.0, 63.0.3239.17 on ChromeOS. Removing chrome label and leaving status to fixed to test on other OS.
►

Sign in to add a comment