New issue
Advanced search Search tips

Issue 773471 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add imageloader method to get metadata for component

Project Member Reported by ejcaruso@chromium.org, Oct 10 2017

Issue description

Some components are somewhat big and we might not need to load them. We should have a way to inspect component metadata that can be read from the signed imageloader manifest after the component is registered but before it is loaded. This would allow us to package metadata that could help us make the decision about whether or not we need to load the component in the imageloader manifest instead of always loading the component.

The metadata could just be an entry in the imageloader manifest and upon request imageloader can give us the JSON blob, if it exists.
 
Cc: xiaochu@chromium.org
xiaochu@ will probably be interested in this as well.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/imageloader/+/afa8fb0b89b6ab94fa94e951021ccaa952d44377

commit afa8fb0b89b6ab94fa94e951021ccaa952d44377
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Tue Oct 31 06:21:29 2017

imageloader: add GetComponentMetadata D-Bus method

This allows us to pack some information into the imageloader
manifest that will be signed but which we can access before we
actually load components. This information might be used to make
decisions about whether or not we actually do need to load the
component.

BUG=chromium:773471
TEST=deploy on device and test, new unit tests

Change-Id: Ia5e9f963e12dcd443851773f428d0d9f6c2104d8
Reviewed-on: https://chromium-review.googlesource.com/737428
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-metadata/image.squash
[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-non-dict-metadata/imageloader.json
[modify] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/imageloader_impl.h
[modify] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/test_utilities.cc
[modify] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/imageloader.h
[modify] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/imageloader_impl.cc
[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-metadata/imageloader.json
[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-non-dict-metadata/manifest.json
[modify] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/component.cc
[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-bad-metadata/table
[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-metadata/manifest.json
[modify] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/imageloader_unittest.cc
[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-metadata/imageloader.sig.2
[modify] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/component.h
[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-non-dict-metadata/image.squash
[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-bad-metadata/imageloader.sig.2
[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-bad-metadata/manifest.json
[modify] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/test_utilities.h
[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-bad-metadata/imageloader.json
[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-bad-metadata/image.squash
[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-metadata/table
[modify] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/imageloader.cc
[modify] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/dbus_adaptors/org.chromium.ImageLoaderInterface.xml
[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-non-dict-metadata/imageloader.sig.2
[add] https://crrev.com/afa8fb0b89b6ab94fa94e951021ccaa952d44377/testdata/adb-with-non-dict-metadata/table

Project Member

Comment 3 by sheriffbot@chromium.org, Oct 31

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment