New issue
Advanced search Search tips

Issue 773470 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 761120



Sign in to add a comment

Move stylus related prefs to ash

Project Member Reported by kaznacheev@chromium.org, Oct 10 2017

Issue description

This will make it possible to remove a few pref-related methods from PaletteDelegate.
 
Blocking: 761120
Status: Started (was: Assigned)

Comment 3 by osh...@chromium.org, Oct 13 2017

Components: Internals>Preferences
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fefa6bd4898886a17b7ad0e2b289456228862d75

commit fefa6bd4898886a17b7ad0e2b289456228862d75
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Sat Oct 14 00:25:24 2017

Move stylus related prefs to ash

Bug:  773470 
Test: ash_unittest --gtest_filter=Palette*
Change-Id: Ia8246a0c1860a664995648ec3b5e6161749754a7
Reviewed-on: https://chromium-review.googlesource.com/710505
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508889}
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/ash/palette_delegate.h
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/ash/public/cpp/ash_pref_names.h
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/ash/shell.cc
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/ash/system/palette/palette_tray.h
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/ash/system/palette/palette_tray_unittest.cc
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/ash/system/palette/palette_utils.cc
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/ash/system/palette/palette_utils.h
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/ash/system/palette/test_palette_delegate.cc
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/ash/system/palette/test_palette_delegate.h
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/chrome/browser/ui/ash/palette_delegate_chromeos.cc
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/chrome/browser/ui/ash/palette_delegate_chromeos.h
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/chrome/common/pref_names.cc
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/chrome/common/pref_names.h
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/testing/buildbot/filters/ash_unittests_mash.filter
[modify] https://crrev.com/fefa6bd4898886a17b7ad0e2b289456228862d75/testing/buildbot/filters/ash_unittests_mus.filter

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment