New issue
Advanced search Search tips

Issue 773451 link

Starred by 1 user
Status: Fixed
Owner:
shaktisahu@chromium.org
Closed: Jan 2018
Cc:
fgor...@chromium.org
dtrainor@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Offline content provider : Make the API async for Get() calls

Project Member Reported by shaktisahu@chromium.org, Oct 10 2017 
The OfflineContentProvider::GetAllItems and OfflineContentProvider::GetItemById calls can be async and take a callback as param. That would help us not to maintain a cache of items throughout the lifetime of chrome.

Comment 1 by shaktisahu@chromium.org, Oct 10 2017

Cc: dtrainor@chromium.org fgor...@chromium.org
Owner: shaktisahu@chromium.org
Summary: Offline content provider : Make the API async for Get() calls (was: Offline content provider : Make the API async for Get calls)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf

commit 369fae2d336df5c39ecf26e9f896e54ab1e2bdbf
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Wed Dec 20 20:39:27 2017

OfflineContentProvider : Changing the Get calls to Async

To avoid the need for providers to cache their offline items, this CL
changes the GetAllItems() and GetItemById() methods to take a callback.
The aggregator will wait for all the providers to return and send the
aggregated result.
The removal of cache from DownloadUIAdapter is not included in this CL.

Bug:  773451 
Change-Id: Ia8b24ed2483a2ab8696f9fcb913d9154fc7cf370
Reviewed-on: https://chromium-review.googlesource.com/724273
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525439}
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/chrome/browser/background_fetch/background_fetch_delegate_impl.cc
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/chrome/browser/background_fetch/background_fetch_delegate_impl.h
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineContentAggregatorBridge.java
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineContentProvider.java
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/android/offline_content_aggregator_bridge.cc
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/android/offline_content_aggregator_bridge.h
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/android/offline_item_bridge.cc
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/android/offline_item_bridge.h
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/offline_content_aggregator.cc
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/offline_content_aggregator.h
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/offline_content_aggregator_unittest.cc
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/offline_content_provider.h
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/test_support/mock_offline_content_provider.cc
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/test_support/mock_offline_content_provider.h
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/throttled_offline_content_provider.cc
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/throttled_offline_content_provider.h
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_items_collection/core/throttled_offline_content_provider_unittest.cc
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_pages/core/downloads/download_ui_adapter.cc
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_pages/core/downloads/download_ui_adapter.h
[modify] https://crrev.com/369fae2d336df5c39ecf26e9f896e54ab1e2bdbf/components/offline_pages/core/downloads/download_ui_adapter_unittest.cc

Comment 3 by shaktisahu@chromium.org, Jan 4 2018

Status: Fixed (was: Available)
►

Sign in to add a comment