Updating the test expectations and assigning to qyearsley@ for eventual fix Builds failed: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/11486 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/11487 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/11488
This test was last changed 10 years ago -- not entirely sure who the best owner for this would be. This test appears to be flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=fast/text/monospace-width-cache.html Sometimes on some machines the line is one pixel longer.
Asking Blink>Fonts to help triage.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60a788489006965ec24530637cd6b14048aac7a7 commit 60a788489006965ec24530637cd6b14048aac7a7 Author: sebsg <sebsg@chromium.org> Date: Tue Oct 10 21:41:56 2017 fast/text/monospace-width-cache.html is failing on Win7 Tbr: qyearsley@chromium.org Bug: 773434 Change-Id: I7a5935512950acfe504692dbe14f97756ce252aa Reviewed-on: https://chromium-review.googlesource.com/710318 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#507781} [modify] https://crrev.com/60a788489006965ec24530637cd6b14048aac7a7/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bf2be9544cb94254a705e8c3d3c4a777eabb587 commit 6bf2be9544cb94254a705e8c3d3c4a777eabb587 Author: Emil A Eklund <eae@chromium.org> Date: Thu Oct 12 01:19:38 2017 Remove fast/text/monospace-width-cache.html Remove out of date test fast/text/monospace-width-cache.html that is no longer valid or relevant given that the cache it tests has been removed and that we now use subpixel precision for textrun placement. Bug: 773434 Change-Id: Ic6dcb519b9063e3387df66be68e853d54f8c2fe3 Tbr: sebsg@chromium.org Reviewed-on: https://chromium-review.googlesource.com/714021 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#508202} [modify] https://crrev.com/6bf2be9544cb94254a705e8c3d3c4a777eabb587/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/5cb59dfc1385ca28a051fc888b3391224ade7c18/third_party/WebKit/LayoutTests/fast/text/monospace-width-cache.html [delete] https://crrev.com/5cb59dfc1385ca28a051fc888b3391224ade7c18/third_party/WebKit/LayoutTests/platform/linux/fast/text/monospace-width-cache-expected.png [delete] https://crrev.com/5cb59dfc1385ca28a051fc888b3391224ade7c18/third_party/WebKit/LayoutTests/platform/linux/fast/text/monospace-width-cache-expected.txt [delete] https://crrev.com/5cb59dfc1385ca28a051fc888b3391224ade7c18/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/monospace-width-cache-expected.png [delete] https://crrev.com/5cb59dfc1385ca28a051fc888b3391224ade7c18/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/monospace-width-cache-expected.png [delete] https://crrev.com/5cb59dfc1385ca28a051fc888b3391224ade7c18/third_party/WebKit/LayoutTests/platform/mac/fast/text/monospace-width-cache-expected.png [delete] https://crrev.com/5cb59dfc1385ca28a051fc888b3391224ade7c18/third_party/WebKit/LayoutTests/platform/mac/fast/text/monospace-width-cache-expected.txt [delete] https://crrev.com/5cb59dfc1385ca28a051fc888b3391224ade7c18/third_party/WebKit/LayoutTests/platform/win/fast/text/monospace-width-cache-expected.png [delete] https://crrev.com/5cb59dfc1385ca28a051fc888b3391224ade7c18/third_party/WebKit/LayoutTests/platform/win/fast/text/monospace-width-cache-expected.txt [delete] https://crrev.com/5cb59dfc1385ca28a051fc888b3391224ade7c18/third_party/WebKit/LayoutTests/platform/win7/fast/text/monospace-width-cache-expected.png
Comment 1 by qyears...@chromium.org
, Oct 10 2017