Issue metadata
Sign in to add a comment
|
20.1% regression in blink_perf.bindings at 506287:506371 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 10 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8966091979189423024
,
Oct 11 2017
=== Auto-CCing suspected CL author maxmorin@chromium.org === Hi maxmorin@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Max Morin Commit : fb8b0897f5c75f5487f441df8f0c8a6823ac951e Date : Wed Oct 04 07:33:46 2017 Subject: Remove unused member from MojoAudioOutputStreamProvider. Bisect Details Configuration: android_nexus5X_perf_bisect Benchmark : blink_perf.bindings Metric : get-elements-by-tag-name/get-elements-by-tag-name Change : 15.26% | 120.965592581 -> 102.501598564 Revision Result N chromium@506286 120.966 +- 1.26894 6 good chromium@506308 117.825 +- 4.02121 6 good chromium@506319 118.802 +- 1.35994 6 good chromium@506324 117.5 +- 4.29417 9 good chromium@506327 117.194 +- 8.82012 9 good chromium@506328 110.618 +- 7.55878 9 bad <-- chromium@506329 111.223 +- 5.19588 9 bad chromium@506371 102.502 +- 26.2179 6 bad Please refer to the following doc on diagnosing blink_perf regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8966091979189423024 For feedback, file a bug with component Speed>Bisection
,
Oct 11 2017
My CL just removes some member variables. Furthermore, that code isn't launched yet, and isn't in blink. Thus, unassigning myself.
,
Oct 11 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8966048753863486528
,
Oct 11 2017
=== Auto-CCing suspected CL author bmeurer@chromium.org === Hi bmeurer@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Benedikt Meurer Commit : d4da17c6e386819426d7929fa0b6287a4f62f002 Date : Wed Oct 04 06:58:36 2017 Subject: [es2015] Optimize Object.is baseline and interesting cases. Bisect Details Configuration: android_nexus5X_perf_bisect Benchmark : blink_perf.bindings Metric : get-element-by-id/get-element-by-id Change : 24.00% | 86.0875588207 -> 65.4268492801 Revision Result N chromium@506286 86.0876 +- 1.87491 6 good chromium@506329 84.6147 +- 1.07926 6 good chromium@506350 77.1385 +- 2.09901 6 good chromium@506362 78.2269 +- 1.12809 6 good chromium@506367 82.4602 +- 3.06922 9 good chromium@506367,v8@bfb43f8c12 81.2709 +- 4.72021 9 good chromium@506367,v8@d4da17c6e3 72.6481 +- 6.74102 6 bad <-- chromium@506367,v8@fa3b73fffe 73.6825 +- 5.41891 6 bad chromium@506368 70.8914 +- 13.5908 9 bad chromium@506369 70.407 +- 14.6316 9 bad chromium@506371 65.4268 +- 20.1976 6 bad Please refer to the following doc on diagnosing blink_perf regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8966048753863486528 For feedback, file a bug with component Speed>Bisection
,
Oct 12 2017
blink_perf.bindings doesn't even use Object.is, so this is definitely not the cause. Seems like the graph also recovered, so probably some device issue. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 10 2017