Issue metadata
Sign in to add a comment
|
Status bar color changed to white while in incognito on iPhoneX |
||||||||||||||||||||||||
Issue descriptionApp Version: 63.0.3237.0 canary iOS Version: 11.0 Device: iPhoneX Simulator URL: na Steps to reproduce: 1. Launch Google Chrome Landscape mode 2. Open a new incognito tab 3. Navigate to any webpage 4. Scroll down to enter fullscreen mode 5. Tap on the status bar area to display the toolbar again 6. Rotate the device Observed results: Observe that white status bar is displayed Expected results: Status bar should continue to display in grey Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): Not tested Bug reproducible on the current beta channel build (App Version, iOS Version): Not tested Link to video/image: https://drive.google.com/file/d/0B-xmXLQhjeKuRnk2X1lhdlRoQnc/view
,
Oct 12 2017
,
Oct 19 2017
Hey jif@ are you making some progress on this iPhoneX issue?
,
Oct 20 2017
,
Nov 7 2017
Duped bug 773640 is verified, but this issue is still reproduced on M64.0.3261.0 canary and M63.0.3239.39 beta on iPhoneX device. Please take a look.
,
Nov 7 2017
Assigning to Justin.
,
Nov 7 2017
,
Nov 8 2017
You can also trigger this by initiating a side swipe then rotating.
,
Nov 8 2017
Ah, side swipe (to change tabs, not navigate) in landscape triggers it. Thanks!
,
Nov 9 2017
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16ad60e7f5c7db6055c73fbe5abd42fc78e13310 commit 16ad60e7f5c7db6055c73fbe5abd42fc78e13310 Author: Justin Cohen <justincohen@google.com> Date: Fri Nov 10 14:56:26 2017 Don't stomp on fake status bar when ending side swipe. M62's change to -setUpViewLayout changed how some of the view layout code works. Those changes were correct, but they revealed an ancient bug in how side swipe re-inserts _contentArea. The fix is to make sure _contentArea is put back where it belongs. Bug: 773394 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icf1c2f9b31f04504595e0ffe24687372476d5098 Reviewed-on: https://chromium-review.googlesource.com/761479 Reviewed-by: Elodie Banel <lod@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#515552} [modify] https://crrev.com/16ad60e7f5c7db6055c73fbe5abd42fc78e13310/ios/chrome/browser/ui/browser_view_controller.mm
,
Nov 10 2017
,
Nov 10 2017
This bug requires manual review: Less than 21 days to go before AppStore submit on M63 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 10 2017
please verify the fix in the latest canary
,
Nov 13 2017
Verified in M64.0.3267.0 canary iPhoneX iOS11.2 Toolbar looks good.
,
Nov 13 2017
Approved! Branch is 3239
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbe763a32aac4dfe86486d8285db7d46b25af643 commit cbe763a32aac4dfe86486d8285db7d46b25af643 Author: Justin Cohen <justincohen@google.com> Date: Mon Nov 13 19:58:05 2017 Don't stomp on fake status bar when ending side swipe. M62's change to -setUpViewLayout changed how some of the view layout code works. Those changes were correct, but they revealed an ancient bug in how side swipe re-inserts _contentArea. The fix is to make sure _contentArea is put back where it belongs. TBR=justincohen@google.com (cherry picked from commit 16ad60e7f5c7db6055c73fbe5abd42fc78e13310) Bug: 773394 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icf1c2f9b31f04504595e0ffe24687372476d5098 Reviewed-on: https://chromium-review.googlesource.com/761479 Reviewed-by: Elodie Banel <lod@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#515552} Reviewed-on: https://chromium-review.googlesource.com/766517 Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#465} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/cbe763a32aac4dfe86486d8285db7d46b25af643/ios/chrome/browser/ui/browser_view_controller.mm
,
Nov 15 2017
Verified on 63.0.3239.53 Beta on iPhoneX simulator Toolbar looks good. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sczs@chromium.org
, Oct 11 2017Owner: jif@chromium.org
Status: Assigned (was: Untriaged)