New issue
Advanced search Search tips

Issue 773383 link

Starred by 1 user
Status: Fixed
Owner:
sebmarchand@chromium.org
Closed: Sep 14
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocking:
issue 727353



Sign in to add a comment

TMT needs a global database of heuristic features

Project Member Reported by chrisha@chromium.org, Oct 10 2017 
Feature description:
TMT needs a global database of crowd-sourced feature data in order to determine which origins are safe to discard/suspend/throttle.

Eng owner: chrisha@
Product owner: TBD

Design doc:

(Google only, makes references to internal services, etc)
https://docs.google.com/document/d/1xJRWDeNcKhOqip33auMwFhXCCFfD9jc4Hh9osFwJmgc/edit

Are you planning on experimenting before launch? yes
Any new strings? no
Any implications for Google webservices (i.e. sync, translate)? no
Binary size? no
Do the existing perf tests exercise all aspects of your new feature(s)? mostly
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c62bb5dfc7aafd712522cc84431b3e27174828d

commit 2c62bb5dfc7aafd712522cc84431b3e27174828d
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Thu Jun 14 03:24:27 2018

RC: Add the Intervention Policy Database proto.

Bug:  773383 
Change-Id: Ibf4bb5fe5881248489d01bf52fc6100f31c9266c
Reviewed-on: https://chromium-review.googlesource.com/1099681
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567114}
[modify] https://crrev.com/2c62bb5dfc7aafd712522cc84431b3e27174828d/chrome/browser/resource_coordinator/BUILD.gn
[add] https://crrev.com/2c62bb5dfc7aafd712522cc84431b3e27174828d/chrome/browser/resource_coordinator/intervention_policy_database.proto
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af2bd3c73515725055ec4b97ebcf6e3ef546e647

commit af2bd3c73515725055ec4b97ebcf6e3ef546e647
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Mon Jun 18 16:31:34 2018

Add the base for the intervention policy database component installer.

This doesn't do anything yet (this component isn't yet published by
Omaha anyway), it's just all the boilerplate required to setup the
component installer, this will then be connected to c/b/rc and the
server side work will be done later (once the Chrome part is done).

Bug:  773383 
Change-Id: I19802d63934b72ce812abe9d89d30d6f80a52258
Reviewed-on: https://chromium-review.googlesource.com/1100342
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568030}
[modify] https://crrev.com/af2bd3c73515725055ec4b97ebcf6e3ef546e647/chrome/browser/BUILD.gn
[add] https://crrev.com/af2bd3c73515725055ec4b97ebcf6e3ef546e647/chrome/browser/component_updater/intervention_policy_database_component_installer.cc
[add] https://crrev.com/af2bd3c73515725055ec4b97ebcf6e3ef546e647/chrome/browser/component_updater/intervention_policy_database_component_installer.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b366580b4e144f7c2e617b3b529b531258c35ce7

commit b366580b4e144f7c2e617b3b529b531258c35ce7
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Jun 22 20:47:02 2018

Add the base for the Intervention Policy DB.

Bug:  773383 
Change-Id: Ib67d9922a1fa05074c4036e92c3feddbb00849ce
Reviewed-on: https://chromium-review.googlesource.com/1103791
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569758}
[modify] https://crrev.com/b366580b4e144f7c2e617b3b529b531258c35ce7/chrome/browser/BUILD.gn
[add] https://crrev.com/b366580b4e144f7c2e617b3b529b531258c35ce7/chrome/browser/resource_coordinator/intervention_policy_database.cc
[add] https://crrev.com/b366580b4e144f7c2e617b3b529b531258c35ce7/chrome/browser/resource_coordinator/intervention_policy_database.h
[add] https://crrev.com/b366580b4e144f7c2e617b3b529b531258c35ce7/chrome/browser/resource_coordinator/intervention_policy_database_unittest.cc
[modify] https://crrev.com/b366580b4e144f7c2e617b3b529b531258c35ce7/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.cc
[add] https://crrev.com/b366580b4e144f7c2e617b3b529b531258c35ce7/chrome/browser/resource_coordinator/utils.cc
[add] https://crrev.com/b366580b4e144f7c2e617b3b529b531258c35ce7/chrome/browser/resource_coordinator/utils.h
[modify] https://crrev.com/b366580b4e144f7c2e617b3b529b531258c35ce7/chrome/test/BUILD.gn

Comment 4 by sebmarchand@chromium.org, Jul 4

Owner: sebmarchand@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a8c8e6d6b5f6a79f56b6eba982ff28412d09876

commit 8a8c8e6d6b5f6a79f56b6eba982ff28412d09876
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Mon Jul 09 17:02:58 2018

Enable the Intervention Policy Database component.

Also cleanup some includes to make sure that we don't include
tab_manager.h on Android.

Bug:  773383 
Change-Id: I3f7c5492e3815f5f9033163c8ef422b278de369a
Reviewed-on: https://chromium-review.googlesource.com/1126484
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573337}
[modify] https://crrev.com/8a8c8e6d6b5f6a79f56b6eba982ff28412d09876/chrome/browser/BUILD.gn
[modify] https://crrev.com/8a8c8e6d6b5f6a79f56b6eba982ff28412d09876/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/8a8c8e6d6b5f6a79f56b6eba982ff28412d09876/chrome/browser/component_updater/intervention_policy_database_component_installer.cc
[modify] https://crrev.com/8a8c8e6d6b5f6a79f56b6eba982ff28412d09876/chrome/browser/component_updater/intervention_policy_database_component_installer.h
[modify] https://crrev.com/8a8c8e6d6b5f6a79f56b6eba982ff28412d09876/chrome/browser/memory/chrome_memory_coordinator_delegate.cc
[modify] https://crrev.com/8a8c8e6d6b5f6a79f56b6eba982ff28412d09876/chrome/browser/resource_coordinator/intervention_policy_database.cc
[modify] https://crrev.com/8a8c8e6d6b5f6a79f56b6eba982ff28412d09876/chrome/browser/resource_coordinator/intervention_policy_database.h
[modify] https://crrev.com/8a8c8e6d6b5f6a79f56b6eba982ff28412d09876/chrome/browser/resource_coordinator/intervention_policy_database_unittest.cc
[modify] https://crrev.com/8a8c8e6d6b5f6a79f56b6eba982ff28412d09876/chrome/browser/resource_coordinator/tab_helper.cc
[modify] https://crrev.com/8a8c8e6d6b5f6a79f56b6eba982ff28412d09876/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/8a8c8e6d6b5f6a79f56b6eba982ff28412d09876/chrome/browser/resource_coordinator/tab_manager.h
[modify] https://crrev.com/8a8c8e6d6b5f6a79f56b6eba982ff28412d09876/chrome/test/base/testing_browser_process.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d26e79ae48f4aabcc86ebba3df8ea85776f7754

commit 0d26e79ae48f4aabcc86ebba3df8ea85776f7754
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Wed Jul 11 20:38:08 2018

Use the Intervention Policy DB to assist discarding/freezing decisions

Other bug fix in this CL: Don't use the Local DB heuristics when an
extension try to discard a tab.

Bug:  773383 
Change-Id: I1dd378a097d462793f25c382c9f96aa9381775d7
Reviewed-on: https://chromium-review.googlesource.com/1129620
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574312}
[modify] https://crrev.com/0d26e79ae48f4aabcc86ebba3df8ea85776f7754/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/0d26e79ae48f4aabcc86ebba3df8ea85776f7754/chrome/browser/resource_coordinator/intervention_policy_database.cc
[modify] https://crrev.com/0d26e79ae48f4aabcc86ebba3df8ea85776f7754/chrome/browser/resource_coordinator/intervention_policy_database.h
[modify] https://crrev.com/0d26e79ae48f4aabcc86ebba3df8ea85776f7754/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/0d26e79ae48f4aabcc86ebba3df8ea85776f7754/chrome/browser/resource_coordinator/tab_lifecycle_unit.h
[modify] https://crrev.com/0d26e79ae48f4aabcc86ebba3df8ea85776f7754/chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
[modify] https://crrev.com/0d26e79ae48f4aabcc86ebba3df8ea85776f7754/chrome/browser/resource_coordinator/tab_lifecycle_unit_source.h
[modify] https://crrev.com/0d26e79ae48f4aabcc86ebba3df8ea85776f7754/chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
[modify] https://crrev.com/0d26e79ae48f4aabcc86ebba3df8ea85776f7754/chrome/test/base/testing_browser_process.cc

Comment 7 by sebmarchand@chromium.org, Sep 14

Status: Fixed (was: Assigned)
The Chromium-side work of this is done.
►

Sign in to add a comment