New issue
Advanced search Search tips

Issue 773382 link

Starred by 2 users
Status: Verified
Owner:
sebmarchand@chromium.org
Closed: Jan 16
Cc:
chrisha@chromium.org
fdoray@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on: View detail
issue 825226
issue 826446
issue 826471
Blocking:
issue 727353



Sign in to add a comment

TMT needs a local heuristic database

Project Member Reported by chrisha@chromium.org, Oct 10 2017 
Feature description:
"Too Many Tabs" needs a local database of heuristics data in order to determine discard/suspend/throttle eligibility on a per origin basis.

Eng owner: pmonette@, chrisha@
Product owner: TBD

Design doc:

https://docs.google.com/document/d/1ywq_esMEBnNpG_2lYGfExBsLftfsFv64WpBBspAeJ74/edit

Are you planning on experimenting before launch? yes
Any new strings? no
Any implications for Google webservices (i.e. sync, translate)? no
Binary size? no
Do the existing perf tests exercise all aspects of your new feature(s)? mostly

Comment 1 by sebmarchand@chromium.org, Feb 6 2018

Owner: sebmarchand@chromium.org

Comment 2 by sebmarchand@chromium.org, Feb 7 2018

Cc: fdoray@chromium.org
+fdoray@ as you'll probably be my reviewer for most of this work :).

I'll start implementing the design (API) described in Chris' design doc, I think that the "Proposed API" section of the document is sufficient for now and so I'll start working on this. I'll do a bottom up approach, starting with the SiteFeature logic and working my way up to the actual database, if things become more complex than what's described in the design doc then I'll make another one to discuss the actual implementation.

Comment 3 by sebmarchand@chromium.org, Mar 23 2018

Blockedon: 825226

Comment 4 by sebmarchand@chromium.org, Mar 27 2018

Blockedon: 826446

Comment 5 by sebmarchand@chromium.org, Mar 27 2018

Blockedon: 826471
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29ed9114f31f8ad61a24b91810f3d0bd866a1d57

commit 29ed9114f31f8ad61a24b91810f3d0bd866a1d57
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Tue Apr 10 14:27:34 2018

Add the base for the local site characteristics observations.

Initial piece of the Site Characteristics Local Database[1], this is the
internal class that will be used by the LocalSiteCharacteristicsDataStore.

Bug:  773382 
Change-Id: Ic125fb1200b0b22bf4c985eff4f140d7db2357c3

[1] @google: https://docs.google.com/document/d/1OODhTnNu4v9dUv6tl6i2vofh0K2DS1OM6EfKs5ewbPA/edit?usp=sharing

Change-Id: Ic125fb1200b0b22bf4c985eff4f140d7db2357c3
Bug:  773382 
Reviewed-on: https://chromium-review.googlesource.com/976603
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549521}
[modify] https://crrev.com/29ed9114f31f8ad61a24b91810f3d0bd866a1d57/chrome/browser/BUILD.gn
[modify] https://crrev.com/29ed9114f31f8ad61a24b91810f3d0bd866a1d57/chrome/browser/resource_coordinator/BUILD.gn
[add] https://crrev.com/29ed9114f31f8ad61a24b91810f3d0bd866a1d57/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[add] https://crrev.com/29ed9114f31f8ad61a24b91810f3d0bd866a1d57/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[add] https://crrev.com/29ed9114f31f8ad61a24b91810f3d0bd866a1d57/chrome/browser/resource_coordinator/local_site_characteristics_data_impl_unittest.cc
[add] https://crrev.com/29ed9114f31f8ad61a24b91810f3d0bd866a1d57/chrome/browser/resource_coordinator/site_characteristics.proto
[modify] https://crrev.com/29ed9114f31f8ad61a24b91810f3d0bd866a1d57/chrome/test/BUILD.gn
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9fdf22e321f739125a0c66ce1e44587518fc67f

commit e9fdf22e321f739125a0c66ce1e44587518fc67f
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Mon Apr 23 16:06:22 2018

Add the SiteCharacteristicsDataStore class.

See the (@google.com) design doc: https://docs.google.com/document/d/1MgyIJ096pQChpbqQIqXHTZ0NYRXAOxcBtAq2lJplOpE/edit?usp=sharing

Bug:  773382 
Change-Id: Ieff80131e2df38867c059047467abefdd9fe06a7
Reviewed-on: https://chromium-review.googlesource.com/1011253
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552718}
[modify] https://crrev.com/e9fdf22e321f739125a0c66ce1e44587518fc67f/chrome/browser/BUILD.gn
[modify] https://crrev.com/e9fdf22e321f739125a0c66ce1e44587518fc67f/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/e9fdf22e321f739125a0c66ce1e44587518fc67f/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/e9fdf22e321f739125a0c66ce1e44587518fc67f/chrome/browser/resource_coordinator/local_site_characteristics_data_impl_unittest.cc
[modify] https://crrev.com/e9fdf22e321f739125a0c66ce1e44587518fc67f/chrome/browser/resource_coordinator/local_site_characteristics_data_reader.h
[modify] https://crrev.com/e9fdf22e321f739125a0c66ce1e44587518fc67f/chrome/browser/resource_coordinator/local_site_characteristics_data_reader_unittest.cc
[add] https://crrev.com/e9fdf22e321f739125a0c66ce1e44587518fc67f/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[add] https://crrev.com/e9fdf22e321f739125a0c66ce1e44587518fc67f/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[add] https://crrev.com/e9fdf22e321f739125a0c66ce1e44587518fc67f/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
[add] https://crrev.com/e9fdf22e321f739125a0c66ce1e44587518fc67f/chrome/browser/resource_coordinator/local_site_characteristics_data_unittest_utils.cc
[add] https://crrev.com/e9fdf22e321f739125a0c66ce1e44587518fc67f/chrome/browser/resource_coordinator/local_site_characteristics_data_unittest_utils.h
[add] https://crrev.com/e9fdf22e321f739125a0c66ce1e44587518fc67f/chrome/browser/resource_coordinator/site_characteristics_data_store.h
[modify] https://crrev.com/e9fdf22e321f739125a0c66ce1e44587518fc67f/chrome/test/BUILD.gn
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f3fa39638374607ae68036a28d3aabdf274d9ce

commit 5f3fa39638374607ae68036a28d3aabdf274d9ce
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Mon Apr 23 17:07:10 2018

Put the feature observation windows behind the Proactive tab discard experiment

Bug:  773382 
Change-Id: Ibdaa19b8c9074e44f5ecd5984953d00d06d48f1a
Reviewed-on: https://chromium-review.googlesource.com/1022001
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552734}
[modify] https://crrev.com/5f3fa39638374607ae68036a28d3aabdf274d9ce/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/5f3fa39638374607ae68036a28d3aabdf274d9ce/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/5f3fa39638374607ae68036a28d3aabdf274d9ce/chrome/browser/resource_coordinator/local_site_characteristics_data_impl_unittest.cc
[modify] https://crrev.com/5f3fa39638374607ae68036a28d3aabdf274d9ce/chrome/browser/resource_coordinator/tab_manager_features.cc
[modify] https://crrev.com/5f3fa39638374607ae68036a28d3aabdf274d9ce/chrome/browser/resource_coordinator/tab_manager_features.h
[modify] https://crrev.com/5f3fa39638374607ae68036a28d3aabdf274d9ce/chrome/browser/resource_coordinator/tab_manager_features_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f30423a2ad05c0f5cf85b6177815a2a64d512b6

commit 9f30423a2ad05c0f5cf85b6177815a2a64d512b6
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Apr 27 21:26:02 2018

Make the LocalSiteCharacteristicsDataStore a HistoryServiceObserver

Implement HistoryServiceObserver::OnURLsDeleted to remove all
observations when the history gets cleared.

BUG:  773382 
Change-Id: I65026cfda256c252e33aea01d6c8db8fef30dd10
Reviewed-on: https://chromium-review.googlesource.com/1030853
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554514}
[modify] https://crrev.com/9f30423a2ad05c0f5cf85b6177815a2a64d512b6/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/9f30423a2ad05c0f5cf85b6177815a2a64d512b6/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/9f30423a2ad05c0f5cf85b6177815a2a64d512b6/chrome/browser/resource_coordinator/local_site_characteristics_data_impl_unittest.cc
[modify] https://crrev.com/9f30423a2ad05c0f5cf85b6177815a2a64d512b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/9f30423a2ad05c0f5cf85b6177815a2a64d512b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[modify] https://crrev.com/9f30423a2ad05c0f5cf85b6177815a2a64d512b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5c26c1c6b94297d05b1ef29ed7610ed011cf7f9

commit c5c26c1c6b94297d05b1ef29ed7610ed011cf7f9
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Thu May 03 23:22:52 2018

Add the LocalSiteCharacteristicsDataWriter class

This class will be used to forward feature usage events to the site
characteristics database.

Bug:  773382 
Change-Id: Ibe7197a44c68f231c7aea61c85fe2ba77c3d5076
Reviewed-on: https://chromium-review.googlesource.com/1042906
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555901}
[modify] https://crrev.com/c5c26c1c6b94297d05b1ef29ed7610ed011cf7f9/chrome/browser/BUILD.gn
[modify] https://crrev.com/c5c26c1c6b94297d05b1ef29ed7610ed011cf7f9/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/c5c26c1c6b94297d05b1ef29ed7610ed011cf7f9/chrome/browser/resource_coordinator/local_site_characteristics_data_reader_unittest.cc
[modify] https://crrev.com/c5c26c1c6b94297d05b1ef29ed7610ed011cf7f9/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/c5c26c1c6b94297d05b1ef29ed7610ed011cf7f9/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[modify] https://crrev.com/c5c26c1c6b94297d05b1ef29ed7610ed011cf7f9/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
[add] https://crrev.com/c5c26c1c6b94297d05b1ef29ed7610ed011cf7f9/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.cc
[add] https://crrev.com/c5c26c1c6b94297d05b1ef29ed7610ed011cf7f9/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.h
[add] https://crrev.com/c5c26c1c6b94297d05b1ef29ed7610ed011cf7f9/chrome/browser/resource_coordinator/local_site_characteristics_data_writer_unittest.cc
[modify] https://crrev.com/c5c26c1c6b94297d05b1ef29ed7610ed011cf7f9/chrome/test/BUILD.gn
Project Member

Comment 13 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b77f51e02a06f87dbd29eb59a81091c1b5f31681

commit b77f51e02a06f87dbd29eb59a81091c1b5f31681
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Thu May 10 16:29:10 2018

Add a SiteCharacteristicsNoopDataWriter class

This will be used as a part of the Site Characteristics Database to make
sure that we don't record anything during incognito sessions.

Bug:  773382 
Change-Id: Ia4de800fde921ce04ce6612e80d34842b62ace8e
Reviewed-on: https://chromium-review.googlesource.com/1053100
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557551}
[modify] https://crrev.com/b77f51e02a06f87dbd29eb59a81091c1b5f31681/chrome/browser/BUILD.gn
[modify] https://crrev.com/b77f51e02a06f87dbd29eb59a81091c1b5f31681/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/b77f51e02a06f87dbd29eb59a81091c1b5f31681/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[modify] https://crrev.com/b77f51e02a06f87dbd29eb59a81091c1b5f31681/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.h
[add] https://crrev.com/b77f51e02a06f87dbd29eb59a81091c1b5f31681/chrome/browser/resource_coordinator/local_site_characteristics_noop_data_writer.cc
[add] https://crrev.com/b77f51e02a06f87dbd29eb59a81091c1b5f31681/chrome/browser/resource_coordinator/local_site_characteristics_noop_data_writer.h
[add] https://crrev.com/b77f51e02a06f87dbd29eb59a81091c1b5f31681/chrome/browser/resource_coordinator/site_characteristics_data_writer.h
Project Member

Comment 14 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc30f712251ab8233152152e05c6a3a2f48b601b

commit bc30f712251ab8233152152e05c6a3a2f48b601b
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Thu May 10 16:57:58 2018

Add a SiteCharacteristicsDataStore that doesn't record anything.

For use in incognito sessions.

Bug:  773382 
Change-Id: I5222eeb2de25c4b5a87e5a41b261d99cbea6de54
Reviewed-on: https://chromium-review.googlesource.com/1053180
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557559}
[modify] https://crrev.com/bc30f712251ab8233152152e05c6a3a2f48b601b/chrome/browser/BUILD.gn
[modify] https://crrev.com/bc30f712251ab8233152152e05c6a3a2f48b601b/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[add] https://crrev.com/bc30f712251ab8233152152e05c6a3a2f48b601b/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.cc
[add] https://crrev.com/bc30f712251ab8233152152e05c6a3a2f48b601b/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.h
[add] https://crrev.com/bc30f712251ab8233152152e05c6a3a2f48b601b/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store_unittest.cc
[modify] https://crrev.com/bc30f712251ab8233152152e05c6a3a2f48b601b/chrome/browser/resource_coordinator/site_characteristics_data_store.h
[modify] https://crrev.com/bc30f712251ab8233152152e05c6a3a2f48b601b/chrome/test/BUILD.gn
Project Member

Comment 15 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670

commit 66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Thu May 10 19:04:53 2018

Add the leveldb site characteristic DB

This is an initial implementation that currently requires that all
tests run on a thread allowed to do IO operations. A follow-up CL will
focus on moving all the blocking operations to a separate thread.

BUG= 773382 

Change-Id: Iea5ee2ede75f4fff168f6546b515018f0fd2a0ca
Reviewed-on: https://chromium-review.googlesource.com/1005444
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557611}
[modify] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/BUILD.gn
[add] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.cc
[add] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.h
[add] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/resource_coordinator/leveldb_site_characteristics_database_unittest.cc
[modify] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/resource_coordinator/local_site_characteristics_data_impl_unittest.cc
[modify] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/resource_coordinator/local_site_characteristics_data_reader_unittest.cc
[modify] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[modify] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
[modify] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/resource_coordinator/local_site_characteristics_data_unittest_utils.cc
[modify] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/resource_coordinator/local_site_characteristics_data_unittest_utils.h
[modify] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/resource_coordinator/local_site_characteristics_data_writer_unittest.cc
[add] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/browser/resource_coordinator/local_site_characteristics_database.h
[modify] https://crrev.com/66a8e2e83cd4a5f03a5ce6c31c730b6a1ed2d670/chrome/test/BUILD.gn
Project Member

Comment 16 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/390e0bdb5e0f68135e273ad81594c752b4d34fe5

commit 390e0bdb5e0f68135e273ad81594c752b4d34fe5
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri May 18 15:41:46 2018

Site Characteristics DB: Move the I/O ops to a blocking TaskRunner.

Bug:  773382 
Change-Id: I4c89b6b6706a7bffba19122447ea6b1a31095afc
Reviewed-on: https://chromium-review.googlesource.com/1059697
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559904}
[modify] https://crrev.com/390e0bdb5e0f68135e273ad81594c752b4d34fe5/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.cc
[modify] https://crrev.com/390e0bdb5e0f68135e273ad81594c752b4d34fe5/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.h
[modify] https://crrev.com/390e0bdb5e0f68135e273ad81594c752b4d34fe5/chrome/browser/resource_coordinator/leveldb_site_characteristics_database_unittest.cc
[modify] https://crrev.com/390e0bdb5e0f68135e273ad81594c752b4d34fe5/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/390e0bdb5e0f68135e273ad81594c752b4d34fe5/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/390e0bdb5e0f68135e273ad81594c752b4d34fe5/chrome/browser/resource_coordinator/local_site_characteristics_data_impl_unittest.cc
[modify] https://crrev.com/390e0bdb5e0f68135e273ad81594c752b4d34fe5/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/390e0bdb5e0f68135e273ad81594c752b4d34fe5/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
[modify] https://crrev.com/390e0bdb5e0f68135e273ad81594c752b4d34fe5/chrome/browser/resource_coordinator/local_site_characteristics_data_unittest_utils.cc
[modify] https://crrev.com/390e0bdb5e0f68135e273ad81594c752b4d34fe5/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store_unittest.cc
Project Member

Comment 17 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c022bc7a796ffec22841586cc4d4b27aa4bca4cf

commit c022bc7a796ffec22841586cc4d4b27aa4bca4cf
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri May 18 17:39:44 2018

Site Characteristics DB: Fix the history observer code.

Address a TODO to make sure that the database gets cleared properly when
some/all the urls gets removed from the history.

Bug:  773382 
Change-Id: If522c91c742f2110388359efe1bfffd3d561c071
Reviewed-on: https://chromium-review.googlesource.com/1060424
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559938}
[modify] https://crrev.com/c022bc7a796ffec22841586cc4d4b27aa4bca4cf/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/c022bc7a796ffec22841586cc4d4b27aa4bca4cf/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/c022bc7a796ffec22841586cc4d4b27aa4bca4cf/chrome/browser/resource_coordinator/local_site_characteristics_data_impl_unittest.cc
[modify] https://crrev.com/c022bc7a796ffec22841586cc4d4b27aa4bca4cf/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/c022bc7a796ffec22841586cc4d4b27aa4bca4cf/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[modify] https://crrev.com/c022bc7a796ffec22841586cc4d4b27aa4bca4cf/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
Project Member

Comment 18 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a1485d2f1702265998b681cc3a1986969125a69

commit 6a1485d2f1702265998b681cc3a1986969125a69
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Wed May 23 18:39:44 2018

Add a LocalSiteCharacteristicsDataStore factory

This follows the guidelines from this page: https://www.chromium.org/developers/design-documents/profile-architecture

Bug:  773382 
Change-Id: I8517975f9881e3fa2d52fb26b16008d780255eef
Reviewed-on: https://chromium-review.googlesource.com/1047725
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561176}
[modify] https://crrev.com/6a1485d2f1702265998b681cc3a1986969125a69/chrome/browser/BUILD.gn
[modify] https://crrev.com/6a1485d2f1702265998b681cc3a1986969125a69/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/6a1485d2f1702265998b681cc3a1986969125a69/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/6a1485d2f1702265998b681cc3a1986969125a69/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[add] https://crrev.com/6a1485d2f1702265998b681cc3a1986969125a69/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.cc
[add] https://crrev.com/6a1485d2f1702265998b681cc3a1986969125a69/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.h
[add] https://crrev.com/6a1485d2f1702265998b681cc3a1986969125a69/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory_browsertest.cc
[modify] https://crrev.com/6a1485d2f1702265998b681cc3a1986969125a69/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
[modify] https://crrev.com/6a1485d2f1702265998b681cc3a1986969125a69/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.cc
[modify] https://crrev.com/6a1485d2f1702265998b681cc3a1986969125a69/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.h
[modify] https://crrev.com/6a1485d2f1702265998b681cc3a1986969125a69/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store_unittest.cc
[modify] https://crrev.com/6a1485d2f1702265998b681cc3a1986969125a69/chrome/browser/resource_coordinator/site_characteristics_data_store.h
[modify] https://crrev.com/6a1485d2f1702265998b681cc3a1986969125a69/chrome/test/BUILD.gn
Project Member

Comment 19 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/772299899d46dcfa4171b2e60e11cb097b3ddf0c

commit 772299899d46dcfa4171b2e60e11cb097b3ddf0c
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Thu May 24 20:22:53 2018

Fix a static initializer issue in LocalSiteCharImpl.

TimeDeltaToInternalRepresentation can't return a constexpr because it
uses TimeDelta::InSeconds which can't be evaluated at compile time,
remove the |kZeroIntervalInternalRepresentation| value as this doesn't
provide any clear value here.

Bug:  773382 , 846431 
Change-Id: I6b2df260742c239cc664e8476c726d4ba15731dc
Reviewed-on: https://chromium-review.googlesource.com/1072347
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561608}
[modify] https://crrev.com/772299899d46dcfa4171b2e60e11cb097b3ddf0c/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/772299899d46dcfa4171b2e60e11cb097b3ddf0c/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
Project Member

Comment 20 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48b45859d61ac14d0b833e635751bcd90fe69acf

commit 48b45859d61ac14d0b833e635751bcd90fe69acf
Author: Gabriel Charette <gab@chromium.org>
Date: Thu May 24 23:43:31 2018

Revert "Add a LocalSiteCharacteristicsDataStore factory"

This reverts commit 6a1485d2f1702265998b681cc3a1986969125a69.

Reason for revert: breaks Linux CFI,  crbug.com/846492 

Original change's description:
> Add a LocalSiteCharacteristicsDataStore factory
> 
> This follows the guidelines from this page: https://www.chromium.org/developers/design-documents/profile-architecture
> 
> Bug:  773382 
> Change-Id: I8517975f9881e3fa2d52fb26b16008d780255eef
> Reviewed-on: https://chromium-review.googlesource.com/1047725
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561176}

TBR=bauerb@chromium.org,fdoray@chromium.org,erg@chromium.org,sebmarchand@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  773382 
Change-Id: I9216725dd36891661b75a3d03a93d5298ea2dc30
Reviewed-on: https://chromium-review.googlesource.com/1072787
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561694}
[modify] https://crrev.com/48b45859d61ac14d0b833e635751bcd90fe69acf/chrome/browser/BUILD.gn
[modify] https://crrev.com/48b45859d61ac14d0b833e635751bcd90fe69acf/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/48b45859d61ac14d0b833e635751bcd90fe69acf/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/48b45859d61ac14d0b833e635751bcd90fe69acf/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[delete] https://crrev.com/f51a871867e95d71118e1c3e7c2deeae3bd6a222/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.cc
[delete] https://crrev.com/f51a871867e95d71118e1c3e7c2deeae3bd6a222/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.h
[delete] https://crrev.com/f51a871867e95d71118e1c3e7c2deeae3bd6a222/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory_browsertest.cc
[modify] https://crrev.com/48b45859d61ac14d0b833e635751bcd90fe69acf/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
[modify] https://crrev.com/48b45859d61ac14d0b833e635751bcd90fe69acf/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.cc
[modify] https://crrev.com/48b45859d61ac14d0b833e635751bcd90fe69acf/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.h
[modify] https://crrev.com/48b45859d61ac14d0b833e635751bcd90fe69acf/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store_unittest.cc
[modify] https://crrev.com/48b45859d61ac14d0b833e635751bcd90fe69acf/chrome/browser/resource_coordinator/site_characteristics_data_store.h
[modify] https://crrev.com/48b45859d61ac14d0b833e635751bcd90fe69acf/chrome/test/BUILD.gn
Project Member

Comment 21 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6

commit 5131a2dd255fa69bb6963f9fcf8510940b3eb9b6
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri May 25 18:07:02 2018

Add a LocalSiteCharacteristicsDataStore factory (Reland)

This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1072787 with fixes.

ps1 is the original CL, the fix is in ps2 the problem is that I'm casting a
LocalSiteCharacteristicsNonRecordingDataStore* to a LocalSiteCharacteristicsDataStore* instead of
a SiteCharacteristicsDataStore* (the common interface between the 2 classes)

Bug:  773382 ,  846492 
Change-Id: I6cad02e8ca771debc3b4b2028616dec8fbcaf521
Reviewed-on: https://chromium-review.googlesource.com/1073050
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561944}
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/BUILD.gn
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[add] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.cc
[add] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.h
[add] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory_browsertest.cc
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.cc
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.h
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store_unittest.cc
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/browser/resource_coordinator/site_characteristics_data_store.h
[modify] https://crrev.com/5131a2dd255fa69bb6963f9fcf8510940b3eb9b6/chrome/test/BUILD.gn
Project Member

Comment 22 by bugdroid1@chromium.org, May 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33547897fb950046c2c3b84f69d5314be6625615

commit 33547897fb950046c2c3b84f69d5314be6625615
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Mon May 28 19:01:17 2018

Local Site Char DB: Track the number of background tabs


Bug:  773382 
Change-Id: I4f829b59b6e508ea2079ed20d47ca8a539b36031
Reviewed-on: https://chromium-review.googlesource.com/1066481
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562293}
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/BUILD.gn
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_data_impl_unittest.cc
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_data_reader_unittest.cc
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.cc
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.h
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_data_writer_unittest.cc
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.cc
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.h
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store_unittest.cc
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_noop_data_writer.cc
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/local_site_characteristics_noop_data_writer.h
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/site_characteristics_data_store.h
[modify] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/site_characteristics_data_writer.h
[add] https://crrev.com/33547897fb950046c2c3b84f69d5314be6625615/chrome/browser/resource_coordinator/site_characteristics_tab_visibility.h
Project Member

Comment 24 by bugdroid1@chromium.org, May 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f21b0292f9393e0e138964ffe8d88187b795927

commit 7f21b0292f9393e0e138964ffe8d88187b795927
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Tue May 29 19:15:42 2018

RC: Pass the OnNonPersistentNotificationCreated signal to c/b/rc

This forwards the |kNonPersistentNotificationCreated| events received
in services/resource_coordinator/ to the page signal observer on the
browser side (c/b/rc). Non-persistent notifications are web
notifications created by a page, they require the page to be alive to
be created (persistent notifications are created by service workers and
don't rely on the page to be alive)

These events will be recorded in the local site characteristics
database in a further CL. We need to consider potential usage of
non-persistent web notifications before proactively discarding a tab to
make sure that we don't discard a tab that could try to communicate
with the user via non-persistent web notifications.

Bug:  773382 
Change-Id: I0245cd4514541a2f70b547d5ce9fab0e633ddf94
Reviewed-on: https://chromium-review.googlesource.com/1068665
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562539}
[modify] https://crrev.com/7f21b0292f9393e0e138964ffe8d88187b795927/chrome/browser/resource_coordinator/page_signal_receiver.cc
[modify] https://crrev.com/7f21b0292f9393e0e138964ffe8d88187b795927/chrome/browser/resource_coordinator/page_signal_receiver.h
[modify] https://crrev.com/7f21b0292f9393e0e138964ffe8d88187b795927/chrome/browser/resource_coordinator/tab_manager_resource_coordinator_signal_observer.cc
[modify] https://crrev.com/7f21b0292f9393e0e138964ffe8d88187b795927/chrome/browser/resource_coordinator/tab_manager_resource_coordinator_signal_observer.h
[modify] https://crrev.com/7f21b0292f9393e0e138964ffe8d88187b795927/services/resource_coordinator/observers/page_signal_generator_impl.cc
[modify] https://crrev.com/7f21b0292f9393e0e138964ffe8d88187b795927/services/resource_coordinator/observers/page_signal_generator_impl.h
[modify] https://crrev.com/7f21b0292f9393e0e138964ffe8d88187b795927/services/resource_coordinator/observers/page_signal_generator_impl_unittest.cc
[modify] https://crrev.com/7f21b0292f9393e0e138964ffe8d88187b795927/services/resource_coordinator/public/mojom/page_signal.mojom

Comment 25 by sebmarchand@chromium.org, May 30 2018

Components: Internals>ResourceCoordinator
Labels: Hotlist-TooManyTabs
Project Member

Comment 26 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fefbd782ee410911f407ca912a41ddb8d2623ca4

commit fefbd782ee410911f407ca912a41ddb8d2623ca4
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Thu May 31 17:44:49 2018

Makes the Local Site DB factory depend on the History service factory.

This ensures that the history service gets created before the local
site data store factory and so we can observe it.

Bug:  773382 
Change-Id: I5ffd289056199788a41d874bfbd817184e44107c
Reviewed-on: https://chromium-review.googlesource.com/1080731
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563302}
[modify] https://crrev.com/fefbd782ee410911f407ca912a41ddb8d2623ca4/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.cc
Project Member

Comment 27 by bugdroid1@chromium.org, Jun 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/699e71a6b7de508c5b51dfbe3db1b7826bf7e398

commit 699e71a6b7de508c5b51dfbe3db1b7826bf7e398
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Jun 01 17:24:48 2018

Move the site characteristics db to its own feature

Bug:  773382 
Change-Id: I0fc43eac062edcf1f9d0a6059f88e0768f1de880
Reviewed-on: https://chromium-review.googlesource.com/1081467
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563699}
[modify] https://crrev.com/699e71a6b7de508c5b51dfbe3db1b7826bf7e398/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/699e71a6b7de508c5b51dfbe3db1b7826bf7e398/chrome/browser/resource_coordinator/local_site_characteristics_data_impl_unittest.cc
[modify] https://crrev.com/699e71a6b7de508c5b51dfbe3db1b7826bf7e398/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/699e71a6b7de508c5b51dfbe3db1b7826bf7e398/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.cc
[modify] https://crrev.com/699e71a6b7de508c5b51dfbe3db1b7826bf7e398/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory_browsertest.cc
[modify] https://crrev.com/699e71a6b7de508c5b51dfbe3db1b7826bf7e398/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
[modify] https://crrev.com/699e71a6b7de508c5b51dfbe3db1b7826bf7e398/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store_unittest.cc
[modify] https://crrev.com/699e71a6b7de508c5b51dfbe3db1b7826bf7e398/chrome/browser/resource_coordinator/tab_manager_features.cc
[modify] https://crrev.com/699e71a6b7de508c5b51dfbe3db1b7826bf7e398/chrome/browser/resource_coordinator/tab_manager_features.h
[modify] https://crrev.com/699e71a6b7de508c5b51dfbe3db1b7826bf7e398/chrome/browser/resource_coordinator/tab_manager_features_unittest.cc
Project Member

Comment 28 by bugdroid1@chromium.org, Jun 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc34c2a6018deb115cadf512ae5dde37513bab13

commit fc34c2a6018deb115cadf512ae5dde37513bab13
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Mon Jun 04 17:38:45 2018

RC: Local site DB: Switch to using url::Origin everywhere

Using string is confusing as there's multiple way to convert an origin
to a string, this let the actual Impl object decide on how to do the
conversion.

Bug:  773382 
Change-Id: I23e101090592af0973861af725a637dbe500d646
Reviewed-on: https://chromium-review.googlesource.com/1081175
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564139}
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.cc
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.h
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/leveldb_site_characteristics_database_unittest.cc
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_data_impl_unittest.cc
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_data_reader_unittest.cc
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_data_store.cc
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_data_store.h
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_data_store_unittest.cc
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_data_unittest_utils.cc
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_data_unittest_utils.h
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.h
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_data_writer_unittest.cc
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_database.h
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.cc
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store.h
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/local_site_characteristics_non_recording_data_store_unittest.cc
[modify] https://crrev.com/fc34c2a6018deb115cadf512ae5dde37513bab13/chrome/browser/resource_coordinator/site_characteristics_data_store.h
Project Member

Comment 29 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3abdf436303e1fbc42df3bbd2e28940a50f4cd60

commit 3abdf436303e1fbc42df3bbd2e28940a50f4cd60
Author: Francois Doray <fdoray@chromium.org>
Date: Tue Jun 05 14:08:51 2018

RC: Local site DB: Check SiteCharacteristicsDatabase feature in LocalSiteCharacteristicsDataStoreFactory.

Previously, LocalSiteCharacteristicsDataStoreFactory incorrectly
checked the ProactiveTabFreezeAndDiscard feature.

Bug:  773382 
Change-Id: I2958d923f564574f6620ef8e103a3a692f17c819
Reviewed-on: https://chromium-review.googlesource.com/1085641
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564478}
[modify] https://crrev.com/3abdf436303e1fbc42df3bbd2e28940a50f4cd60/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.cc
Project Member

Comment 30 by bugdroid1@chromium.org, Jun 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dcdc176057f09290249256f0054f460944903d6

commit 1dcdc176057f09290249256f0054f460944903d6
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Mon Jun 11 18:03:50 2018

Add the LocalSiteCharDataWriter observer.

This also makes LocalSiteCharacteristicsDataWriter easier to use,
visibility and load/unload events can be received multiple times, the
writer will just ignore them if the current state hasn't changed.

Bug:  773382 
Change-Id: I0c11a1b040ea51ccaee881cbc4e36e3099ca7348
Reviewed-on: https://chromium-review.googlesource.com/1070537
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566054}
[modify] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/browser/BUILD.gn
[modify] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.cc
[modify] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/browser/resource_coordinator/local_site_characteristics_data_store_factory.h
[modify] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.cc
[modify] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.h
[modify] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/browser/resource_coordinator/local_site_characteristics_data_writer_unittest.cc
[modify] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/browser/resource_coordinator/local_site_characteristics_noop_data_writer.cc
[modify] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/browser/resource_coordinator/local_site_characteristics_noop_data_writer.h
[add] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.cc
[add] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.h
[add] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer_unittest.cc
[modify] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/browser/resource_coordinator/site_characteristics_data_writer.h
[modify] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/browser/resource_coordinator/tab_load_tracker.h
[modify] https://crrev.com/1dcdc176057f09290249256f0054f460944903d6/chrome/test/BUILD.gn
Project Member

Comment 31 by bugdroid1@chromium.org, Jun 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60e2fc181c9dd3648359b51f4128c5e1d59b1b7e

commit 60e2fc181c9dd3648359b51f4128c5e1d59b1b7e
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Jun 15 18:44:41 2018

RC: Minor fixes to the LocalSiteCharacteristicsWebContentsObserver

- Ignore navigation events happening in a subframe or within a document.
- The DataWriters assume that a site is unloaded by default, mark them
  as loaded if needed.

Bug:  773382 
Change-Id: I786018b7e43925ff78849f508dfbe36d4dd891ef
Reviewed-on: https://chromium-review.googlesource.com/1099188
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567747}
[modify] https://crrev.com/60e2fc181c9dd3648359b51f4128c5e1d59b1b7e/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.cc
Project Member

Comment 32 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f4ffc9aee7851b534ff57b9a1a231c410673d9a

commit 8f4ffc9aee7851b534ff57b9a1a231c410673d9a
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Tue Jun 19 17:48:11 2018

RC: Connect the Local DB to TabHelper and add browsertests.

Bug:  773382 
Change-Id: Ie7cbbf2c74bfbf1f1522b2a1f775a392545ad0a9
Reviewed-on: https://chromium-review.googlesource.com/1088196
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568519}
[modify] https://crrev.com/8f4ffc9aee7851b534ff57b9a1a231c410673d9a/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/8f4ffc9aee7851b534ff57b9a1a231c410673d9a/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.cc
[add] https://crrev.com/8f4ffc9aee7851b534ff57b9a1a231c410673d9a/chrome/browser/resource_coordinator/local_site_characteristics_database_browsertest.cc
[modify] https://crrev.com/8f4ffc9aee7851b534ff57b9a1a231c410673d9a/chrome/browser/resource_coordinator/tab_helper.cc
[modify] https://crrev.com/8f4ffc9aee7851b534ff57b9a1a231c410673d9a/chrome/browser/resource_coordinator/tab_helper.h
[modify] https://crrev.com/8f4ffc9aee7851b534ff57b9a1a231c410673d9a/chrome/test/BUILD.gn
[add] https://crrev.com/8f4ffc9aee7851b534ff57b9a1a231c410673d9a/chrome/test/data/resource_coordinator/default_favicon.png
[add] https://crrev.com/8f4ffc9aee7851b534ff57b9a1a231c410673d9a/chrome/test/data/resource_coordinator/site_characteristics_test_page.html
[add] https://crrev.com/8f4ffc9aee7851b534ff57b9a1a231c410673d9a/chrome/test/data/resource_coordinator/test_audio.ogg
Project Member

Comment 33 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26169b9cab33fabd381bfb33a3f4dd87888a7d00

commit 26169b9cab33fabd381bfb33a3f4dd87888a7d00
Author: Sébastien Marchand <sebmarchand@chromium.org>
Date: Tue Jun 19 21:59:32 2018

Revert "RC: Connect the Local DB to TabHelper and add browsertests."

This reverts commit 8f4ffc9aee7851b534ff57b9a1a231c410673d9a.

Reason for revert: Break some tests on CrOS.

Original change's description:
> RC: Connect the Local DB to TabHelper and add browsertests.
> 
> Bug:  773382 
> Change-Id: Ie7cbbf2c74bfbf1f1522b2a1f775a392545ad0a9
> Reviewed-on: https://chromium-review.googlesource.com/1088196
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568519}

TBR=fdoray@chromium.org,sebmarchand@chromium.org

Change-Id: Id145ad7b9de4422794daba06eedeb2f54e5d28a1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  773382 
Reviewed-on: https://chromium-review.googlesource.com/1106978
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568611}
[modify] https://crrev.com/26169b9cab33fabd381bfb33a3f4dd87888a7d00/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/26169b9cab33fabd381bfb33a3f4dd87888a7d00/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.cc
[delete] https://crrev.com/035d038b828db503c8a4c597d351f8b5f04b24f8/chrome/browser/resource_coordinator/local_site_characteristics_database_browsertest.cc
[modify] https://crrev.com/26169b9cab33fabd381bfb33a3f4dd87888a7d00/chrome/browser/resource_coordinator/tab_helper.cc
[modify] https://crrev.com/26169b9cab33fabd381bfb33a3f4dd87888a7d00/chrome/browser/resource_coordinator/tab_helper.h
[modify] https://crrev.com/26169b9cab33fabd381bfb33a3f4dd87888a7d00/chrome/test/BUILD.gn
[delete] https://crrev.com/035d038b828db503c8a4c597d351f8b5f04b24f8/chrome/test/data/resource_coordinator/default_favicon.png
[delete] https://crrev.com/035d038b828db503c8a4c597d351f8b5f04b24f8/chrome/test/data/resource_coordinator/site_characteristics_test_page.html
[delete] https://crrev.com/035d038b828db503c8a4c597d351f8b5f04b24f8/chrome/test/data/resource_coordinator/test_audio.ogg
Project Member

Comment 34 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdb95bb929f0a6522d21fac95d1687e86ca3431a

commit bdb95bb929f0a6522d21fac95d1687e86ca3431a
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Thu Jun 21 17:14:06 2018

Reland "RC: Connect the Local DB to TabHelper and add browsertests."

This is a reland of 8f4ffc9aee7851b534ff57b9a1a231c410673d9a with a fix
for a flakiness in LocalSiteCharacteristicsDatabaseTest.PRE_ClearHistory,
the HistoryService::Delete task didn't always had time to run before we
assumed that the entry had been removed from the history, this fix this
by running RunUntilIdle() several time (until the deletion has
complete)



Original change's description:
> RC: Connect the Local DB to TabHelper and add browsertests.
>
> Bug:  773382 
> Change-Id: Ie7cbbf2c74bfbf1f1522b2a1f775a392545ad0a9
> Reviewed-on: https://chromium-review.googlesource.com/1088196
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568519}

Bug:  773382 
Change-Id: I05072f974d70c200fff87e0239c8537c8d0bcfc8
Reviewed-on: https://chromium-review.googlesource.com/1106940
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569311}
[modify] https://crrev.com/bdb95bb929f0a6522d21fac95d1687e86ca3431a/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/bdb95bb929f0a6522d21fac95d1687e86ca3431a/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.cc
[add] https://crrev.com/bdb95bb929f0a6522d21fac95d1687e86ca3431a/chrome/browser/resource_coordinator/local_site_characteristics_database_browsertest.cc
[modify] https://crrev.com/bdb95bb929f0a6522d21fac95d1687e86ca3431a/chrome/browser/resource_coordinator/tab_helper.cc
[modify] https://crrev.com/bdb95bb929f0a6522d21fac95d1687e86ca3431a/chrome/browser/resource_coordinator/tab_helper.h
[modify] https://crrev.com/bdb95bb929f0a6522d21fac95d1687e86ca3431a/chrome/test/BUILD.gn
[add] https://crrev.com/bdb95bb929f0a6522d21fac95d1687e86ca3431a/chrome/test/data/resource_coordinator/default_favicon.png
[add] https://crrev.com/bdb95bb929f0a6522d21fac95d1687e86ca3431a/chrome/test/data/resource_coordinator/site_characteristics_test_page.html
[add] https://crrev.com/bdb95bb929f0a6522d21fac95d1687e86ca3431a/chrome/test/data/resource_coordinator/test_audio.ogg
Project Member

Comment 35 by bugdroid1@chromium.org, Jun 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4faa64eb5cfc5463a4e2bbff6d097788a1c64c0

commit f4faa64eb5cfc5463a4e2bbff6d097788a1c64c0
Author: weiliangc <weiliangc@chromium.org>
Date: Thu Jun 21 17:28:59 2018

Revert "Reland "RC: Connect the Local DB to TabHelper and add browsertests.""

This reverts commit bdb95bb929f0a6522d21fac95d1687e86ca3431a.

Reason for revert:  crbug.com/855107 

../../chrome/browser/resource_coordinator/local_site_characteristics_database_browsertest.cc:15:10: fatal error: 'chrome/browser/notifications/desktop_notification_profile_util.h' file not found
#include "chrome/browser/notifications/desktop_notification_profile_util.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Original change's description:
> Reland "RC: Connect the Local DB to TabHelper and add browsertests."
> 
> This is a reland of 8f4ffc9aee7851b534ff57b9a1a231c410673d9a with a fix
> for a flakiness in LocalSiteCharacteristicsDatabaseTest.PRE_ClearHistory,
> the HistoryService::Delete task didn't always had time to run before we
> assumed that the entry had been removed from the history, this fix this
> by running RunUntilIdle() several time (until the deletion has
> complete)
> 
> 
> 
> Original change's description:
> > RC: Connect the Local DB to TabHelper and add browsertests.
> >
> > Bug:  773382 
> > Change-Id: Ie7cbbf2c74bfbf1f1522b2a1f775a392545ad0a9
> > Reviewed-on: https://chromium-review.googlesource.com/1088196
> > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> > Reviewed-by: François Doray <fdoray@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#568519}
> 
> Bug:  773382 
> Change-Id: I05072f974d70c200fff87e0239c8537c8d0bcfc8
> Reviewed-on: https://chromium-review.googlesource.com/1106940
> Commit-Queue: François Doray <fdoray@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569311}

TBR=fdoray@chromium.org,sebmarchand@chromium.org

Change-Id: I7d78bd84033e6ad7ea2ff30be3f4b28d86ababd1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  773382 
Reviewed-on: https://chromium-review.googlesource.com/1110417
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569312}
[modify] https://crrev.com/f4faa64eb5cfc5463a4e2bbff6d097788a1c64c0/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/f4faa64eb5cfc5463a4e2bbff6d097788a1c64c0/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.cc
[delete] https://crrev.com/bdb95bb929f0a6522d21fac95d1687e86ca3431a/chrome/browser/resource_coordinator/local_site_characteristics_database_browsertest.cc
[modify] https://crrev.com/f4faa64eb5cfc5463a4e2bbff6d097788a1c64c0/chrome/browser/resource_coordinator/tab_helper.cc
[modify] https://crrev.com/f4faa64eb5cfc5463a4e2bbff6d097788a1c64c0/chrome/browser/resource_coordinator/tab_helper.h
[modify] https://crrev.com/f4faa64eb5cfc5463a4e2bbff6d097788a1c64c0/chrome/test/BUILD.gn
[delete] https://crrev.com/bdb95bb929f0a6522d21fac95d1687e86ca3431a/chrome/test/data/resource_coordinator/default_favicon.png
[delete] https://crrev.com/bdb95bb929f0a6522d21fac95d1687e86ca3431a/chrome/test/data/resource_coordinator/site_characteristics_test_page.html
[delete] https://crrev.com/bdb95bb929f0a6522d21fac95d1687e86ca3431a/chrome/test/data/resource_coordinator/test_audio.ogg
Project Member

Comment 36 by bugdroid1@chromium.org, Jun 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cda88a0b934cd379e855cf60fe45e07eceb094e

commit 8cda88a0b934cd379e855cf60fe45e07eceb094e
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Jun 22 13:43:11 2018

Reland "Reland "RC: Connect the Local DB to TabHelper and add browsertests.""

This is a reland of bdb95bb929f0a6522d21fac95d1687e86ca3431a with a fix
for a conflict with https://chromium-review.googlesource.com/c/chromium/src/+/1093091

Original change's description:
> Reland "RC: Connect the Local DB to TabHelper and add browsertests."
>
> This is a reland of 8f4ffc9aee7851b534ff57b9a1a231c410673d9a with a fix
> for a flakiness in LocalSiteCharacteristicsDatabaseTest.PRE_ClearHistory,
> the HistoryService::Delete task didn't always had time to run before we
> assumed that the entry had been removed from the history, this fix this
> by running RunUntilIdle() several time (until the deletion has
> complete)
>
>
>
> Original change's description:
> > RC: Connect the Local DB to TabHelper and add browsertests.
> >
> > Bug:  773382 
> > Change-Id: Ie7cbbf2c74bfbf1f1522b2a1f775a392545ad0a9
> > Reviewed-on: https://chromium-review.googlesource.com/1088196
> > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> > Reviewed-by: François Doray <fdoray@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#568519}
>
> Bug:  773382 
> Change-Id: I05072f974d70c200fff87e0239c8537c8d0bcfc8
> Reviewed-on: https://chromium-review.googlesource.com/1106940
> Commit-Queue: François Doray <fdoray@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569311}

TBR: fdoray@chromium.org
Bug:  773382 
Change-Id: I9b2f648f30d418b22972d4eadd026311971a5ae9
Reviewed-on: https://chromium-review.googlesource.com/1110002
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569595}
[modify] https://crrev.com/8cda88a0b934cd379e855cf60fe45e07eceb094e/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/8cda88a0b934cd379e855cf60fe45e07eceb094e/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.cc
[add] https://crrev.com/8cda88a0b934cd379e855cf60fe45e07eceb094e/chrome/browser/resource_coordinator/local_site_characteristics_database_browsertest.cc
[modify] https://crrev.com/8cda88a0b934cd379e855cf60fe45e07eceb094e/chrome/browser/resource_coordinator/tab_helper.cc
[modify] https://crrev.com/8cda88a0b934cd379e855cf60fe45e07eceb094e/chrome/browser/resource_coordinator/tab_helper.h
[modify] https://crrev.com/8cda88a0b934cd379e855cf60fe45e07eceb094e/chrome/test/BUILD.gn
[add] https://crrev.com/8cda88a0b934cd379e855cf60fe45e07eceb094e/chrome/test/data/resource_coordinator/default_favicon.png
[add] https://crrev.com/8cda88a0b934cd379e855cf60fe45e07eceb094e/chrome/test/data/resource_coordinator/site_characteristics_test_page.html
[add] https://crrev.com/8cda88a0b934cd379e855cf60fe45e07eceb094e/chrome/test/data/resource_coordinator/test_audio.ogg
Project Member

Comment 38 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1095c4021730170204ad493521e345ad8738965c

commit 1095c4021730170204ad493521e345ad8738965c
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Jun 29 21:43:43 2018

RC: LocalDB: Fix crashes in cases where the DB can't be initialized

Bug: 859049,  773382 
Change-Id: Ifc45ce7b154f7a5abf74fed09f92c1e3eb8c4b8a
Reviewed-on: https://chromium-review.googlesource.com/1120843
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571649}
[modify] https://crrev.com/1095c4021730170204ad493521e345ad8738965c/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.cc
[modify] https://crrev.com/1095c4021730170204ad493521e345ad8738965c/chrome/browser/resource_coordinator/leveldb_site_characteristics_database_unittest.cc
Project Member

Comment 39 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7394cf6f43d7a86630d3eb1c728fd63c621b5530

commit 7394cf6f43d7a86630d3eb1c728fd63c621b5530
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Jul 06 00:01:06 2018

Connect the LocalDB to TabManager.

Bug:  773382 
Change-Id: Iec8fe5226ee175105d51f300f30b4865478ac099
Reviewed-on: https://chromium-review.googlesource.com/1118611
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572871}
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/local_site_characteristics_data_reader.h
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/local_site_characteristics_data_unittest_utils.cc
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/local_site_characteristics_data_unittest_utils.h
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/local_site_characteristics_data_writer.h
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/local_site_characteristics_database_browsertest.cc
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.cc
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.h
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer_unittest.cc
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/tab_helper.h
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/tab_lifecycle_unit_source_unittest.cc
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/tab_manager_browsertest.cc
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/tab_manager_unittest.cc
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/test_lifecycle_unit.cc
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/utils.cc
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/browser/resource_coordinator/utils.h
[modify] https://crrev.com/7394cf6f43d7a86630d3eb1c728fd63c621b5530/chrome/test/BUILD.gn
Project Member

Comment 40 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92128456e2d2afbd7480ba8b9b7e74ea2d57c462

commit 92128456e2d2afbd7480ba8b9b7e74ea2d57c462
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Jul 06 20:39:42 2018

RC: LocalDB: Report the observation time when a feature gets used

Bug:  773382 
Change-Id: Ica219b6a63a09d402b14fb7f7833c6dfa5c9309b
Reviewed-on: https://chromium-review.googlesource.com/1125125
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573059}
[modify] https://crrev.com/92128456e2d2afbd7480ba8b9b7e74ea2d57c462/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/92128456e2d2afbd7480ba8b9b7e74ea2d57c462/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/92128456e2d2afbd7480ba8b9b7e74ea2d57c462/tools/metrics/histograms/histograms.xml
Project Member

Comment 41 by bugdroid1@chromium.org, Jul 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a732a279df4a3ba4780aa7e1c9c122556d316bb5

commit a732a279df4a3ba4780aa7e1c9c122556d316bb5
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Mon Jul 09 19:08:28 2018

RC: Report the on disk size of the local database.

Bug:  773382 
Change-Id: I6cf4d2fc30efdd8f00d67badc1cb8233aab05f46
Reviewed-on: https://chromium-review.googlesource.com/1127353
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573396}
[modify] https://crrev.com/a732a279df4a3ba4780aa7e1c9c122556d316bb5/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.cc
[modify] https://crrev.com/a732a279df4a3ba4780aa7e1c9c122556d316bb5/tools/metrics/histograms/histograms.xml
Project Member

Comment 43 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fad21df66a5d3a6f39be2cf1390c9a784524db6

commit 5fad21df66a5d3a6f39be2cf1390c9a784524db6
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Tue Jul 10 17:30:33 2018

RC: Add the ResourceCoordinator.LocalDB.ReadHasCompletedBeforeQuery metric

Bug:  773382 
Change-Id: I12b92ff4ffc8cc379f8a4583728e1e5aa6f188e7
Reviewed-on: https://chromium-review.googlesource.com/1127261
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573792}
[modify] https://crrev.com/5fad21df66a5d3a6f39be2cf1390c9a784524db6/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/5fad21df66a5d3a6f39be2cf1390c9a784524db6/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h
[modify] https://crrev.com/5fad21df66a5d3a6f39be2cf1390c9a784524db6/tools/metrics/histograms/histograms.xml
Project Member

Comment 45 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec61662d85a62c81c48dca04e4a6f2ba599967c0

commit ec61662d85a62c81c48dca04e4a6f2ba599967c0
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Tue Jul 10 22:36:07 2018

Ensure that all members of LocalSiteCharWCObserver are initialized

Follow up on https://chromium-review.googlesource.com/c/chromium/src/+/1131556

Bug:  773382 
Change-Id: Idddda163085d58aa4a351ae528544dd9968daaf1
Reviewed-on: https://chromium-review.googlesource.com/1132107
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573955}
[modify] https://crrev.com/ec61662d85a62c81c48dca04e4a6f2ba599967c0/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.h
Project Member

Comment 46 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f41c1a2339eac2ba4b5e1c32088ecbc0d02460c6

commit f41c1a2339eac2ba4b5e1c32088ecbc0d02460c6
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Thu Jul 19 18:31:59 2018

RC - LocalDB: Fix the tracking of the observation windows

This fix an issue causing the observation windows to not be persisted
across sessions. There's a logic bug in the code responsible of merging
the current observation with the one from the database.

Bug:  773382 
Change-Id: I92c7937413365a5f45fbdbda697380d86af60215
Reviewed-on: https://chromium-review.googlesource.com/1143708
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576566}
[modify] https://crrev.com/f41c1a2339eac2ba4b5e1c32088ecbc0d02460c6/chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc
[modify] https://crrev.com/f41c1a2339eac2ba4b5e1c32088ecbc0d02460c6/chrome/browser/resource_coordinator/local_site_characteristics_database_browsertest.cc
Project Member

Comment 47 by bugdroid1@chromium.org, Jul 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d2a7a012c900d727158d98f791871856e3d5231

commit 4d2a7a012c900d727158d98f791871856e3d5231
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Mon Jul 23 22:27:18 2018

RC: Ignore some feature usage happening right after loading/bg-ing

- Ignore the title/favicon changes happening during the first few seconds
  following the transition to the loaded state for a tab, some sites seems
  update their favicon immediately after loading (e.g. cs.chromium.org)
  without this being an attempt to communicate with the user. The grace
  period is controlled by the "TitleOrFaviconChangeGracePeriod" variation
  of the "SiteCharacteristicsDatabase" feature.
- Ignore the audio usage happening during the first few seconds after
  backgrounding a page: this is something that can happen if a user start
  some media (e.g. a video on YouTube) and switch to a different tab before
  the video has actually started to play. The grace period is controlled by
  the "AudioUsageGracePeriod" variation of the "SiteCharacteristicsDatabase"
  feature.

Bug:  773382 
Change-Id: I4790fa976add5840bdb9cb5d78c402cba8577669
Reviewed-on: https://chromium-review.googlesource.com/1145707
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577300}
[modify] https://crrev.com/4d2a7a012c900d727158d98f791871856e3d5231/chrome/browser/resource_coordinator/local_site_characteristics_database_browsertest.cc
[modify] https://crrev.com/4d2a7a012c900d727158d98f791871856e3d5231/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.cc
[modify] https://crrev.com/4d2a7a012c900d727158d98f791871856e3d5231/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.h
[modify] https://crrev.com/4d2a7a012c900d727158d98f791871856e3d5231/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer_unittest.cc
[modify] https://crrev.com/4d2a7a012c900d727158d98f791871856e3d5231/chrome/browser/resource_coordinator/tab_manager_features.cc
[modify] https://crrev.com/4d2a7a012c900d727158d98f791871856e3d5231/chrome/browser/resource_coordinator/tab_manager_features.h
[modify] https://crrev.com/4d2a7a012c900d727158d98f791871856e3d5231/chrome/browser/resource_coordinator/tab_manager_features_unittest.cc
Project Member

Comment 48 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7

commit ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Wed Jul 25 15:58:05 2018

RC: Upgrade the DB version to 1

This CL adds a version number to the Local Site Characteristics DB and
reset its content if it already exists.

Bug:  773382 , 866540,  867027 
Change-Id: I0a68ad044456ab67c39a3f1537e9ff9534920d47
Reviewed-on: https://chromium-review.googlesource.com/1147113
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577912}
[modify] https://crrev.com/ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.cc
[modify] https://crrev.com/ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.h
[modify] https://crrev.com/ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7/chrome/browser/resource_coordinator/leveldb_site_characteristics_database_unittest.cc
Project Member

Comment 49 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be9460a253178bcf4e6cad9179f33c465f60eac2

commit be9460a253178bcf4e6cad9179f33c465f60eac2
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Wed Jul 25 23:04:48 2018

Add the fieldtrial testing config for ProactiveTabDiscarding.

Bug: 775644,  773382 
Change-Id: I8c0426728b31644797e6e641d16ac049ab61a8ce
Reviewed-on: https://chromium-review.googlesource.com/1148950
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578113}
[modify] https://crrev.com/be9460a253178bcf4e6cad9179f33c465f60eac2/testing/variations/fieldtrial_testing_config.json
Project Member

Comment 50 by bugdroid1@chromium.org, Jul 27

Labels: merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cfc46e773dd4d82427c219c4fa29489ac0fdb76

commit 0cfc46e773dd4d82427c219c4fa29489ac0fdb76
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Jul 27 03:59:29 2018

RC: Ignore some feature usage happening right after loading/bg-ing

- Ignore the title/favicon changes happening during the first few seconds
  following the transition to the loaded state for a tab, some sites seems
  update their favicon immediately after loading (e.g. cs.chromium.org)
  without this being an attempt to communicate with the user. The grace
  period is controlled by the "TitleOrFaviconChangeGracePeriod" variation
  of the "SiteCharacteristicsDatabase" feature.
- Ignore the audio usage happening during the first few seconds after
  backgrounding a page: this is something that can happen if a user start
  some media (e.g. a video on YouTube) and switch to a different tab before
  the video has actually started to play. The grace period is controlled by
  the "AudioUsageGracePeriod" variation of the "SiteCharacteristicsDatabase"
  feature.

Bug:  773382 
Change-Id: I4790fa976add5840bdb9cb5d78c402cba8577669
Reviewed-on: https://chromium-review.googlesource.com/1145707
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577300}(cherry picked from commit 4d2a7a012c900d727158d98f791871856e3d5231)
Reviewed-on: https://chromium-review.googlesource.com/1152647
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#138}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/0cfc46e773dd4d82427c219c4fa29489ac0fdb76/chrome/browser/resource_coordinator/local_site_characteristics_database_browsertest.cc
[modify] https://crrev.com/0cfc46e773dd4d82427c219c4fa29489ac0fdb76/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.cc
[modify] https://crrev.com/0cfc46e773dd4d82427c219c4fa29489ac0fdb76/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer.h
[modify] https://crrev.com/0cfc46e773dd4d82427c219c4fa29489ac0fdb76/chrome/browser/resource_coordinator/local_site_characteristics_webcontents_observer_unittest.cc
[modify] https://crrev.com/0cfc46e773dd4d82427c219c4fa29489ac0fdb76/chrome/browser/resource_coordinator/tab_manager_features.cc
[modify] https://crrev.com/0cfc46e773dd4d82427c219c4fa29489ac0fdb76/chrome/browser/resource_coordinator/tab_manager_features.h
[modify] https://crrev.com/0cfc46e773dd4d82427c219c4fa29489ac0fdb76/chrome/browser/resource_coordinator/tab_manager_features_unittest.cc
Project Member

Comment 51 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2574bbe7aae1c9fde4043276bf94f5229a5add02

commit 2574bbe7aae1c9fde4043276bf94f5229a5add02
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Jul 27 04:00:26 2018

RC: Upgrade the DB version to 1

This CL adds a version number to the Local Site Characteristics DB and
reset its content if it already exists.

Bug:  773382 , 866540,  867027 
Change-Id: I0a68ad044456ab67c39a3f1537e9ff9534920d47
Reviewed-on: https://chromium-review.googlesource.com/1147113
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577912}(cherry picked from commit ab7fe5e267892cfd55d84f1e5f43e5d3f4742eb7)
Reviewed-on: https://chromium-review.googlesource.com/1152667
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#139}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/2574bbe7aae1c9fde4043276bf94f5229a5add02/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.cc
[modify] https://crrev.com/2574bbe7aae1c9fde4043276bf94f5229a5add02/chrome/browser/resource_coordinator/leveldb_site_characteristics_database.h
[modify] https://crrev.com/2574bbe7aae1c9fde4043276bf94f5229a5add02/chrome/browser/resource_coordinator/leveldb_site_characteristics_database_unittest.cc

Comment 52 by benhenry@google.com, Jan 11

Labels: Pri-2
Setting defect without priority to Pri-2.

Comment 53 by sebmarchand@chromium.org, Jan 16 (6 days ago)

Status: Verified (was: Assigned)
►

Sign in to add a comment