New issue
Advanced search Search tips

Issue 773368 link

Starred by 1 user
Status: Fixed
Owner:
pdr@chromium.org
Closed: Oct 2017
Cc:
szager@chromium.org
bokan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 417782



Sign in to add a comment

[root layer scrolls] iframe with scrolling="no" doesn't clip

Project Member Reported by skobes@chromium.org, Oct 10 2017 
Repro:

$ content_shell --root-layer-scrolls https://output.jsbin.com/jadobuv/quiet

Blue div is not clipped by the iframe.

(This affects at least virtual/prefer_compositing_to_lcd_text/scrollbars/hidden-scrollbars-invisible.html, probably others.)

@pdr can you take a look?
Screenshot from 2017-10-10 11:38:49.png
13.5 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c1f345d3db983cbc3bd0c6b2615a7a5dfd84876

commit 8c1f345d3db983cbc3bd0c6b2615a7a5dfd84876
Author: Philip Rogers <pdr@chromium.org>
Date: Thu Oct 12 01:43:31 2017

[root layer scrolls] FramePainter should clip

FramePainter clips overflowing content without Root Layer
Scrolls (RLS) and should clip with RLS as well. This fixes
33 layout tests with RLS.

Tests such as [1] are mostly fixed by this patch but still
fail due to a positioning bug ( https://crbug.com/746777 ).

[1] virtual/prefer_compositing_to_lcd_text/scrollbars/hidden-scrollbars-invisible.html

Bug:  773368 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic5ec181faaa6e43ea0c3bf2dadb0a81aabc59ee5
Reviewed-on: https://chromium-review.googlesource.com/711378
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508214}
[modify] https://crrev.com/8c1f345d3db983cbc3bd0c6b2615a7a5dfd84876/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/8c1f345d3db983cbc3bd0c6b2615a7a5dfd84876/third_party/WebKit/Source/core/paint/FramePainter.cpp

Comment 2 by pdr@chromium.org, Oct 12 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment