cannot open network settings page |
|||||||
Issue descriptionThis happens with cash, mash and mus. repro steps: open shelf -> go to network -> click on the gear button to go to network settings stacktrace: [118951:118951:1010/143304.310578:FATAL:network_state_handler.cc(564)] Check failed: !guid.empty(). #0 0x7f46499c4cac base::debug::StackTrace::StackTrace() #1 0x7f46499eb61c logging::LogMessage::~LogMessage() #2 0x7f46452b8971 chromeos::NetworkStateHandler::GetNetworkStateFromGuid() #3 0x009ca48322a8 <unknown> #4 0x7f464415bc7a ash::mojom::SystemTrayClientStubDispatch::Accept() #5 0x7f4648c7333b mojo::InterfaceEndpointClient::HandleValidatedMessage() #6 0x7f4648c72c66 mojo::FilterChain::Accept() #7 0x7f4648c746a5 mojo::InterfaceEndpointClient::HandleIncomingMessage() #8 0x7f4648c7e994 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #9 0x7f4648c7dee4 mojo::internal::MultiplexRouter::Accept() #10 0x7f4648c72c66 mojo::FilterChain::Accept() #11 0x7f4648c6dce5 mojo::Connector::ReadSingleMessage() #12 0x7f4648c6e7d1 mojo::Connector::ReadAllAvailableMessages() #13 0x7f4648c6e679 mojo::Connector::OnHandleReadyInternal() #14 0x7f4648c6ee76 mojo::SimpleWatcher::DiscardReadyState() #15 0x7f4648c37787 mojo::SimpleWatcher::OnHandleReady() #16 0x7f4648c37ca1 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE #17 0x7f46499c5585 base::debug::TaskAnnotator::RunTask() #18 0x7f46499f6b59 base::internal::IncomingTaskQueue::RunTask() #19 0x7f46499f9078 base::MessageLoop::RunTask() #20 0x7f46499f97ee base::MessageLoop::DoWork() #21 0x7f46499fc1e9 base::MessagePumpLibevent::Run() #22 0x7f46499f8ae2 base::MessageLoop::Run() #23 0x7f4649a2d52f base::RunLoop::Run() #24 0x009ca34c71fa <unknown> #25 0x7f4646e48557 content::BrowserMainLoop::RunMainMessageLoopParts() #26 0x7f4646e4afc6 content::BrowserMainRunnerImpl::Run() #27 0x7f4646e43daf content::BrowserMain() #28 0x7f464772a94c content::ContentMainRunnerImpl::Run() #29 0x7f4649f126be service_manager::Main() #30 0x7f4647729334 content::ContentMain() #31 0x009ca2a92bbb <unknown> #32 0x7f463d86bf45 __libc_start_main #33 0x009ca2a929e2 <unknown> Received signal 6 #0 0x7f46499c4cac base::debug::StackTrace::StackTrace() #1 0x7f46499c4791 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f4649b47330 <unknown> #3 0x7f463d880c37 gsignal #4 0x7f463d884028 abort #5 0x7f46499c26a5 base::debug::BreakDebugger() #6 0x7f46499eb9d0 logging::LogMessage::~LogMessage() #7 0x7f46452b8971 chromeos::NetworkStateHandler::GetNetworkStateFromGuid() #8 0x009ca48322a8 <unknown> #9 0x7f464415bc7a ash::mojom::SystemTrayClientStubDispatch::Accept() #10 0x7f4648c7333b mojo::InterfaceEndpointClient::HandleValidatedMessage() #11 0x7f4648c72c66 mojo::FilterChain::Accept() #12 0x7f4648c746a5 mojo::InterfaceEndpointClient::HandleIncomingMessage() #13 0x7f4648c7e994 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #14 0x7f4648c7dee4 mojo::internal::MultiplexRouter::Accept() #15 0x7f4648c72c66 mojo::FilterChain::Accept() #16 0x7f4648c6dce5 mojo::Connector::ReadSingleMessage() #17 0x7f4648c6e7d1 mojo::Connector::ReadAllAvailableMessages() #18 0x7f4648c6e679 mojo::Connector::OnHandleReadyInternal() #19 0x7f4648c6ee76 mojo::SimpleWatcher::DiscardReadyState() #20 0x7f4648c37787 mojo::SimpleWatcher::OnHandleReady() #21 0x7f4648c37ca1 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE #22 0x7f46499c5585 base::debug::TaskAnnotator::RunTask() #23 0x7f46499f6b59 base::internal::IncomingTaskQueue::RunTask() #24 0x7f46499f9078 base::MessageLoop::RunTask() #25 0x7f46499f97ee base::MessageLoop::DoWork() #26 0x7f46499fc1e9 base::MessagePumpLibevent::Run() #27 0x7f46499f8ae2 base::MessageLoop::Run() #28 0x7f4649a2d52f base::RunLoop::Run() #29 0x009ca34c71fa <unknown> #30 0x7f4646e48557 content::BrowserMainLoop::RunMainMessageLoopParts() #31 0x7f4646e4afc6 content::BrowserMainRunnerImpl::Run() #32 0x7f4646e43daf content::BrowserMain() #33 0x7f464772a94c content::ContentMainRunnerImpl::Run() #34 0x7f4649f126be service_manager::Main() #35 0x7f4647729334 content::ContentMain() #36 0x009ca2a92bbb <unknown> #37 0x7f463d86bf45 __libc_start_main #38 0x009ca2a929e2 <unknown> r8: ffffb1aa478e3cd0 r9: ffffb1aa478e3cc0 r10: 0000000000000008 r11: 0000000000000202 r12: 00007fffb9a17c00 r13: 00007fffb9a17bf0 r14: 00007fffb9a17bf8 r15: 00007fffb9a17750 di: 000000000001d0a7 si: 000000000001d0a7 bp: 00007fffb9a17740 bx: 00007fffb9a17750 dx: 0000000000000006 ax: 0000000000000000 cx: 00007f463d880c37 sp: 00007fffb9a17608 ip: 00007f463d880c37 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. Is this a known issue?
,
Oct 10 2017
Related to issue 762308 . I'll look into this.
,
Oct 11 2017
Reproducible crash in classic ash seems bad, bumping priority. Is this on-device only or on desktop?
,
Oct 11 2017
Oh, "cash" == "classic ash"? It's a DCHECK so it shouldn't be happening in production, but it shouldn't be happening at all. I'll take a look next.
,
Oct 11 2017
The bug was introduced here: https://chromium-review.googlesource.com/c/chromium/src/+/592545 It's an easy enough mistake; I should have caught it in the code review. Should be a quick fix.
,
Oct 11 2017
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ce711f3c66a4f10f5fa4985661fa061ca49fa88 commit 6ce711f3c66a4f10f5fa4985661fa061ca49fa88 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Oct 11 18:51:24 2017 System Tray: Network: Fix DCHECKs This actually fixes two separate dchecks introduced by recent changes: 1. Clicking the network settings menu in login now shows the details page for the default network, so |network_id| can be empty. 2. Clicking the network settings menu now special cases for Arc VPNs; that test needs to avoid calling NSH::GetNetworkStateFromGuid if |network_id| is empty since it calls DCHECK(guid). Bug: 773366 Change-Id: Iaeb1dbd4479dcefd5ba85eccbe5219a4efebb0e8 Reviewed-on: https://chromium-review.googlesource.com/711318 Reviewed-by: Kevin Cernekee <cernekee@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#508050} [modify] https://crrev.com/6ce711f3c66a4f10f5fa4985661fa061ca49fa88/chrome/browser/ui/ash/system_tray_client.cc
,
Oct 12 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sadrul@chromium.org
, Oct 10 2017