Tracking bug for uberblame tool |
|||
Issue description
,
Oct 10 2017
Initial prototype CL already landed: https://chromium.googlesource.com/chromium/src/+/c3ed89607d994fdf9aa1fbc44230292d168ba39b
,
Oct 10 2017
X-reffing images for CL: https://chromium-review.googlesource.com/c/chromium/src/+/658837
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a671dad1b881ac079f4397cef09c5a41613bc746 commit a671dad1b881ac079f4397cef09c5a41613bc746 Author: Tom Anderson <thomasanderson@chromium.org> Date: Tue Oct 10 19:19:47 2017 Uberblame: Use outline instead of box shadow in the blame view Before, there were too many borders separating the same commit. This CL uses CSS outlines instead of box shadows in order to wrap the border around the perimeter of the text. See [1] for an explanation of what's changed. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=773350#c3 R=dpranke@chromium.org BUG= 773350 Change-Id: I54c186020647a9a773a4f0b6d80d5c71a94d126b Reviewed-on: https://chromium-review.googlesource.com/709994 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#507738} [modify] https://crrev.com/a671dad1b881ac079f4397cef09c5a41613bc746/tools/uberblame.py
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e716926101f95afa316c50aa1aea4508082e725 commit 1e716926101f95afa316c50aa1aea4508082e725 Author: Tom Anderson <thomasanderson@chromium.org> Date: Thu Oct 12 19:43:49 2017 Uberblame: separate git log data with null bytes instead of newlines This is in preparation for parsing the commit message (which may contain lone newlines) in the git log. BUG= 773350 R=dpranke@chromium.org Change-Id: Ia3cd60bc48601034c753c0e6bc6de6b176f8006b Reviewed-on: https://chromium-review.googlesource.com/710747 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#508383} [modify] https://crrev.com/1e716926101f95afa316c50aa1aea4508082e725/tools/uberblame.py
,
Oct 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65410155e36a7f1e9ac83e50406c623b6071ac65 commit 65410155e36a7f1e9ac83e50406c623b6071ac65 Author: Tom Anderson <thomasanderson@chromium.org> Date: Tue Oct 17 01:53:19 2017 Uberblame: Display commit metadata in the visualization BUG= 773350 R=dpranke@chromium.org Change-Id: Ic95199a275e33808b3e3f895f884561955bc6746 Reviewed-on: https://chromium-review.googlesource.com/720198 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#509210} [modify] https://crrev.com/65410155e36a7f1e9ac83e50406c623b6071ac65/tools/uberblame.py
,
Nov 1 2017
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3d7e647ddf26cc5da4b3d12169daf0175587f67 commit b3d7e647ddf26cc5da4b3d12169daf0175587f67 Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Apr 13 16:23:42 2018 Add more options to uberblame * Adds --tokenize-by-character * This is useful for eg. the blink refactor where fooBar got changed to foo_bar. * Adds --tokenize-whitespace * Adds --skip-visualization * Added this because it was useful for testing. * Ran yapf * Small refactor. BUG= 773350 R=dpranke Change-Id: I7596f670ce640ed6bd367dee995628edc13dd6f2 Reviewed-on: https://chromium-review.googlesource.com/1010798 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#550634} [modify] https://crrev.com/b3d7e647ddf26cc5da4b3d12169daf0175587f67/tools/uberblame.py
,
Apr 16 2018
X-reffing image for cl https://chromium-review.googlesource.com/c/chromium/src/+/1014621
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/500216114cd6eaf00edf5fbb4bb2aba197d77ea1 commit 500216114cd6eaf00edf5fbb4bb2aba197d77ea1 Author: Tom Anderson <thomasanderson@chromium.org> Date: Tue Apr 17 00:30:21 2018 Uberblame: Include context lines in diff This is in preparation for displaying the diff in the Uberblame visualization. About 3 lines of context is nice when viewing diffs. Some extra logic is now necessary to handle the context. BUG= 773350 TBR=dpranke Change-Id: If202deb3d9fd85ee6f9376739205a15f542b8005 Reviewed-on: https://chromium-review.googlesource.com/1014349 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#551184} [modify] https://crrev.com/500216114cd6eaf00edf5fbb4bb2aba197d77ea1/tools/uberblame.py
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac918bb6a8bc68b391b3707155e258d0402a6c4d commit ac918bb6a8bc68b391b3707155e258d0402a6c4d Author: Tom Anderson <thomasanderson@chromium.org> Date: Tue Apr 17 00:37:34 2018 Display diff in uberblame visualization Uberblame now looks like this: https://bugs.chromium.org/p/chromium/issues/detail?id=773350#c9 BUG= 773350 R=dpranke Change-Id: I43b75fbedac5a9350a5c227882743b8a9bd33282 Reviewed-on: https://chromium-review.googlesource.com/1014621 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#551188} [modify] https://crrev.com/ac918bb6a8bc68b391b3707155e258d0402a6c4d/tools/uberblame.py
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3d7e647ddf26cc5da4b3d12169daf0175587f67 commit b3d7e647ddf26cc5da4b3d12169daf0175587f67 Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Apr 13 16:23:42 2018 Add more options to uberblame * Adds --tokenize-by-character * This is useful for eg. the blink refactor where fooBar got changed to foo_bar. * Adds --tokenize-whitespace * Adds --skip-visualization * Added this because it was useful for testing. * Ran yapf * Small refactor. BUG= 773350 R=dpranke Change-Id: I7596f670ce640ed6bd367dee995628edc13dd6f2 Reviewed-on: https://chromium-review.googlesource.com/1010798 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#550634} [modify] https://crrev.com/b3d7e647ddf26cc5da4b3d12169daf0175587f67/tools/uberblame.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by thomasanderson@chromium.org
, Oct 10 2017Labels: -Type-Bug Type-Feature
Owner: thomasanderson@chromium.org
Status: Started (was: Untriaged)