New issue
Advanced search Search tips

Issue 773297 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 793687



Sign in to add a comment

Migrate V8 waterfall builders to scheduler module for triggering builds

Project Member Reported by serg...@chromium.org, Oct 10 2017

Issue description

This is currently blocked on discussion how changes should be computed in the LUCI world: http://g/chrome-recipes/xbH2hl3cGeI.
 
Owner: serg...@chromium.org
Status: Assigned (was: Available)
Blocking: -747960
Blocking: 793687
Status: Started (was: Assigned)
Summary: Migrate V8 waterfall builders to scheduler module for triggering builds (was: Migrate V8 waterfall builders to buildbucket module for triggering builds)
We will likely use scheduler module [1] to trigger builds because buildbucket is not able to merge build requests together. Example how Chromium CI was converted from buildbucket to scheduler: https://crrev.com/c/898505.

[1]: https://chromium.googlesource.com/infra/luci/recipes-py/+/master/recipe_modules/scheduler/api.py
P.S. For those few builders that do not want to merge builds, we'll use buildbucket.
Labels: -Pri-3 Pri-2
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/cb60b0daf730f2585dcff80e2f93c2b87e2fd456

commit cb60b0daf730f2585dcff80e2f93c2b87e2fd456
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Mon Apr 02 18:42:06 2018

[tools] Whitespace CL

TBR=sergiyb@chromium.org

Bug:  chromium:773297 
Change-Id: I51a9cff42adb477bc089a869741e34513426e5b6
Reviewed-on: https://chromium-review.googlesource.com/989715
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52312}
[modify] https://crrev.com/cb60b0daf730f2585dcff80e2f93c2b87e2fd456/tools/whitespace.txt

Update: this has been implemented, but permissions need to be fixed: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20-%20builder/420.
Cc: tandrii@chromium.org
Android, would you happen to know which permission do I need to add and where to fix the above failure?
s/Android/Andrii/
Have you granted TRIGGERER permission to task service account of your CI bots?
See chromium's config for inspiration: https://cs.chromium.org/chromium/src/infra/config/global/luci-scheduler.cfg?q=luci-scheduler.cfg&sq=package:chromium&dr&l=28
Nice. Thanks. Done the same for V8.
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/80d587d7ea395004f068610282da2aecc360c60b

commit 80d587d7ea395004f068610282da2aecc360c60b
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Tue Apr 03 14:24:26 2018

[tools] Whitespace CL

TBR=sergiyb@chromium.org

Bug:  chromium:773297 
Change-Id: Icbff53ed84b72d74f1db9884b3b846b8ff72686b
No-Try: true
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/992317
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52326}
[modify] https://crrev.com/80d587d7ea395004f068610282da2aecc360c60b/tools/whitespace.txt

Status: Fixed (was: Started)
This has been completed, although we'll still need to migrate all scheduler configs from masters to luci-scheduler.cfg, but this will be done on a per-builder basis as part of the issue 793687. Note that only LUCI builds are using luci-scheduler since it does not copy the list of changes like api.trigger does and Buildbot UI is not able to display list of changes based on buildset revision.

Sign in to add a comment