New issue
Advanced search Search tips

Issue 773296 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

GetExtensionOrAppByURL should understand blob/filesystem URLs

Project Member Reported by lukasza@chromium.org, Oct 10 2017

Issue description

This bug is a follow-up for https://chromium-review.googlesource.com/c/chromium/src/+/683312/7/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc#386 where we noticed that one shouldn't pass a raw URL to GetExtensionOrAppByURL - instead (to extract blob/filesystem origin) url::Origin(url).GetURL() should be passed instead.

Let's use this bug to 
1. Figure out where this problem might appear (GetExtensionOrAppByURL, GetExtensionOrAppIDByURL, ExtensionNavigationThrottle::WillStartOrRedirectRequest?)

2. Figure out if we can minimize the problem by moving url::Origin(url).GetURL() workaround into most shared/common code (e.g. into GetExtensionOrAppByURL and GetExtensionOrAppIDByURL?)
 

Sign in to add a comment