New issue
Advanced search Search tips

Migrate net::URLFetcher callsites over SimpleURLLoader

Project Member Reported by kinuko@chromium.org, Oct 10 2017

Issue description

Showing comments 55 - 154 of 154 Older
Blockedon: 840410
Blockedon: 840408
Blockedon: 840405
Blockedon: 840404
Blockedon: 840400
Blockedon: 840396
Blockedon: 840390
Blockedon: 839021
Blockedon: 839011
Blockedon: 838955
Blockedon: 839037
Blockedon: 840393
Project Member

Comment 67 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db972aaec73d8912a706c377d018a887a0547caf

commit db972aaec73d8912a706c377d018a887a0547caf
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Wed May 09 18:26:03 2018

Migrate CommonNameMismatchHandler to SimpleURLLoader

Bug: 773295
Change-Id: I51e9af84ff43b34044851f409a7bc4b1877a0ab6
Reviewed-on: https://chromium-review.googlesource.com/1052071
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557251}
[modify] https://crrev.com/db972aaec73d8912a706c377d018a887a0547caf/chrome/browser/ssl/common_name_mismatch_handler.cc
[modify] https://crrev.com/db972aaec73d8912a706c377d018a887a0547caf/chrome/browser/ssl/common_name_mismatch_handler.h
[modify] https://crrev.com/db972aaec73d8912a706c377d018a887a0547caf/chrome/browser/ssl/ssl_error_handler.cc

Project Member

Comment 68 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d8f49e506d0845cb7c78e883b3b5056b2efa71f

commit 9d8f49e506d0845cb7c78e883b3b5056b2efa71f
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu May 10 05:33:57 2018

Migrate GoogleURLTracker to SimpleURLLoader

Apart from the actual migration, CL also adapts the existing unittests
(namely GoogleURLTrackerTest, from components_unittests target) to work
with the SimpleURLLoader machinery.

Some remarks on the unittests' migration:

- GetFetcher calls in the unittests were replaced by handled_request.
- MockSearchDomainCheckResponse: rather than calling the URLFetcherDelegate
  method, it queue a server response to be served upon request.
- We call MockSearchDomainCheckResponse before instantiating any request.
- RequestServerCheck and FinishSleep both can trigger SimpleURLLoader download.
  Hence both methods add a loop in order to make sure a request is
  handled by the server (or failed).

Additionally, CL removes the dependency of URLRequestContextGetter from
GoogleURLTrackerClient. Derived classes are also updated accordingly.

Last, some unittests, namely browser_tests' ErrorPageAutoReloadTest,
stared to track additional "google url tracker" loads from its Interceptor.
Tests are updated to skip counting such loads.

BUG=773295

TBR=treib@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I416c6254876ce6a54ee239ff63cd35fc300d5053
Reviewed-on: https://chromium-review.googlesource.com/1042825
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557459}
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/chrome/browser/google/chrome_google_url_tracker_client.cc
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/chrome/browser/google/chrome_google_url_tracker_client.h
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/chrome/browser/search/one_google_bar/one_google_bar_fetcher_impl_unittest.cc
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/components/google/core/browser/BUILD.gn
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/components/google/core/browser/DEPS
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/components/google/core/browser/google_url_tracker.cc
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/components/google/core/browser/google_url_tracker.h
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/components/google/core/browser/google_url_tracker_client.h
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/components/google/core/browser/google_url_tracker_unittest.cc
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/components/ntp_tiles/popular_sites_impl.cc
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/components/omnibox/browser/autocomplete_provider_unittest.cc
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/components/omnibox/browser/keyword_provider_unittest.cc
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/ios/chrome/browser/google/google_url_tracker_client_impl.cc
[modify] https://crrev.com/9d8f49e506d0845cb7c78e883b3b5056b2efa71f/ios/chrome/browser/google/google_url_tracker_client_impl.h

Project Member

Comment 69 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e73188c141ef0a2d882cdcd1b914d1bf4668e2c1

commit e73188c141ef0a2d882cdcd1b914d1bf4668e2c1
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu May 10 22:54:35 2018

Switch from 'fetch' to 'load' terminology in GoogleURLTracker

Driven by follow up of https://crrev.com/c/1042825.

BUG=773295

Change-Id: I8778d225f411c84f431867b2845301f3da770d6d
Reviewed-on: https://chromium-review.googlesource.com/1050705
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557714}
[modify] https://crrev.com/e73188c141ef0a2d882cdcd1b914d1bf4668e2c1/components/google/core/browser/google_url_tracker.cc
[modify] https://crrev.com/e73188c141ef0a2d882cdcd1b914d1bf4668e2c1/components/google/core/browser/google_url_tracker.h
[modify] https://crrev.com/e73188c141ef0a2d882cdcd1b914d1bf4668e2c1/components/google/core/browser/google_url_tracker_unittest.cc

Project Member

Comment 70 by bugdroid1@chromium.org, May 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfd0d8991d2ad890bea0497e0ed2c65b92f5d3fe

commit cfd0d8991d2ad890bea0497e0ed2c65b92f5d3fe
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Sat May 12 12:58:25 2018

Migrate InstallSigner to SimpleURLLoader

Manual test: <out>/chrome --extensions-install-verification="enforce_strict"
TEST=covered by existing tests.

BUG=773295

Change-Id: I116d5c826935c6b5c6c9d062cf55422b7b1915f6
Reviewed-on: https://chromium-review.googlesource.com/1052867
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558130}
[modify] https://crrev.com/cfd0d8991d2ad890bea0497e0ed2c65b92f5d3fe/chrome/browser/extensions/install_signer.cc
[modify] https://crrev.com/cfd0d8991d2ad890bea0497e0ed2c65b92f5d3fe/chrome/browser/extensions/install_signer.h
[modify] https://crrev.com/cfd0d8991d2ad890bea0497e0ed2c65b92f5d3fe/chrome/browser/extensions/install_verifier.cc

Project Member

Comment 71 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1431d65925e878d718a9237efa59308f71f2ebab

commit 1431d65925e878d718a9237efa59308f71f2ebab
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon May 14 11:05:33 2018

Migrate ExtensionWebRequestApiTest::WebRequestURLFetcherInterception to SimpleURLLoader

CL replaces the uses of URLFetcher and URLFetcherDelegate by SimpleURLLoader in
ExtensionWebRequestApiTest::WebRequestURLFetcherInterception. Test is also renamed
to WebRequestURLLoaderInterception

Note that, it moves some local const char[] declarations up in the current method
body (WebRequestURLFetcherInterception), so that they can be used within the
Lambda functor.

BUG=773295

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I552ee85f72be373a08aa7f36afe3ee83996cef6e
Reviewed-on: https://chromium-review.googlesource.com/1053889
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#558256}
[modify] https://crrev.com/1431d65925e878d718a9237efa59308f71f2ebab/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/1431d65925e878d718a9237efa59308f71f2ebab/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 72 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b67362ed51d2549ac2d8f89074cdd8d08e37bc39

commit b67362ed51d2549ac2d8f89074cdd8d08e37bc39
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Tue May 15 15:59:47 2018

Migrate SafeSearchURLChecker to SimpleURLLoader

Bug: 773295
Change-Id: I6be6adefab29b5d4e67013f45ba5ffe4e058dbdc
Reviewed-on: https://chromium-review.googlesource.com/1030062
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558725}
[modify] https://crrev.com/b67362ed51d2549ac2d8f89074cdd8d08e37bc39/chrome/browser/safe_search_api/safe_search_url_checker.cc
[modify] https://crrev.com/b67362ed51d2549ac2d8f89074cdd8d08e37bc39/chrome/browser/safe_search_api/safe_search_url_checker.h
[modify] https://crrev.com/b67362ed51d2549ac2d8f89074cdd8d08e37bc39/chrome/browser/safe_search_api/safe_search_url_checker_unittest.cc
[modify] https://crrev.com/b67362ed51d2549ac2d8f89074cdd8d08e37bc39/chrome/browser/supervised_user/supervised_user_service.cc
[modify] https://crrev.com/b67362ed51d2549ac2d8f89074cdd8d08e37bc39/chrome/browser/supervised_user/supervised_user_url_filter.cc
[modify] https://crrev.com/b67362ed51d2549ac2d8f89074cdd8d08e37bc39/chrome/browser/supervised_user/supervised_user_url_filter.h
[modify] https://crrev.com/b67362ed51d2549ac2d8f89074cdd8d08e37bc39/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc

Blockedon: 843205
Blockedon: 826780
Blockedon: 844932
Project Member

Comment 78 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac1131c1b7e869cadf32dcc68618b50076efb1ee

commit ac1131c1b7e869cadf32dcc68618b50076efb1ee
Author: Ramya Nagarajan <ramyan@chromium.org>
Date: Tue May 22 17:31:07 2018

[Cleanup] Switch from 'fetcher' to 'loader' naming in one_google_bar_*_unittest

This is a follow up of https://crrev.com/c/1043285, which completed the rest of
the migration from 'fetcher' to 'loader' terminology in
c/b/search/one_google_bar.

Bug: 773295
Change-Id: I77b875ffc64f7ce16ea4dfb265bbd73cd92cea0c
Reviewed-on: https://chromium-review.googlesource.com/1068023
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560678}
[rename] https://crrev.com/ac1131c1b7e869cadf32dcc68618b50076efb1ee/chrome/browser/search/one_google_bar/one_google_bar_loader_impl_unittest.cc
[modify] https://crrev.com/ac1131c1b7e869cadf32dcc68618b50076efb1ee/chrome/test/BUILD.gn

Project Member

Comment 79 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edc1d1563c643d231f501dfa53a368d89b1dfcbc

commit edc1d1563c643d231f501dfa53a368d89b1dfcbc
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Tue May 22 17:38:23 2018

Migrate Rappor::LogUploader to SimpleURLLoader

Bug: 773295
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I556353286e4ec97544aa9e51d77e102bf78d59ae
Reviewed-on: https://chromium-review.googlesource.com/1054478
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560684}
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/chrome/browser/metrics/chrome_metrics_services_manager_client.h
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/components/metrics_services_manager/BUILD.gn
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/components/metrics_services_manager/DEPS
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/components/metrics_services_manager/metrics_services_manager.cc
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/components/metrics_services_manager/metrics_services_manager_client.h
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/components/rappor/BUILD.gn
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/components/rappor/DEPS
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/components/rappor/log_uploader.cc
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/components/rappor/log_uploader.h
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/components/rappor/log_uploader_unittest.cc
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/components/rappor/rappor_service_impl.cc
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/components/rappor/rappor_service_impl.h
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/ios/chrome/DEPS
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/ios/chrome/browser/application_context.h
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/ios/chrome/browser/application_context_impl.cc
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/ios/chrome/browser/application_context_impl.h
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/ios/chrome/test/testing_application_context.h
[modify] https://crrev.com/edc1d1563c643d231f501dfa53a368d89b1dfcbc/ios/chrome/test/testing_application_context.mm

Comment 80 by dxie@chromium.org, May 22 2018

Labels: Hotlist-KnownIssue
Blockedon: 844930
Blockedon: 844937
Blockedon: 844926
Project Member

Comment 84 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27f8891c7cd9a86b2c92508cf6818726df4058d6

commit 27f8891c7cd9a86b2c92508cf6818726df4058d6
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu May 24 13:17:58 2018

Migrate ContentHashFetcher to SimpleURLLoader

This CL migrates ContentHashFetcher away from URLRequestFetcher to
SimpleURLLoader.

In order to accomplish this, a few other related changes are also performed:

1) The regular flow of the code is ContentVerifier -> ContentHash ->
   ContentHashFetcher. In ContentVerifier, for instance, UI, IO and
   "File tasks" threads take place.
   Previously, the URLRequestFetcher logic residing in ContentHashFetcher
   executed in the "file tasks" thread.

   As part of the migration from URLRequestFetcher to SimpleURLLoader
   machinery, this CL also changes the ContentHashFetcher logic to
   execute to the IO thread.
   Note that it could be possible to keep the new SimpleURLLoader logic
   in the "file tasks" thread. However, this would impose a way bigger change,
   and require unittests to be considerably rewritten as well (see for
   patchsets 7, 8 and 9.
   The issue is that mojo objects are not thread safe. We could create a new
   URLLoaderFactory for the extensions thread, but then we'd need to create a
   new one when the network service crashes (Something this SharedURLLoaderFactory
   one, already bound to the IOThread, magically handles), but that would be
   significantly more complicated.

2) content_verifier_hash_fetch_behavior_browsertest.cc was changed
   to support running with the network service feature both enabled
   and disabled. This is a pattern that is also present in various other
   unittests.

In summary, the migration to use SimpleURLLoader performed here includes
also a change in the thread that ContentHashFetcher runs on, but no
functionality change is expected from this CL.

BUG=773295, 844926 

Change-Id: If570f69d01ff75ac59d8d043f8687621336dddcf
Reviewed-on: https://chromium-review.googlesource.com/1056587
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561480}
[modify] https://crrev.com/27f8891c7cd9a86b2c92508cf6818726df4058d6/chrome/browser/extensions/content_verifier_hash_fetch_behavior_browsertest.cc
[modify] https://crrev.com/27f8891c7cd9a86b2c92508cf6818726df4058d6/extensions/browser/BUILD.gn
[modify] https://crrev.com/27f8891c7cd9a86b2c92508cf6818726df4058d6/extensions/browser/DEPS
[modify] https://crrev.com/27f8891c7cd9a86b2c92508cf6818726df4058d6/extensions/browser/content_hash_fetcher.cc
[modify] https://crrev.com/27f8891c7cd9a86b2c92508cf6818726df4058d6/extensions/browser/content_hash_fetcher.h
[modify] https://crrev.com/27f8891c7cd9a86b2c92508cf6818726df4058d6/extensions/browser/content_hash_fetcher_unittest.cc
[modify] https://crrev.com/27f8891c7cd9a86b2c92508cf6818726df4058d6/extensions/browser/content_verifier.cc
[modify] https://crrev.com/27f8891c7cd9a86b2c92508cf6818726df4058d6/extensions/browser/content_verifier.h
[modify] https://crrev.com/27f8891c7cd9a86b2c92508cf6818726df4058d6/extensions/browser/content_verifier/content_hash.cc
[modify] https://crrev.com/27f8891c7cd9a86b2c92508cf6818726df4058d6/extensions/browser/content_verifier/content_hash.h

Project Member

Comment 85 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/082ca997aba8426949fb918d8f38f552100d96b0

commit 082ca997aba8426949fb918d8f38f552100d96b0
Author: Gabriel Charette <gab@chromium.org>
Date: Thu May 24 18:47:07 2018

Revert "Migrate ContentHashFetcher to SimpleURLLoader"

This reverts commit 27f8891c7cd9a86b2c92508cf6818726df4058d6.

Reason for revert: suspect for  crbug.com/846417 

Original change's description:
> Migrate ContentHashFetcher to SimpleURLLoader
> 
> This CL migrates ContentHashFetcher away from URLRequestFetcher to
> SimpleURLLoader.
> 
> In order to accomplish this, a few other related changes are also performed:
> 
> 1) The regular flow of the code is ContentVerifier -> ContentHash ->
>    ContentHashFetcher. In ContentVerifier, for instance, UI, IO and
>    "File tasks" threads take place.
>    Previously, the URLRequestFetcher logic residing in ContentHashFetcher
>    executed in the "file tasks" thread.
> 
>    As part of the migration from URLRequestFetcher to SimpleURLLoader
>    machinery, this CL also changes the ContentHashFetcher logic to
>    execute to the IO thread.
>    Note that it could be possible to keep the new SimpleURLLoader logic
>    in the "file tasks" thread. However, this would impose a way bigger change,
>    and require unittests to be considerably rewritten as well (see for
>    patchsets 7, 8 and 9.
>    The issue is that mojo objects are not thread safe. We could create a new
>    URLLoaderFactory for the extensions thread, but then we'd need to create a
>    new one when the network service crashes (Something this SharedURLLoaderFactory
>    one, already bound to the IOThread, magically handles), but that would be
>    significantly more complicated.
> 
> 2) content_verifier_hash_fetch_behavior_browsertest.cc was changed
>    to support running with the network service feature both enabled
>    and disabled. This is a pattern that is also present in various other
>    unittests.
> 
> In summary, the migration to use SimpleURLLoader performed here includes
> also a change in the thread that ContentHashFetcher runs on, but no
> functionality change is expected from this CL.
> 
> BUG=773295, 844926 
> 
> Change-Id: If570f69d01ff75ac59d8d043f8687621336dddcf
> Reviewed-on: https://chromium-review.googlesource.com/1056587
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561480}

TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org,mmenke@chromium.org,tonikitoo@igalia.com

Change-Id: I31235cf26cfff34aac0ff1e4047575ed2881722b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773295,  844926 ,  846417 
Reviewed-on: https://chromium-review.googlesource.com/1072110
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561572}
[modify] https://crrev.com/082ca997aba8426949fb918d8f38f552100d96b0/chrome/browser/extensions/content_verifier_hash_fetch_behavior_browsertest.cc
[modify] https://crrev.com/082ca997aba8426949fb918d8f38f552100d96b0/extensions/browser/BUILD.gn
[modify] https://crrev.com/082ca997aba8426949fb918d8f38f552100d96b0/extensions/browser/DEPS
[modify] https://crrev.com/082ca997aba8426949fb918d8f38f552100d96b0/extensions/browser/content_hash_fetcher.cc
[modify] https://crrev.com/082ca997aba8426949fb918d8f38f552100d96b0/extensions/browser/content_hash_fetcher.h
[modify] https://crrev.com/082ca997aba8426949fb918d8f38f552100d96b0/extensions/browser/content_hash_fetcher_unittest.cc
[modify] https://crrev.com/082ca997aba8426949fb918d8f38f552100d96b0/extensions/browser/content_verifier.cc
[modify] https://crrev.com/082ca997aba8426949fb918d8f38f552100d96b0/extensions/browser/content_verifier.h
[modify] https://crrev.com/082ca997aba8426949fb918d8f38f552100d96b0/extensions/browser/content_verifier/content_hash.cc
[modify] https://crrev.com/082ca997aba8426949fb918d8f38f552100d96b0/extensions/browser/content_verifier/content_hash.h

Blockedon: 844934
Blockedon: 844920
Blockedon: 844943
Blockedon: 844971
Blockedon: 844975
Blockedon: 844940
Blockedon: 844942
Blockedon: 844966
Project Member

Comment 94 by bugdroid1@chromium.org, Jun 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61a972c30fcab43b3ea65e510b8fe8dde26e6274

commit 61a972c30fcab43b3ea65e510b8fe8dde26e6274
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Jun 13 21:45:49 2018

Migrate TranslateURLFetcher to SimpleURLLoader

URLFetcher et al will stop working in the browser process with advent
of Network Service, and SimpleURLLoader is the replacement API
for most clients. CL migrates TranslateURLFetcher to the new API.

Additionally, various unittests were also updated to use the new
TestURLLoaderFactory and EmbeddedTestServer machinery.

As a bonus, the CL allows us to get of URLRequestContextGetter
references throughout the TranslateURLFetcher path, including
TranslateLanguageList, TranslateScript, etc.

Since TestURLFetcherFactory allowed us to retrieve the actual
URLFetcher object (given an known 'id'), and SimpleURLLoader does
not, some helper methods were introduced, in order to verify the
state of the objects at a certain moment of the execution flow,
eg LanguageFetchURLForTesting and HasOngoingLanguageListLoadingForTesting.

Last, in a follow up CL, I will change the nomenclature used
throughout these files, from "fetcher" to "loader".

Bug: 773295, 844971 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ica404dded4fab79a0035df825f12d2b1bb06329e
Reviewed-on: https://chromium-review.googlesource.com/1085947
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#567002}
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/chrome/browser/translate/translate_manager_browsertest.cc
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/chrome/browser/translate/translate_service.cc
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/chrome/browser/ui/views/translate/translate_language_browsertest.cc
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/components/translate/core/browser/BUILD.gn
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/components/translate/core/browser/DEPS
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/components/translate/core/browser/translate_download_manager.cc
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/components/translate/core/browser/translate_download_manager.h
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/components/translate/core/browser/translate_language_list.cc
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/components/translate/core/browser/translate_language_list.h
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/components/translate/core/browser/translate_language_list_unittest.cc
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/components/translate/core/browser/translate_script.h
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/components/translate/core/browser/translate_script_unittest.cc
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/components/translate/core/browser/translate_url_fetcher.cc
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/components/translate/core/browser/translate_url_fetcher.h
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/ios/chrome/browser/translate/translate_service_ios.cc
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/ios/web_view/internal/DEPS
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/ios/web_view/internal/app/application_context.cc
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/ios/web_view/internal/app/application_context.h
[modify] https://crrev.com/61a972c30fcab43b3ea65e510b8fe8dde26e6274/ios/web_view/internal/translate/web_view_translate_service.cc

Blockedon: 844964
Blockedon: 844974
Blockedon: 844914
Blockedon: 844951
Project Member

Comment 99 by bugdroid1@chromium.org, Jun 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0285cde6e11a1178dbdb30a3503ae6603526c88

commit f0285cde6e11a1178dbdb30a3503ae6603526c88
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Jun 18 21:51:38 2018

Reland "Migrate ContentHashFetcher to SimpleURLLoader"

This is a reland of 27f8891c7cd9a86b2c92508cf6818726df4058d6

The main difference from the original CL is that instead of passing raw
network::mojom::URLLoaderFactory pointers, this CL takes a more conservative
approach where a thread-agnostic network::mojom::URLLoaderFactoryPtrInfo instance
is passed through ContentHash::FetchParams, which allows us to "bind" the
network::URLLoaderFactoryPtr instance only when it is actually going to be used
(in ContentHashFetcher::Start).

Also, differently than the original/reverted CL, this CL does not change
the threads ContentHash methods run on.

Last, in order to adapt ContentVerifierHashTest, we:

1) Replace the use of net::TestURLRequestInterceptor by content::URLLoaderInterceptor.
2) Install the interceptor at the beginning of each test execution flow, so
that it is able to intercept all relevant URLLoaderFactory creation requests.

Some other minor differences, were because of some preparation CLs already landed,
eg https://crrev.com/c/1089273.

Original change's description:
> Migrate ContentHashFetcher to SimpleURLLoader
>
> This CL migrates ContentHashFetcher away from URLRequestFetcher to
> SimpleURLLoader.
>
> In order to accomplish this, a few other related changes are also performed:
>
> 1) The regular flow of the code is ContentVerifier -> ContentHash ->
>    ContentHashFetcher. In ContentVerifier, for instance, UI, IO and
>    "File tasks" threads take place.
>    Previously, the URLRequestFetcher logic residing in ContentHashFetcher
>    executed in the "file tasks" thread.
>
>    As part of the migration from URLRequestFetcher to SimpleURLLoader
>    machinery, this CL also changes the ContentHashFetcher logic to
>    execute to the IO thread.
>    Note that it could be possible to keep the new SimpleURLLoader logic
>    in the "file tasks" thread. However, this would impose a way bigger change,
>    and require unittests to be considerably rewritten as well (see for
>    patchsets 7, 8 and 9.
>    The issue is that mojo objects are not thread safe. We could create a new
>    URLLoaderFactory for the extensions thread, but then we'd need to create a
>    new one when the network service crashes (Something this SharedURLLoaderFactory
>    one, already bound to the IOThread, magically handles), but that would be
>    significantly more complicated.
>
> 2) content_verifier_hash_fetch_behavior_browsertest.cc was changed
>    to support running with the network service feature both enabled
>    and disabled. This is a pattern that is also present in various other
>    unittests.
>
> In summary, the migration to use SimpleURLLoader performed here includes
> also a change in the thread that ContentHashFetcher runs on, but no
> functionality change is expected from this CL.
>
> BUG=773295, 844926 
>
> Change-Id: If570f69d01ff75ac59d8d043f8687621336dddcf
> Reviewed-on: https://chromium-review.googlesource.com/1056587
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561480}

Bug: 773295,  844926 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ie2f3665bcca5378ff67bf78bec38bdc225ff6c26
Reviewed-on: https://chromium-review.googlesource.com/1076947
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568178}
[modify] https://crrev.com/f0285cde6e11a1178dbdb30a3503ae6603526c88/chrome/browser/extensions/content_verifier_hash_fetch_behavior_browsertest.cc
[modify] https://crrev.com/f0285cde6e11a1178dbdb30a3503ae6603526c88/extensions/browser/BUILD.gn
[modify] https://crrev.com/f0285cde6e11a1178dbdb30a3503ae6603526c88/extensions/browser/DEPS
[modify] https://crrev.com/f0285cde6e11a1178dbdb30a3503ae6603526c88/extensions/browser/content_hash_fetcher.cc
[modify] https://crrev.com/f0285cde6e11a1178dbdb30a3503ae6603526c88/extensions/browser/content_hash_fetcher.h
[modify] https://crrev.com/f0285cde6e11a1178dbdb30a3503ae6603526c88/extensions/browser/content_hash_fetcher_unittest.cc
[modify] https://crrev.com/f0285cde6e11a1178dbdb30a3503ae6603526c88/extensions/browser/content_verifier.cc
[modify] https://crrev.com/f0285cde6e11a1178dbdb30a3503ae6603526c88/extensions/browser/content_verifier.h
[modify] https://crrev.com/f0285cde6e11a1178dbdb30a3503ae6603526c88/extensions/browser/content_verifier/content_hash.cc
[modify] https://crrev.com/f0285cde6e11a1178dbdb30a3503ae6603526c88/extensions/browser/content_verifier/content_hash.h
[modify] https://crrev.com/f0285cde6e11a1178dbdb30a3503ae6603526c88/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Blockedon: 844970
Blockedon: 844969
Blockedon: 844976
Blockedon: 844989
Blockedon: 844979
Blockedon: 844968
Blockedon: 844965
Blockedon: 844961
Blockedon: 844953
Blockedon: 844947
Blockedon: 844938
Blockedon: 844919
Blockedon: 844912
Blockedon: 844918
Blockedon: 844915
Project Member

Comment 115 by bugdroid1@chromium.org, Jun 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5

commit ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu Jun 28 13:10:43 2018

Migrate client_update::SendProtocolRequest to SimpleURLLoader

URLFetcher et al will stop working in the browser process with advent
of Network Service, and SimpleURLLoader is the replacement API
for most clients. CL migrates SendProtocolRequest to the new API.

Major remarks:

* URLRequestPostInterceptor is replaced by URLLoaderPostInterceptor although the public APIs
of the former is kept (are almost the same) in the later. This allows the extensive set of unit
tests to remain untouched. The replacement is needed because URLRequestPostInterceptor used
to intercept requests instantiated by URLFetcher, precisely the class we are moving away to use.

* URLLoaderPostInterceptor operates in two modes: it supports working both with TestURLLoaderFactory
and EmbeddedTestServer. Two constructors are offered that control the 'mode' it operates on.
This is needed because of the nature of the tests: some tests manipulate the TestConfigurator
directly, hence the needed SharedURLLoaderFactory instance can be acquired directly from it,
eg PingManagerTest, UpdateCheckerTest and RequestSenderTest.
Some other tests, trigger the respective SimpleURLLoader machinery from upper layers, and then
have no access to TestConfigurator instances. In such cases, URLLoaderPostInterceptor operates
using EmbeddedTestServer in order to intercept URL loads.

Note that this CL migrates components/update_client/utils.cc|h to SimpleURLLoader, but there
some other classes on the same directory that still use URLFetcher (eg UrlFetcherDownloader),
so we simply can not *yet* remove all the references to URLFetcher and URLRequestContextGetter.
It will be done in a follow up CL.

BUG=773295, 844973 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3d8be368818ba77b559907c0217995f8c6a95b04
Reviewed-on: https://chromium-review.googlesource.com/1097337
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571097}
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/chrome/browser/extensions/updater/chrome_update_client_config.cc
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/chrome/browser/extensions/updater/chrome_update_client_config.h
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/chrome/browser/extensions/updater/extension_update_client_base_browsertest.cc
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/chrome/browser/extensions/updater/extension_update_client_base_browsertest.h
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/chrome/browser/extensions/updater/update_service_browsertest.cc
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/component_updater/BUILD.gn
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/BUILD.gn
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/DEPS
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/configurator.h
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/ping_manager_unittest.cc
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/request_sender.cc
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/request_sender.h
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/request_sender_unittest.cc
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/test_configurator.cc
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/test_configurator.h
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/update_checker_unittest.cc
[add] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/url_loader_post_interceptor.cc
[add] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/url_loader_post_interceptor.h
[delete] https://crrev.com/d7b3885050f559a684c25acd04875a14c97cbcda/components/update_client/url_request_post_interceptor.cc
[delete] https://crrev.com/d7b3885050f559a684c25acd04875a14c97cbcda/components/update_client/url_request_post_interceptor.h
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/utils.cc
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/components/update_client/utils.h
[modify] https://crrev.com/ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5/ios/chrome/browser/component_updater/ios_component_updater_configurator.cc

Blockedon: 844973
Project Member

Comment 117 by bugdroid1@chromium.org, Jun 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/771fdba11217a8b117540b50fe4c2d1eac419332

commit 771fdba11217a8b117540b50fe4c2d1eac419332
Author: Olga Sharonova <olka@chromium.org>
Date: Thu Jun 28 15:01:35 2018

Revert "Migrate client_update::SendProtocolRequest to SimpleURLLoader"

This reverts commit ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5.

Reason for revert: multiple tests failing on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20(dbg)(1)(32)/50984

UpdateServiceTest.UninstallExtensionWhileUpdating
PolicyUpdateServiceTest.PolicyCorruptedOnStartup
PolicyUpdateServiceTest.FailedUpdateRetries
UpdateServiceTest.TwoUpdateCheckErrors
UpdateServiceTest.UpdateCheckError
UpdateServiceTest.SuccessfulUpdate
ComponentUpdaterPolicyTest.EnabledComponentUpdates
PolicyUpdateServiceTest.Backoff
UpdateServiceTest.PolicyCorrupted
UpdateServiceTest.NoUpdate

[5637:5892:0628/072239.370548:FATAL:http_request_headers.cc(129)] "POST /pinghost/service/ping HTTP/1.1" is missing colon delimiter.
 


Original change's description:
> Migrate client_update::SendProtocolRequest to SimpleURLLoader
> 
> URLFetcher et al will stop working in the browser process with advent
> of Network Service, and SimpleURLLoader is the replacement API
> for most clients. CL migrates SendProtocolRequest to the new API.
> 
> Major remarks:
> 
> * URLRequestPostInterceptor is replaced by URLLoaderPostInterceptor although the public APIs
> of the former is kept (are almost the same) in the later. This allows the extensive set of unit
> tests to remain untouched. The replacement is needed because URLRequestPostInterceptor used
> to intercept requests instantiated by URLFetcher, precisely the class we are moving away to use.
> 
> * URLLoaderPostInterceptor operates in two modes: it supports working both with TestURLLoaderFactory
> and EmbeddedTestServer. Two constructors are offered that control the 'mode' it operates on.
> This is needed because of the nature of the tests: some tests manipulate the TestConfigurator
> directly, hence the needed SharedURLLoaderFactory instance can be acquired directly from it,
> eg PingManagerTest, UpdateCheckerTest and RequestSenderTest.
> Some other tests, trigger the respective SimpleURLLoader machinery from upper layers, and then
> have no access to TestConfigurator instances. In such cases, URLLoaderPostInterceptor operates
> using EmbeddedTestServer in order to intercept URL loads.
> 
> Note that this CL migrates components/update_client/utils.cc|h to SimpleURLLoader, but there
> some other classes on the same directory that still use URLFetcher (eg UrlFetcherDownloader),
> so we simply can not *yet* remove all the references to URLFetcher and URLRequestContextGetter.
> It will be done in a follow up CL.
> 
> BUG=773295, 844973 
> 
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I3d8be368818ba77b559907c0217995f8c6a95b04
> Reviewed-on: https://chromium-review.googlesource.com/1097337
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Sorin Jianu <sorin@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571097}

TBR=droger@chromium.org,rdevlin.cronin@chromium.org,mmenke@chromium.org,sorin@chromium.org,emaxx@chromium.org,tonikitoo@igalia.com,mxnguyen@chromium.org

Change-Id: I0974aeef814ac153bf7da86ebf3e2f09b410bdd6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773295,  844973 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118585
Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571125}
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/chrome/browser/extensions/updater/chrome_update_client_config.cc
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/chrome/browser/extensions/updater/chrome_update_client_config.h
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/chrome/browser/extensions/updater/extension_update_client_base_browsertest.cc
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/chrome/browser/extensions/updater/extension_update_client_base_browsertest.h
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/chrome/browser/extensions/updater/update_service_browsertest.cc
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/component_updater/BUILD.gn
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/BUILD.gn
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/DEPS
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/configurator.h
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/ping_manager_unittest.cc
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/request_sender.cc
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/request_sender.h
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/request_sender_unittest.cc
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/test_configurator.cc
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/test_configurator.h
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/update_checker_unittest.cc
[delete] https://crrev.com/741158fe9991a5af722f4ee7d7f20a1899ae2e71/components/update_client/url_loader_post_interceptor.cc
[delete] https://crrev.com/741158fe9991a5af722f4ee7d7f20a1899ae2e71/components/update_client/url_loader_post_interceptor.h
[add] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/url_request_post_interceptor.cc
[add] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/url_request_post_interceptor.h
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/utils.cc
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/components/update_client/utils.h
[modify] https://crrev.com/771fdba11217a8b117540b50fe4c2d1eac419332/ios/chrome/browser/component_updater/ios_component_updater_configurator.cc

Project Member

Comment 118 by bugdroid1@chromium.org, Jun 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b616250114f1f5b45878afa71a41d7f2e3eddad3

commit b616250114f1f5b45878afa71a41d7f2e3eddad3
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu Jun 28 20:21:55 2018

Reland "Migrate client_update::SendProtocolRequest to SimpleURLLoader"

This is a reland of ccd4ec0882bbc5d235b49188ca6cc3ac43c6c9d5

Difference from the original CL is minor, but indeed the cause of
failures on debug bots:

  -  headers.AddHeadersFromString(request.all_headers);
  +  for (auto it : request.headers)
  +    headers.SetHeader(it.first, it.second);

Basically, network::ResourceRequest::all_headers can contain
lines that do not match the "key: value" syntax expected by
net::HttpRequestHeaders. Hence, we iterate over
network::ResourceRequest::headers instead.

TBR=emaxx@chromium.org,sorin@chromium.org,rdevlin.cronin@chromium.org,droger@chromium.org,mmenke@chromium.org

Original change's description:
> Migrate client_update::SendProtocolRequest to SimpleURLLoader
>
> URLFetcher et al will stop working in the browser process with advent
> of Network Service, and SimpleURLLoader is the replacement API
> for most clients. CL migrates SendProtocolRequest to the new API.
>
> Major remarks:
>
> * URLRequestPostInterceptor is replaced by URLLoaderPostInterceptor although the public APIs
> of the former is kept (are almost the same) in the later. This allows the extensive set of unit
> tests to remain untouched. The replacement is needed because URLRequestPostInterceptor used
> to intercept requests instantiated by URLFetcher, precisely the class we are moving away to use.
>
> * URLLoaderPostInterceptor operates in two modes: it supports working both with TestURLLoaderFactory
> and EmbeddedTestServer. Two constructors are offered that control the 'mode' it operates on.
> This is needed because of the nature of the tests: some tests manipulate the TestConfigurator
> directly, hence the needed SharedURLLoaderFactory instance can be acquired directly from it,
> eg PingManagerTest, UpdateCheckerTest and RequestSenderTest.
> Some other tests, trigger the respective SimpleURLLoader machinery from upper layers, and then
> have no access to TestConfigurator instances. In such cases, URLLoaderPostInterceptor operates
> using EmbeddedTestServer in order to intercept URL loads.
>
> Note that this CL migrates components/update_client/utils.cc|h to SimpleURLLoader, but there
> some other classes on the same directory that still use URLFetcher (eg UrlFetcherDownloader),
> so we simply can not *yet* remove all the references to URLFetcher and URLRequestContextGetter.
> It will be done in a follow up CL.
>
> BUG=773295, 844973 
>
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I3d8be368818ba77b559907c0217995f8c6a95b04
> Reviewed-on: https://chromium-review.googlesource.com/1097337
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Sorin Jianu <sorin@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571097}

Bug: 773295,  844973 
Change-Id: I3a8252aecf687d08e41c0d09cb9bd245fe3f712b
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118646
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#571242}
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/chrome/browser/extensions/updater/chrome_update_client_config.cc
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/chrome/browser/extensions/updater/chrome_update_client_config.h
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/chrome/browser/extensions/updater/extension_update_client_base_browsertest.cc
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/chrome/browser/extensions/updater/extension_update_client_base_browsertest.h
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/chrome/browser/extensions/updater/update_service_browsertest.cc
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/component_updater/BUILD.gn
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/BUILD.gn
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/DEPS
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/configurator.h
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/ping_manager_unittest.cc
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/request_sender.cc
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/request_sender.h
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/request_sender_unittest.cc
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/test_configurator.cc
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/test_configurator.h
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/update_checker_unittest.cc
[add] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/url_loader_post_interceptor.cc
[add] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/url_loader_post_interceptor.h
[delete] https://crrev.com/7d24b26391b9f7e35a24213db8092e7304204be7/components/update_client/url_request_post_interceptor.cc
[delete] https://crrev.com/7d24b26391b9f7e35a24213db8092e7304204be7/components/update_client/url_request_post_interceptor.h
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/utils.cc
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/components/update_client/utils.h
[modify] https://crrev.com/b616250114f1f5b45878afa71a41d7f2e3eddad3/ios/chrome/browser/component_updater/ios_component_updater_configurator.cc

Blockedon: 844936
Project Member

Comment 120 by bugdroid1@chromium.org, Jun 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fb6d9e3e5ebf545d0b74067eb9c802a9a99a83f

commit 3fb6d9e3e5ebf545d0b74067eb9c802a9a99a83f
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Jun 29 21:22:05 2018

Allow TestURLLoaderFactory::SimulateResponse's mock responses to fail

This CL makes the TestURLLoaderFactory::SimulateResponse API more flexible in the following ways:

- it starts to actually use the |net_error| parameter (to build the URLLoaderCompletionatus
  instance)
- it adds an extra (also optional) net::HttpStatusCode parameter, so that
  one can more easily mock failing responses.
- one can see it in action in [1].

[1] https://crrev.com/c/1114998/components/autofill/core/browser/autofill_download_manager_unittest.cc#283

Bug: 773295
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iba4edf640b3ff82e035ffbe26c3066d404f18ce7
Reviewed-on: https://chromium-review.googlesource.com/1120916
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571635}
[modify] https://crrev.com/3fb6d9e3e5ebf545d0b74067eb9c802a9a99a83f/services/network/test/test_url_loader_factory.cc
[modify] https://crrev.com/3fb6d9e3e5ebf545d0b74067eb9c802a9a99a83f/services/network/test/test_url_loader_factory.h

Project Member

Comment 121 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acd1a9418f3c54a417a59d6d5f6e012a3a4c0e9a

commit acd1a9418f3c54a417a59d6d5f6e012a3a4c0e9a
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Jul 10 20:23:54 2018

Add network::SharedURLLoaderFactory setter/getter in BrowserProcess

This is a preparation CL that adds a way for tests to get a
network::SharedURLLoaderFactory instance from BrowserProcess.
Particularly, TestingBrowserProcess class can also set a
SharedURLLoaderFactory instance for testing.

It is used in [1].

[1] https://crrev.com/c/1066370



BUG=773295

Change-Id: I07fe87550abb63e0225b552f4b44ba865997534c
Reviewed-on: https://chromium-review.googlesource.com/1130616
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#573883}
[modify] https://crrev.com/acd1a9418f3c54a417a59d6d5f6e012a3a4c0e9a/chrome/browser/browser_process.h
[modify] https://crrev.com/acd1a9418f3c54a417a59d6d5f6e012a3a4c0e9a/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/acd1a9418f3c54a417a59d6d5f6e012a3a4c0e9a/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/acd1a9418f3c54a417a59d6d5f6e012a3a4c0e9a/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/acd1a9418f3c54a417a59d6d5f6e012a3a4c0e9a/chrome/test/base/testing_browser_process.h

Project Member

Comment 122 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54aa1bf75a2a01dcee1eda4682a2490514a962a4

commit 54aa1bf75a2a01dcee1eda4682a2490514a962a4
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Jul 13 15:47:03 2018

Add a TestURLLoaderFactory::SimulateResponseForPendingRequest variant that takes a PendingRequest

It turns out that in order to migrate some specific unit tests more smoothly
from URLFetcher to SimpleURLLoader, it is useful to have a method where
indexing of the pending requests list is preserved after a given pending request is handled.

For instance some tests do this:

  request_load_1();
  request_load_2();
  request_load_3();
  (..)
  request_load_n();

  response_request_3();
  response_request_2();
  response_request_n();
  (..)
  response_request_1();

  // do stuff

  request_load_n+1()
  request_load_n+2()
  request_load_n+3()

  response_request_n+2()
  response_request_n+3()
  response_request_n+1()

In the above scenario, it is handy to be able to simulate responses at the original order
requests were made. This CL adds an API that fills this gap.

In practice, this is a preparation for https://crrev.com/c/1114998/.

BUG=773295

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id9059f3d8f091eabfb21948f074599c180f44128
Reviewed-on: https://chromium-review.googlesource.com/1123236
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574927}
[modify] https://crrev.com/54aa1bf75a2a01dcee1eda4682a2490514a962a4/services/network/test/test_url_loader_factory.cc
[modify] https://crrev.com/54aa1bf75a2a01dcee1eda4682a2490514a962a4/services/network/test/test_url_loader_factory.h
[modify] https://crrev.com/54aa1bf75a2a01dcee1eda4682a2490514a962a4/services/network/test/test_url_loader_factory_unittest.cc

Project Member

Comment 123 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3328d5c434b366bf9c6ddd344867be2c7f209a5e

commit 3328d5c434b366bf9c6ddd344867be2c7f209a5e
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Jul 16 15:09:28 2018

Migrate AutofillDownloadManager to SimpleURLLoader

This CL migrates AutofillDownloadManager away from URLFetcher, to
SimpleURLLoader.

As a notorious remark, the CL introduces a public method to
SimpleURLLoader, LoadedFromCache. It allows to verify whether
some specific content are served from the cache, as expected.

BUG=773295, 844929 

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I92a36bc032b7c0e182ae83f367eefd605ad888ca
Reviewed-on: https://chromium-review.googlesource.com/1114998
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#575269}
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/chrome/browser/autofill/autofill_server_browsertest.cc
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/components/autofill/core/browser/DEPS
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/components/autofill/core/browser/autofill_download_manager.cc
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/components/autofill/core/browser/autofill_download_manager.h
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/components/autofill/core/browser/autofill_download_manager_unittest.cc
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/components/autofill/core/browser/test_autofill_driver.cc
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/components/autofill/core/browser/test_autofill_driver.h
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/services/network/public/cpp/simple_url_loader.cc
[modify] https://crrev.com/3328d5c434b366bf9c6ddd344867be2c7f209a5e/services/network/public/cpp/simple_url_loader.h

Owner: ----
Status: Available (was: Assigned)
Blockedon: 865350
Blockedon: 865381
Blockedon: 865018
Project Member

Comment 128 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1a0219ccafe50725ed73b5cce2ee5cc8dfc8211

commit e1a0219ccafe50725ed73b5cce2ee5cc8dfc8211
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Aug 01 15:39:44 2018

Allow non-content code use FileURLLoaderFactory

This CL exposes a method that allows the creation of FileURLLoaderFactory
instances. through the content/browser public API.

This is a preparation for CL https://crrev.com/c/1066370.

BUG=773295, 844928 

Change-Id: I89c9cd2e82ee54f4dae1c121d5e0f7b5c0597fb1
Reviewed-on: https://chromium-review.googlesource.com/1156885
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579818}
[modify] https://crrev.com/e1a0219ccafe50725ed73b5cce2ee5cc8dfc8211/content/browser/file_url_loader_factory.cc
[modify] https://crrev.com/e1a0219ccafe50725ed73b5cce2ee5cc8dfc8211/content/public/browser/file_url_loader.h

Project Member

Comment 129 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/402dbf5a71ebb19797dec03f63640ec17aff8c6f

commit 402dbf5a71ebb19797dec03f63640ec17aff8c6f
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu Aug 02 11:06:41 2018

Set more URLLoaderCompletionStatus data for successful FileURLLoaderFactory loads

This CL allows SimpleURLLoader's to successfully load file:// URLs, ie when
using FileURLLoaderFactory.

Prior to this CL, even on the file specified in the file:// URL is written
successfully, the URLLoaderCompletionStatus instance is passed to the
URLLoaderClient from FileURLLoader::OnFileWritten, had only with the
|error_code| set.

SimpleURLLoader checks other URLLoaderCompletionStatus class members,
(eg |decoded_body_length|) in order to consider the load actually successful.

BUG=773295, 844928 

Change-Id: I1040775fad2af7f0eb88f81e48bb355d48e5fc31
Reviewed-on: https://chromium-review.googlesource.com/1159042
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#580130}
[modify] https://crrev.com/402dbf5a71ebb19797dec03f63640ec17aff8c6f/content/browser/file_url_loader_factory.cc

Project Member

Comment 130 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/581330a9f8fa0cd9b3b83def1611740a186a4881

commit 581330a9f8fa0cd9b3b83def1611740a186a4881
Author: Reilly Grant <reillyg@google.com>
Date: Tue Aug 07 00:41:17 2018

Port policy::UploadJobImpl to network::SimpleURLLoader

This change ports UploadJobImpl from net::URLFetcher to SimpleURLLoader.

Since this request does not make use of the response a new method has
been added to SimpleURLLoader, DownloadToNull. This download mode still
reads the response body from the network but does not save it anywhere.
This is useful for requests which upload data and would otherwise have
to specify an arbitrary |max_body_size|. A maximum may still be set if
the caller wants to limit the amount of data transferred over the
network.

Bug: 773295
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iee1fdc6f7406066ced8c91122e22cd51ddcb1c5f
Reviewed-on: https://chromium-review.googlesource.com/1161551
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581060}
[modify] https://crrev.com/581330a9f8fa0cd9b3b83def1611740a186a4881/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc
[modify] https://crrev.com/581330a9f8fa0cd9b3b83def1611740a186a4881/chrome/browser/chromeos/policy/system_log_uploader.cc
[modify] https://crrev.com/581330a9f8fa0cd9b3b83def1611740a186a4881/chrome/browser/chromeos/policy/upload_job_impl.cc
[modify] https://crrev.com/581330a9f8fa0cd9b3b83def1611740a186a4881/chrome/browser/chromeos/policy/upload_job_impl.h
[modify] https://crrev.com/581330a9f8fa0cd9b3b83def1611740a186a4881/chrome/browser/chromeos/policy/upload_job_unittest.cc
[modify] https://crrev.com/581330a9f8fa0cd9b3b83def1611740a186a4881/services/network/public/cpp/simple_url_loader.cc
[modify] https://crrev.com/581330a9f8fa0cd9b3b83def1611740a186a4881/services/network/public/cpp/simple_url_loader.h
[modify] https://crrev.com/581330a9f8fa0cd9b3b83def1611740a186a4881/services/network/public/cpp/simple_url_loader_unittest.cc

Project Member

Comment 131 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d027e357af9551427e60f4bc95ec855e498a2946

commit d027e357af9551427e60f4bc95ec855e498a2946
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Aug 07 20:08:26 2018

Migrate ExtensionDownloader to SimpleURLLoader

In order to keep the extensive unittests set functional, a couple of
extensions were made, apart from the migration itself. Remarkably:

- Added a new method to ExtensionDownloaderDelegate class,
  ::OnExtensionDownloadRetryForTests, used exclusively for tests.
  Basically, *various* unit tests in ExtensionUpdaterTest (namely
  TestSingleExtensionDownloading* and ProtectedDownload*) perform
  intentional load failures/retries, where resource
  request parameters and load results are set up and verified differently
  for each load fail/retry sequence.
  Prior to this CL, with URLFetcher, tests could control when to call
  URLFetcherDelegate::OnURLFetchComplete.
  In SimpleURLLoader worlds, we can not really control when the "load
  complete" callback is called, since it is a mojo call. Hence, this
  testing-only API was added so that tests can more fine-grained control
  when loads are triggered.

BUG=773295

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ife6f51837648036c8b96dbedcb093113be2fc987
Reviewed-on: https://chromium-review.googlesource.com/1066370
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Minh Nguyen <mxnguyen@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581322}
[modify] https://crrev.com/d027e357af9551427e60f4bc95ec855e498a2946/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
[modify] https://crrev.com/d027e357af9551427e60f4bc95ec855e498a2946/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.cc
[modify] https://crrev.com/d027e357af9551427e60f4bc95ec855e498a2946/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc
[modify] https://crrev.com/d027e357af9551427e60f4bc95ec855e498a2946/chrome/browser/chromeos/extensions/external_cache_impl.cc
[modify] https://crrev.com/d027e357af9551427e60f4bc95ec855e498a2946/chrome/browser/chromeos/extensions/external_cache_impl.h
[modify] https://crrev.com/d027e357af9551427e60f4bc95ec855e498a2946/chrome/browser/chromeos/extensions/external_cache_impl_unittest.cc
[modify] https://crrev.com/d027e357af9551427e60f4bc95ec855e498a2946/chrome/browser/extensions/updater/chrome_extension_downloader_factory.cc
[modify] https://crrev.com/d027e357af9551427e60f4bc95ec855e498a2946/chrome/browser/extensions/updater/chrome_extension_downloader_factory.h
[modify] https://crrev.com/d027e357af9551427e60f4bc95ec855e498a2946/chrome/browser/extensions/updater/extension_updater_unittest.cc
[modify] https://crrev.com/d027e357af9551427e60f4bc95ec855e498a2946/extensions/browser/updater/extension_downloader.cc
[modify] https://crrev.com/d027e357af9551427e60f4bc95ec855e498a2946/extensions/browser/updater/extension_downloader.h
[modify] https://crrev.com/d027e357af9551427e60f4bc95ec855e498a2946/extensions/browser/updater/extension_downloader_delegate.cc
[modify] https://crrev.com/d027e357af9551427e60f4bc95ec855e498a2946/extensions/browser/updater/extension_downloader_delegate.h

Project Member

Comment 132 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b624551f1c22ac5139c9ced011da1a15c2027b7c

commit b624551f1c22ac5139c9ced011da1a15c2027b7c
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Aug 07 23:40:05 2018

Revert "Port policy::UploadJobImpl to network::SimpleURLLoader"

This reverts commit 581330a9f8fa0cd9b3b83def1611740a186a4881.

Reason for revert: SimpleURLLoaderTest.OnUploadProgressCallback/3 is flaky

Original change's description:
> Port policy::UploadJobImpl to network::SimpleURLLoader
> 
> This change ports UploadJobImpl from net::URLFetcher to SimpleURLLoader.
> 
> Since this request does not make use of the response a new method has
> been added to SimpleURLLoader, DownloadToNull. This download mode still
> reads the response body from the network but does not save it anywhere.
> This is useful for requests which upload data and would otherwise have
> to specify an arbitrary |max_body_size|. A maximum may still be set if
> the caller wants to limit the amount of data transferred over the
> network.
> 
> Bug: 773295
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: Iee1fdc6f7406066ced8c91122e22cd51ddcb1c5f
> Reviewed-on: https://chromium-review.googlesource.com/1161551
> Commit-Queue: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581060}

TBR=pastarmovj@chromium.org,reillyg@chromium.org,mmenke@chromium.org

Change-Id: Ica09c85a12861d35efbdfd9a882d137bac6b9e56
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773295,  872023 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1166288
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581389}
[modify] https://crrev.com/b624551f1c22ac5139c9ced011da1a15c2027b7c/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc
[modify] https://crrev.com/b624551f1c22ac5139c9ced011da1a15c2027b7c/chrome/browser/chromeos/policy/system_log_uploader.cc
[modify] https://crrev.com/b624551f1c22ac5139c9ced011da1a15c2027b7c/chrome/browser/chromeos/policy/upload_job_impl.cc
[modify] https://crrev.com/b624551f1c22ac5139c9ced011da1a15c2027b7c/chrome/browser/chromeos/policy/upload_job_impl.h
[modify] https://crrev.com/b624551f1c22ac5139c9ced011da1a15c2027b7c/chrome/browser/chromeos/policy/upload_job_unittest.cc
[modify] https://crrev.com/b624551f1c22ac5139c9ced011da1a15c2027b7c/services/network/public/cpp/simple_url_loader.cc
[modify] https://crrev.com/b624551f1c22ac5139c9ced011da1a15c2027b7c/services/network/public/cpp/simple_url_loader.h
[modify] https://crrev.com/b624551f1c22ac5139c9ced011da1a15c2027b7c/services/network/public/cpp/simple_url_loader_unittest.cc

Project Member

Comment 133 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4bc1f55ef9176428c0a0673b9574b6575f733d3

commit b4bc1f55ef9176428c0a0673b9574b6575f733d3
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Aug 07 23:56:28 2018

Reland "Port policy::UploadJobImpl to network::SimpleURLLoader"

This reverts commit b624551f1c22ac5139c9ced011da1a15c2027b7c.

Reason for revert: Reverting this change broke the tree because of a patch that depends on it. Since the test is only flaky fixing the tree is better than causing more disturbance by reverting more changes.

Original change's description:
> Revert "Port policy::UploadJobImpl to network::SimpleURLLoader"
> 
> This reverts commit 581330a9f8fa0cd9b3b83def1611740a186a4881.
> 
> Reason for revert: SimpleURLLoaderTest.OnUploadProgressCallback/3 is flaky
> 
> Original change's description:
> > Port policy::UploadJobImpl to network::SimpleURLLoader
> > 
> > This change ports UploadJobImpl from net::URLFetcher to SimpleURLLoader.
> > 
> > Since this request does not make use of the response a new method has
> > been added to SimpleURLLoader, DownloadToNull. This download mode still
> > reads the response body from the network but does not save it anywhere.
> > This is useful for requests which upload data and would otherwise have
> > to specify an arbitrary |max_body_size|. A maximum may still be set if
> > the caller wants to limit the amount of data transferred over the
> > network.
> > 
> > Bug: 773295
> > Cq-Include-Trybots: luci.chromium.try:linux_mojo
> > Change-Id: Iee1fdc6f7406066ced8c91122e22cd51ddcb1c5f
> > Reviewed-on: https://chromium-review.googlesource.com/1161551
> > Commit-Queue: Reilly Grant <reillyg@chromium.org>
> > Reviewed-by: Matt Menke <mmenke@chromium.org>
> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581060}
> 
> TBR=pastarmovj@chromium.org,reillyg@chromium.org,mmenke@chromium.org
> 
> Change-Id: Ica09c85a12861d35efbdfd9a882d137bac6b9e56
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 773295,  872023 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Reviewed-on: https://chromium-review.googlesource.com/1166288
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Commit-Queue: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581389}

TBR=pastarmovj@chromium.org,reillyg@chromium.org,mmenke@chromium.org

Change-Id: I793ab6c8c22c5bec97ef853f520dc506809970cb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773295,  872023 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1166301
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581394}
[modify] https://crrev.com/b4bc1f55ef9176428c0a0673b9574b6575f733d3/chrome/browser/chromeos/policy/remote_commands/screenshot_delegate.cc
[modify] https://crrev.com/b4bc1f55ef9176428c0a0673b9574b6575f733d3/chrome/browser/chromeos/policy/system_log_uploader.cc
[modify] https://crrev.com/b4bc1f55ef9176428c0a0673b9574b6575f733d3/chrome/browser/chromeos/policy/upload_job_impl.cc
[modify] https://crrev.com/b4bc1f55ef9176428c0a0673b9574b6575f733d3/chrome/browser/chromeos/policy/upload_job_impl.h
[modify] https://crrev.com/b4bc1f55ef9176428c0a0673b9574b6575f733d3/chrome/browser/chromeos/policy/upload_job_unittest.cc
[modify] https://crrev.com/b4bc1f55ef9176428c0a0673b9574b6575f733d3/services/network/public/cpp/simple_url_loader.cc
[modify] https://crrev.com/b4bc1f55ef9176428c0a0673b9574b6575f733d3/services/network/public/cpp/simple_url_loader.h
[modify] https://crrev.com/b4bc1f55ef9176428c0a0673b9574b6575f733d3/services/network/public/cpp/simple_url_loader_unittest.cc

Blockedon: 844928
Project Member

Comment 135 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa6d8593a3ff0cbede6f25317704576bebe84654

commit aa6d8593a3ff0cbede6f25317704576bebe84654
Author: John Abd-El-Malek <jam@chromium.org>
Date: Wed Aug 08 15:57:07 2018

Enable now passing browser_tests with network service.

Bug:  769401 , 865350 , 844915 ,773295
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ie7c87877597686927a401b64120c444c79a8912c
Reviewed-on: https://chromium-review.googlesource.com/1166593
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581577}
[modify] https://crrev.com/aa6d8593a3ff0cbede6f25317704576bebe84654/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Project Member

Comment 136 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d36e8296a5882ac323aa2e4ffb3704d438b3838

commit 8d36e8296a5882ac323aa2e4ffb3704d438b3838
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu Aug 09 23:14:59 2018

s13n: Expose an API to get the total of decompressed bytes of a response body

While migrating some classes from URLFetcher to SimpleURLLoader,
it is useful to have the size of the resulting decompressed body.

In case of DownloadToString* calls, this is straightfoward:
the length to the string is the size.
However, in the case of DownloadTo{Temp}File calls, where only the
resulting file path is passed to the completion callback, having
an API to get the decompressed body size is useful. It also avoids
sync calls to access the file data.

This CL adds a SimpleURLLoader::GetContentSize API that provides such
value. When used with SimpleURLLloader::SetAllowPartialResults(true),
the API returns the total decompressed body size even in the case of
errors.

BUG=773295, 844972 

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ia8cdb3326b5d5c74276e384f966a7e98f61a8c46
Reviewed-on: https://chromium-review.googlesource.com/1167683
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581952}
[modify] https://crrev.com/8d36e8296a5882ac323aa2e4ffb3704d438b3838/services/network/public/cpp/simple_url_loader.cc
[modify] https://crrev.com/8d36e8296a5882ac323aa2e4ffb3704d438b3838/services/network/public/cpp/simple_url_loader.h
[modify] https://crrev.com/8d36e8296a5882ac323aa2e4ffb3704d438b3838/services/network/public/cpp/simple_url_loader_unittest.cc

Project Member

Comment 137 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a739bf463eeb57b9254d35b45c99fd66c49c4d17

commit a739bf463eeb57b9254d35b45c99fd66c49c4d17
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Aug 13 20:50:30 2018

Migrate FinancialPing to SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates RLZTracker and FinancialPing away from URLFetcher.

Bug=773295, 844989 

Change-Id: I07fc8d09b359727ad8649e38355dd6af2bc60b02
Reviewed-on: https://chromium-review.googlesource.com/1142749
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Carlos Pizano <cpu@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582698}
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/chrome/browser/rlz/chrome_rlz_tracker_delegate.cc
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/chrome/browser/rlz/chrome_rlz_tracker_delegate.h
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/components/rlz/BUILD.gn
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/components/rlz/DEPS
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/components/rlz/rlz_tracker.cc
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/components/rlz/rlz_tracker.h
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/components/rlz/rlz_tracker_delegate.h
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/components/rlz/rlz_tracker_unittest.cc
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/BUILD.gn
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/DEPS
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/lib/financial_ping.cc
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/lib/financial_ping.h
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/lib/rlz_lib.cc
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/lib/rlz_lib.h
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/lib/rlz_lib_test.cc
[modify] https://crrev.com/a739bf463eeb57b9254d35b45c99fd66c49c4d17/rlz/test/rlz_unittest_main.cc

Project Member

Comment 138 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75cdb263f3b7d0949d6a5dc19894c172a600ea69

commit 75cdb263f3b7d0949d6a5dc19894c172a600ea69
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Aug 17 13:51:23 2018

Migrate WebRtcEventLogUploaderImpl to SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates WebRtcEventLogUploaderImpl et al away from URLFetcher.

Note that this CL slightly changes the flow of the WebRtcEventLogUploader code.
Previously, an URLRequestContextGetter instance was acquired on UI thread,
passed to the IO-capable task runner, used there, and ultimately deleted either
on the UI thread or on the IO-capable task runner thread, depending on the
termination circumstance (eg BrowserProcessImpl shutdown or upload completion,
respectively).

However, URLLoaderFactory and SimpleURLLoader have stricter threading
restrictions than URLFetcher and URLRequestContextGetter. For instance, a
SharedURLLoaderFactory instance needs to be created, used and deleted on
the same thread.
Given this scenario, a natural approach to tackle this migration would be
the use of CrossThreadSharedURLLoaderFactory{Info} classes. However, as
mentioned earlier, the fact that WebRtcEventLogUploader instances are
constructed the aforementioned IO-capable task runner thread and the
deletion thread varies, make the use of CrossThreadSharedURLLoaderFactory{Info}
less straightforward.

This CL makes use of the thread agnostic network::mojom::URLLoaderFactoryPtrInfo
class instead: from the IO-capable task runner it posts a message to the UI thread
to bind a network::mojom::URLLoaderFactory object. As per the mojo documentation [1]:

  "Once the LoggerPtr is bound we can immediately begin calling Logger interface
  methods on it, which will immediately write messages into the pipe. These
  messages will stay queued on the receiving end of the pipe until someone
  binds to it and starts reading them."

[1] https://chromium.googlesource.com/chromium/src/+/master/mojo/public/cpp/bindings/README.md#Binding-an-Interface-Request

BUG=773295, 873187 

Change-Id: Ic29222ea63e90dcb26f3124bdea1c627570dc04d
Reviewed-on: https://chromium-review.googlesource.com/1171622
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Elad Alon <eladalon@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584048}
[modify] https://crrev.com/75cdb263f3b7d0949d6a5dc19894c172a600ea69/chrome/browser/media/webrtc/webrtc_event_log_manager.cc
[modify] https://crrev.com/75cdb263f3b7d0949d6a5dc19894c172a600ea69/chrome/browser/media/webrtc/webrtc_event_log_manager.h
[modify] https://crrev.com/75cdb263f3b7d0949d6a5dc19894c172a600ea69/chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc
[modify] https://crrev.com/75cdb263f3b7d0949d6a5dc19894c172a600ea69/chrome/browser/media/webrtc/webrtc_event_log_manager_remote.h
[modify] https://crrev.com/75cdb263f3b7d0949d6a5dc19894c172a600ea69/chrome/browser/media/webrtc/webrtc_event_log_manager_unittest.cc
[modify] https://crrev.com/75cdb263f3b7d0949d6a5dc19894c172a600ea69/chrome/browser/media/webrtc/webrtc_event_log_uploader.cc
[modify] https://crrev.com/75cdb263f3b7d0949d6a5dc19894c172a600ea69/chrome/browser/media/webrtc/webrtc_event_log_uploader.h
[modify] https://crrev.com/75cdb263f3b7d0949d6a5dc19894c172a600ea69/chrome/browser/media/webrtc/webrtc_event_log_uploader_impl_unittest.cc

Project Member

Comment 139 by bugdroid1@chromium.org, Aug 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf4f299d16f25abc763cb86c06a0e8ce46ecca04

commit bf4f299d16f25abc763cb86c06a0e8ce46ecca04
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Sat Aug 25 03:35:07 2018

Migrate components/sync/engine/net/http_bridge.cc to network::SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates HttpBridge and FinancialPing away from URLFetcher.

Note that this CL slightly changes the flow of the HttpBridge{Factory} code.
Previously, an URLRequestContextGetter instance was acquired on UI thread,
passed to the Sync and IO threads.
However, URLLoaderFactory and SimpleURLLoader have stricter threading
restrictions than URLFetcher and URLRequestContextGetter. For instance, a
SharedURLLoaderFactory instance needs to be created, used and deleted on
the same thread.

For this reason methods like HttpBridgeFactory::OnSignalReceived
can not simply null out |url_loader_factory_| which is created on the "sync"
thread.

Additionally, some preexisting tests do not seem relevant for the context
of network service, and got removed, eg TestUsesSameHttpNetworkSession,
RequestContextGetterReleaseOrder and EarlyAbortFactory.
Particularly, the last two used to deal with URLRequestContextGetter
destruction. With the URLLoader migration, HttpBridge now holds on
to mojo pipes  instead of URLRequestContextGetter.

BUG=773295, 844968 

Change-Id: I185f814ba171dca69fec55b913b86a0cc9993ef1
Reviewed-on: https://chromium-review.googlesource.com/1174655
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586115}
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/BUILD.gn
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/engine/net/DEPS
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/engine/net/http_bridge.cc
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/engine/net/http_bridge.h
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/engine/net/http_bridge_network_resources.cc
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/engine/net/http_bridge_network_resources.h
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/engine/net/http_bridge_unittest.cc
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/engine/net/network_resources.h
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/test/DEPS
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/test/fake_server/fake_server_network_resources.cc
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/test/fake_server/fake_server_network_resources.h
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/tools/BUILD.gn
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/tools/DEPS
[modify] https://crrev.com/bf4f299d16f25abc763cb86c06a0e8ce46ecca04/components/sync/tools/sync_client.cc

Project Member

Comment 140 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a13c7eff9bd09b1dfbd93b2d2ec23c1d89350549

commit a13c7eff9bd09b1dfbd93b2d2ec23c1d89350549
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Aug 28 21:01:15 2018

Migrate remoting::ChromiumUrlRequest to SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates remoting::ChromiumUrlRequest et al away from URLFetcher.

BUG=773295

Change-Id: Ib8c567eb3271174f7b1fb802321af478f529f5c7
Reviewed-on: https://chromium-review.googlesource.com/1194042
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586848}
[modify] https://crrev.com/a13c7eff9bd09b1dfbd93b2d2ec23c1d89350549/remoting/base/chromium_url_request.cc
[modify] https://crrev.com/a13c7eff9bd09b1dfbd93b2d2ec23c1d89350549/remoting/base/chromium_url_request.h
[modify] https://crrev.com/a13c7eff9bd09b1dfbd93b2d2ec23c1d89350549/remoting/client/BUILD.gn
[modify] https://crrev.com/a13c7eff9bd09b1dfbd93b2d2ec23c1d89350549/remoting/client/chromoting_client_runtime.cc
[modify] https://crrev.com/a13c7eff9bd09b1dfbd93b2d2ec23c1d89350549/remoting/client/chromoting_session.cc
[modify] https://crrev.com/a13c7eff9bd09b1dfbd93b2d2ec23c1d89350549/remoting/host/it2me/it2me_host.cc
[modify] https://crrev.com/a13c7eff9bd09b1dfbd93b2d2ec23c1d89350549/remoting/host/it2me/it2me_host_unittest.cc
[modify] https://crrev.com/a13c7eff9bd09b1dfbd93b2d2ec23c1d89350549/remoting/host/remoting_me2me_host.cc
[modify] https://crrev.com/a13c7eff9bd09b1dfbd93b2d2ec23c1d89350549/remoting/protocol/http_ice_config_request.cc
[modify] https://crrev.com/a13c7eff9bd09b1dfbd93b2d2ec23c1d89350549/remoting/test/BUILD.gn
[modify] https://crrev.com/a13c7eff9bd09b1dfbd93b2d2ec23c1d89350549/remoting/test/test_chromoting_client.cc

Project Member

Comment 141 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8033ba735a7599fce31ca14587ee241fcd3845ac

commit 8033ba735a7599fce31ca14587ee241fcd3845ac
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Aug 28 22:04:34 2018

Rewrite HttpIceConfigRequestTest not to mock results

This CL is a follow up of [1], where remoting::ChromiumUrlRequest
migrated away from URLFetcher to SimpleURLLoader.

During the migration, it was observed the ChromiumUrlRequest actual
fetch/load machinery was not exercised at all by tests.
This CL is a first step to fill this gap: rather than fully
mock remoting::UrlRequest results, it now makes use of
TestURLLoaderFactory and ChromiumUrlRequest.

BUG=773295

Change-Id: Ie93fca014d4ae7186cfae9582568657476e5fd88
Reviewed-on: https://chromium-review.googlesource.com/1194622
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586878}
[modify] https://crrev.com/8033ba735a7599fce31ca14587ee241fcd3845ac/remoting/protocol/DEPS
[modify] https://crrev.com/8033ba735a7599fce31ca14587ee241fcd3845ac/remoting/protocol/http_ice_config_request_unittest.cc

Project Member

Comment 142 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c45bee91be6fcf441ec3daa73946ad7ab2198f9

commit 1c45bee91be6fcf441ec3daa73946ad7ab2198f9
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Aug 31 10:33:56 2018

Migrate remoting::GcdRestClient to SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates remoting::GcdRestClient and the respective
unittests away from URLFetcher.

BUG=773295

Change-Id: I177430191cf50c8af3e7424cf9ed2e2b459ea4af
Reviewed-on: https://chromium-review.googlesource.com/1195602
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#587984}
[modify] https://crrev.com/1c45bee91be6fcf441ec3daa73946ad7ab2198f9/remoting/host/gcd_rest_client.cc
[modify] https://crrev.com/1c45bee91be6fcf441ec3daa73946ad7ab2198f9/remoting/host/gcd_rest_client.h
[modify] https://crrev.com/1c45bee91be6fcf441ec3daa73946ad7ab2198f9/remoting/host/gcd_rest_client_unittest.cc
[modify] https://crrev.com/1c45bee91be6fcf441ec3daa73946ad7ab2198f9/remoting/host/gcd_state_updater_unittest.cc
[modify] https://crrev.com/1c45bee91be6fcf441ec3daa73946ad7ab2198f9/remoting/host/remoting_me2me_host.cc
[modify] https://crrev.com/1c45bee91be6fcf441ec3daa73946ad7ab2198f9/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 144 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f155c8b6e7d3f9cfe1c28f4ff1e4536c34d416d

commit 2f155c8b6e7d3f9cfe1c28f4ff1e4536c34d416d
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Aug 31 21:46:33 2018

Migrate DnsBlackholeChecker to SimpleURLLoader

TBR=dullweber@chromium.org (for tools/traffic_annotation/summary/annotations.xml)

BUG=773295

Change-Id: I5ee6e7ea8cd48c18f7e51487f974a7cde1ec49d2
Reviewed-on: https://chromium-review.googlesource.com/1199484
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588181}
[modify] https://crrev.com/2f155c8b6e7d3f9cfe1c28f4ff1e4536c34d416d/remoting/host/dns_blackhole_checker.cc
[modify] https://crrev.com/2f155c8b6e7d3f9cfe1c28f4ff1e4536c34d416d/remoting/host/dns_blackhole_checker.h
[modify] https://crrev.com/2f155c8b6e7d3f9cfe1c28f4ff1e4536c34d416d/remoting/host/remoting_me2me_host.cc
[modify] https://crrev.com/2f155c8b6e7d3f9cfe1c28f4ff1e4536c34d416d/tools/traffic_annotation/summary/annotations.xml

Project Member

Comment 145 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e550f40c242e1b82630df90be057b76cf75b0870

commit e550f40c242e1b82630df90be057b76cf75b0870
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Sep 10 20:41:45 2018

Migrate PrefetchRequestFetcher to using SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates PrefetchRequestFetcher et al and the
respective unittests away from URLFetcher.

Bug: 773295, 879776 
Change-Id: Ibcfc2a7d72b6efe1b372233ade95b58d95fbf62b
Reviewed-on: https://chromium-review.googlesource.com/1215367
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#590048}
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/chrome/browser/offline_pages/prefetch/prefetch_service_factory.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/BUILD.gn
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/DEPS
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/generate_page_bundle_request.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/generate_page_bundle_request.h
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/generate_page_bundle_request_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/generate_page_bundle_task_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/get_operation_request.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/get_operation_request.h
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/get_operation_request_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/get_operation_task_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_dispatcher_impl_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_gcm_app_handler_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_network_request_factory_impl.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_network_request_factory_impl.h
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_network_request_factory_impl_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_request_fetcher.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_request_fetcher.h
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_request_fetcher_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_request_operation_response_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_request_test_base.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_request_test_base.h
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_task_test_base.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/prefetch_task_test_base.h
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/suggested_articles_observer_unittest.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/test_prefetch_network_request_factory.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/core/prefetch/test_prefetch_network_request_factory.h
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/task/task_test_base.cc
[modify] https://crrev.com/e550f40c242e1b82630df90be057b76cf75b0870/components/offline_pages/task/task_test_base.h

Project Member

Comment 146 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c02048ed977c8c8b8e685f764da72c37ad7bfbeb

commit c02048ed977c8c8b8e685f764da72c37ad7bfbeb
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Sep 10 22:21:17 2018

[chromeos] Migrate AttestationCAClient to SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates chromeos::chromeos::AttestationCAClient and the
respective unittests away from URLFetcher.

BUG=773295, 879782 

Change-Id: I9ccdad3a73108ad3e3e7ab4f148b93048433b3bd
Reviewed-on: https://chromium-review.googlesource.com/1202223
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590089}
[modify] https://crrev.com/c02048ed977c8c8b8e685f764da72c37ad7bfbeb/chrome/browser/chromeos/attestation/attestation_ca_client.cc
[modify] https://crrev.com/c02048ed977c8c8b8e685f764da72c37ad7bfbeb/chrome/browser/chromeos/attestation/attestation_ca_client.h
[modify] https://crrev.com/c02048ed977c8c8b8e685f764da72c37ad7bfbeb/chrome/browser/chromeos/attestation/attestation_ca_client_unittest.cc

Project Member

Comment 147 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ddfc366a47b83c581018480c6adcc8176361e96

commit 4ddfc366a47b83c581018480c6adcc8176361e96
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Sep 17 12:01:08 2018

[ios] Migrate ContextualSearchDelegate using SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates iOS's ContextualSearchDelegate away from URLFetcher.

luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs

Bug: 773295, 879775 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I008a9070fe3131dcd1d21dfe8a48d0acea1e8f8d
Reviewed-on: https://chromium-review.googlesource.com/1225230
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#591646}
[modify] https://crrev.com/4ddfc366a47b83c581018480c6adcc8176361e96/ios/chrome/browser/ui/contextual_search/contextual_search_delegate.cc
[modify] https://crrev.com/4ddfc366a47b83c581018480c6adcc8176361e96/ios/chrome/browser/ui/contextual_search/contextual_search_delegate.h

Project Member

Comment 148 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb30b1b99375310ab3df32b82d30fb173936365d

commit cb30b1b99375310ab3df32b82d30fb173936365d
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Sep 19 16:22:53 2018

Add a TestURLLoaderFactory::GetPendingRequest API, and start using it.

Currently, there is currently ~9 identical implementations of this
method spread across various tests / components. This CL is a first
step that eliminates this redundancy, by adding a API to it in
TestURLLoaderFactory and convert a couple of call sites.

TBR=dewittj@chromium.org (straight forward switch in //components/offline_pages).

BUG=773295

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ie6b6867b046a72d0be7a7ec2bb6d964d2cfceb3e
Reviewed-on: https://chromium-review.googlesource.com/1234133
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592431}
[modify] https://crrev.com/cb30b1b99375310ab3df32b82d30fb173936365d/components/offline_pages/core/prefetch/prefetch_request_test_base.cc
[modify] https://crrev.com/cb30b1b99375310ab3df32b82d30fb173936365d/components/offline_pages/core/prefetch/prefetch_task_test_base.cc
[modify] https://crrev.com/cb30b1b99375310ab3df32b82d30fb173936365d/services/network/test/test_url_loader_factory.cc
[modify] https://crrev.com/cb30b1b99375310ab3df32b82d30fb173936365d/services/network/test/test_url_loader_factory.h

Project Member

Comment 149 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f84cf7edd6167f90ea801cfb17fdfd42d0ed337e

commit f84cf7edd6167f90ea801cfb17fdfd42d0ed337e
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu Sep 20 15:35:11 2018

[ios] Migrate URLDownloader to SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates URLDownloader and the respective unittests away
from URLFetcher.

BUG=773295

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8abfd9c9d9e66757c555479fe6a153e3dc08b9c5
Reviewed-on: https://chromium-review.googlesource.com/1234635
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#592808}
[modify] https://crrev.com/f84cf7edd6167f90ea801cfb17fdfd42d0ed337e/ios/chrome/browser/reading_list/reading_list_download_service.cc
[modify] https://crrev.com/f84cf7edd6167f90ea801cfb17fdfd42d0ed337e/ios/chrome/browser/reading_list/reading_list_download_service.h
[modify] https://crrev.com/f84cf7edd6167f90ea801cfb17fdfd42d0ed337e/ios/chrome/browser/reading_list/reading_list_download_service_factory.cc
[modify] https://crrev.com/f84cf7edd6167f90ea801cfb17fdfd42d0ed337e/ios/chrome/browser/reading_list/url_downloader.cc
[modify] https://crrev.com/f84cf7edd6167f90ea801cfb17fdfd42d0ed337e/ios/chrome/browser/reading_list/url_downloader.h
[modify] https://crrev.com/f84cf7edd6167f90ea801cfb17fdfd42d0ed337e/ios/chrome/browser/reading_list/url_downloader_unittest.mm

Project Member

Comment 150 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2347d208c8c3262bf2f8a12849f0f382ec04c7ff

commit 2347d208c8c3262bf2f8a12849f0f382ec04c7ff
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Sep 25 15:19:28 2018

Migrate OpenInController to SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates iOS' OpenInController.

Additionally, the CL also fixes the unittest TestDisplayOpenInMenu
that was flagged as DISABLED.

BUG=773295

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I130b80cc7854d95266fba45b94df0caa40f89eda
Reviewed-on: https://chromium-review.googlesource.com/1239373
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#593938}
[modify] https://crrev.com/2347d208c8c3262bf2f8a12849f0f382ec04c7ff/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/2347d208c8c3262bf2f8a12849f0f382ec04c7ff/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/2347d208c8c3262bf2f8a12849f0f382ec04c7ff/ios/chrome/browser/ui/open_in_controller.h
[modify] https://crrev.com/2347d208c8c3262bf2f8a12849f0f382ec04c7ff/ios/chrome/browser/ui/open_in_controller.mm
[modify] https://crrev.com/2347d208c8c3262bf2f8a12849f0f382ec04c7ff/ios/chrome/browser/ui/open_in_controller_unittest.mm

Project Member

Comment 151 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aef4857d31dd4d616d3efd94491e7b1a8deaf819

commit aef4857d31dd4d616d3efd94491e7b1a8deaf819
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Sep 25 18:49:18 2018

[android] Migrate ContextualSearchDelegate using SimpleURLLoader

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates Android's ContextualSearchDelegate and the
respective unittests away from URLFetcher.

Bug: 773295, 872875 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ifd2f3afd0db3ceaf75f6a8f972259c656ec7db69
Reviewed-on: https://chromium-review.googlesource.com/1221729
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594025}
[modify] https://crrev.com/aef4857d31dd4d616d3efd94491e7b1a8deaf819/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
[modify] https://crrev.com/aef4857d31dd4d616d3efd94491e7b1a8deaf819/chrome/browser/android/contextualsearch/contextual_search_delegate.h
[modify] https://crrev.com/aef4857d31dd4d616d3efd94491e7b1a8deaf819/chrome/browser/android/contextualsearch/contextual_search_delegate_unittest.cc
[modify] https://crrev.com/aef4857d31dd4d616d3efd94491e7b1a8deaf819/chrome/browser/android/contextualsearch/contextual_search_manager.cc

Blockedon: 855620
Project Member

Comment 153 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f8f95653907e078959b7a475138b3731c38536a

commit 2f8f95653907e078959b7a475138b3731c38536a
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Mon Nov 05 19:37:25 2018

Ensure SimpleURLLoader callbacks are set prior to request being started

CL makes sure that SetOnResponseStartedCallback and SetOnRedirectCallback
can only be set prior to the request gets started.

This is a follow up on a request made by mmenke@ in [1].

[1] https://crrev.com/c/1142350/14/services/network/public/cpp/simple_url_loader.cc#1226

TBR=pfeldman@chromium.org,peter@chromium.org

BUG=773295

Change-Id: If937313c21df5139f1c6e21f982b228513501962
Reviewed-on: https://chromium-review.googlesource.com/c/1317949
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605417}
[modify] https://crrev.com/2f8f95653907e078959b7a475138b3731c38536a/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/2f8f95653907e078959b7a475138b3731c38536a/content/shell/browser/shell_devtools_bindings.cc
[modify] https://crrev.com/2f8f95653907e078959b7a475138b3731c38536a/services/network/public/cpp/simple_url_loader.cc

Project Member

Comment 154 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f513b7c0c1803fe4688b8eee2dab06f48dabf081

commit f513b7c0c1803fe4688b8eee2dab06f48dabf081
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Nov 09 16:24:01 2018

Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy

... and remove the later.

This is a follow up of mmenke's request in [1].

[1] https://crrev.com/c/1251642/3/services/network/url_loader.cc#70

TBR=nparker@chromium (components/safe_browsing/browser/threat_details_cache.cc)
TBR=jam@chromium.org (content/browser/loader/resource_loader.cc)

BUG=773295

Change-Id: I932315bec7d1790dbc8726eeb1decce6e76172b1
Reviewed-on: https://chromium-review.googlesource.com/c/1320769
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606864}
[modify] https://crrev.com/f513b7c0c1803fe4688b8eee2dab06f48dabf081/components/policy/core/common/cloud/device_management_service.cc
[modify] https://crrev.com/f513b7c0c1803fe4688b8eee2dab06f48dabf081/components/safe_browsing/browser/threat_details_cache.cc
[modify] https://crrev.com/f513b7c0c1803fe4688b8eee2dab06f48dabf081/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/f513b7c0c1803fe4688b8eee2dab06f48dabf081/services/network/public/cpp/resource_response.cc
[modify] https://crrev.com/f513b7c0c1803fe4688b8eee2dab06f48dabf081/services/network/public/cpp/resource_response_info.cc
[modify] https://crrev.com/f513b7c0c1803fe4688b8eee2dab06f48dabf081/services/network/public/cpp/resource_response_info.h
[modify] https://crrev.com/f513b7c0c1803fe4688b8eee2dab06f48dabf081/services/network/url_loader.cc

Showing comments 55 - 154 of 154 Older

Sign in to add a comment