Late 2016, we added a node download just-for-devtools, just-on-the-bots (https://codereview.chromium.org/2486903002) Early 2017, we added node for everyone, for webui (https://codereview.chromium.org/2574033002) So now the linux bots check out node twice. We should remove the devtools version and make devtools use "global" node.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a9fd7ca1f8606124e9827e453059e13c94ca305 commit 8a9fd7ca1f8606124e9827e453059e13c94ca305 Author: Will Chen <chenwilliam@chromium.org> Date: Fri Dec 22 02:42:00 2017 DevTools: use Chromium-wide node.js binary instead of DevTools-specific This removes DevTools special workflow running node.js on bots and instead uses the Chromium-wide node.js binary. This also uses the same node.js / eslint versions for running eslint check locally on PRESUBMIT and on bots for CQ. Drive-by: auto-fixes semicolon, in addition to braces, with eslint as part of the format PRESUBMIT check. Bug: 773287 Change-Id: I6d2d0e5c4806773c52b94e8ad4cebb65aa30f849 Reviewed-on: https://chromium-review.googlesource.com/837651 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#525911} [modify] https://crrev.com/8a9fd7ca1f8606124e9827e453059e13c94ca305/DEPS [modify] https://crrev.com/8a9fd7ca1f8606124e9827e453059e13c94ca305/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/8a9fd7ca1f8606124e9827e453059e13c94ca305/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/8a9fd7ca1f8606124e9827e453059e13c94ca305/third_party/WebKit/Source/devtools/PRESUBMIT.py [modify] https://crrev.com/8a9fd7ca1f8606124e9827e453059e13c94ca305/third_party/WebKit/Source/devtools/scripts/README.md [delete] https://crrev.com/f25d5a002a4e14c9f3b89b1e10b2ada99f8d7e7a/third_party/WebKit/Source/devtools/scripts/buildbot/run_eslint.py [delete] https://crrev.com/f25d5a002a4e14c9f3b89b1e10b2ada99f8d7e7a/third_party/WebKit/Source/devtools/scripts/install_node_deps.py [modify] https://crrev.com/8a9fd7ca1f8606124e9827e453059e13c94ca305/third_party/WebKit/Source/devtools/scripts/lint_javascript.py [add] https://crrev.com/8a9fd7ca1f8606124e9827e453059e13c94ca305/third_party/WebKit/Source/devtools/scripts/local_node.py [delete] https://crrev.com/f25d5a002a4e14c9f3b89b1e10b2ada99f8d7e7a/third_party/WebKit/Source/devtools/scripts/local_node/__init__.py [delete] https://crrev.com/f25d5a002a4e14c9f3b89b1e10b2ada99f8d7e7a/third_party/WebKit/Source/devtools/scripts/local_node/node.py [delete] https://crrev.com/f25d5a002a4e14c9f3b89b1e10b2ada99f8d7e7a/third_party/WebKit/Source/devtools/scripts/local_node/npm.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48fbfe0faf98c982606fcf6d2732c9adcf086f1a commit 48fbfe0faf98c982606fcf6d2732c9adcf086f1a Author: Will Chen <chenwilliam@chromium.org> Date: Wed Jan 03 06:04:50 2018 DevTools: update DEPS to sync devtools-node-modules for all platforms My previous CL changed devtools PRESUBMIT to use eslint from devtools-node-modules: https://chromium-review.googlesource.com/c/chromium/src/+/837651 I inadvertently broke the PRESUBMIT workflow for non-Linux developers because devtools-node-modules was only sync'ed for Linux. Bug: 773287 Change-Id: Ib4bd8ca5a3b61b3289057870996f41a52e8f1784 Reviewed-on: https://chromium-review.googlesource.com/848322 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#526633} [modify] https://crrev.com/48fbfe0faf98c982606fcf6d2732c9adcf086f1a/DEPS
Comment 1 by chenwilliam@chromium.org
, Oct 10 2017