New issue
Advanced search Search tips

Issue 773282 link

Starred by 1 user
Status: Fixed
Owner:
vasi...@chromium.org
Closed: Oct 2017
Cc:
kolos@chromium.org
vasi...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 753806



Sign in to add a comment

[Password Manager] Don't show the eye icon in a prompt in case of federated credentials

Project Member Reported by kolos@chromium.org, Oct 10 2017 
See the attachment for actual state. The eye icon should be absent.
bubble_for_federated_credentials.png
7.9 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b845b0b16a5d30447f1adaba273131fdc0bbb71

commit 9b845b0b16a5d30447f1adaba273131fdc0bbb71
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Tue Oct 10 18:32:55 2017

[Password Manager] Don't show the eye icon in a prompt in case of federated credentials

Bug:  773282 
Change-Id: I0eafe85e6b430ee208f320fb613609976fde3dac
Reviewed-on: https://chromium-review.googlesource.com/708762
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507727}
[modify] https://crrev.com/9b845b0b16a5d30447f1adaba273131fdc0bbb71/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Comment 2 by kolos@chromium.org, Oct 11 2017

Cc: kolos@chromium.org
Owner: vasi...@chromium.org
Win/Linux/CrOS are fixed. Assigning to Vasilii for Mac.

Comment 3 by vasi...@chromium.org, Oct 12 2017

Status: Fixed (was: Started)
Fixed on Mac in r507639.
►

Sign in to add a comment