New issue
Advanced search Search tips

Issue 773276 link

Starred by 2 users
Status: Fixed
Owner:
wjmaclean@chromium.org
Closed: Oct 2017
Cc:
kenrb@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug

Blocking:
issue 737585



Sign in to add a comment

RenderWidgetHostViewGuest does not handle DidStopFlinging()

Project Member Reported by wjmaclean@chromium.org, Oct 10 2017 
TouchSelection editing relies on DidStopFlinging() to properly terminate scrolls. Since PDFs still use BrowserPlugin, and since RenderWidgetHostViewChildFrame doesn't create a frame connector in this case, DidStopFlinging() is not handled for PDFs (this will eventually be fixed when PDFs transition to OOPIFs).

For now, RenderWidgetHostViewGuest should implement DidStopFLinging(), and pass this event along to the top-level RenderWidgetHostView.

Note: this only affects Windows/Linux/CrOS, as Mac doesn't have Touch, and Android doesn't use plugin-based PDF.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2ad0170ecf0d513c110d44ba409c910f615dcef

commit a2ad0170ecf0d513c110d44ba409c910f615dcef
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Tue Oct 10 19:59:10 2017

Implement DidStopFlinging() for RenderWidgetHostViewGuest

Forward DidStopFlinging() events from RenderWidgetHostViewGuest so that
TouchSelection in PDFs can correctly detect the end of scroll events.

Bug:  773276 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ia37d2f6bd94c1bdf1aae9c15b3dcc20d606bfcfc
Reviewed-on: https://chromium-review.googlesource.com/709334
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507745}
[modify] https://crrev.com/a2ad0170ecf0d513c110d44ba409c910f615dcef/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/a2ad0170ecf0d513c110d44ba409c910f615dcef/content/browser/frame_host/render_widget_host_view_guest.h

Comment 2 by wjmaclean@chromium.org, Oct 10 2017

Blocking: 737585

Comment 3 by wjmaclean@chromium.org, Oct 10 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment