Add end-to-end tests for desktop NTP metrics |
||
Issue descriptionMetrics (impressions/clicks and a few other things) for the desktop NTP go through quite a long path before actually being recorded, including some Mojo IPC. We need some end-to-end tests to make sure they actually make a through to the end.
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b70ef4e622d9fe55f4a14b97d034ac02475f1605 commit b70ef4e622d9fe55f4a14b97d034ac02475f1605 Author: Marc Treib <treib@chromium.org> Date: Thu Oct 12 07:56:29 2017 Local NTP: Add some end-to-end tests for impression metrics There are unit tests for the actual logic of when to (re)record these metrics, but we didn't have an end-to-end test to make sure all the wiring is properly in place. And there is lots of wiring: All the data goes from the browser to the renderer via Mojo, gets passed to JS, then back to native, and back to the browser through Mojo again. The complicated thing is actually waiting until the page has fully loaded, including the NTP tiles in the iframe. Bug: 773269 Change-Id: Ib4e53fcc82526ecec075032577f047631379d869 Reviewed-on: https://chromium-review.googlesource.com/712915 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#508277} [modify] https://crrev.com/b70ef4e622d9fe55f4a14b97d034ac02475f1605/chrome/browser/ui/search/local_ntp_browsertest.cc
,
Oct 12 2017
Let's call this good enough for now.
,
Oct 12 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by treib@chromium.org
, Oct 11 2017