New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773268 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 749455
issue 749696


Previous locations:
webrtc:8371


Sign in to add a comment

Make download_audio_quality_tools step have depot_tools in PATH

Reported by kjellander@webrtc.org, Oct 10 2017

Issue description

The LUCI environment has a smaller PATH set, not including depot_tools it seems.
That makes it fail on the download audio tools step on the bot:

Downloading precompiled tools...
Traceback (most recent call last):
  File "/b/swarming/w/ir/cache/builder/linux_rel/src/tools_webrtc/download_tools.py", line 46, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/b/swarming/w/ir/cache/builder/linux_rel/src/tools_webrtc/download_tools.py", line 42, in main
    subprocess.check_call(cmd, shell=USE_SHELL)
  File "/b/swarming/w/ir/cipd_bin_packages/lib/python2.7/subprocess.py", line 181, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/b/swarming/w/ir/cipd_bin_packages/lib/python2.7/subprocess.py", line 168, in call
    return Popen(*popenargs, **kwargs).wait()
  File "/b/swarming/w/ir/cipd_bin_packages/lib/python2.7/subprocess.py", line 390, in __init__
    errread, errwrite)
  File "/b/swarming/w/ir/cipd_bin_packages/lib/python2.7/subprocess.py", line 1025, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

From:
https://luci-logdog.appspot.com/v/?s=webrtc%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8966183559249486240%2F%2B%2Fsteps%2Fdownload_audio_quality_tools%2F0%2Fstdout

This bug tracks making the script use the script available in the DEPS-pinned version in third_party/depot_tools instead.
 
Cc: oprypin@webrtc.org
Owner: kjellander@webrtc.org
Status: Started (was: Assigned)
I'll take this one
I looked into this and even if I use third_party/depot_tools/download_from_google_storage.py in the script, it fails because it cannot find gsutil in the PATH.

I verified at https://ci.chromium.org/swarming/task/391b78ee42bb0f10?server=chromium-swarm.appspot.com that depot_tools is not present in the path, which I think is the main problem here. It is present for gclient ruhooks at runs for 'linux_chromium_rel_ng', e.g. https://ci.chromium.org/swarming/task/391f1546332a1b10?server=chromium-swarm.appspot.com so this bug is probably best solved by addressing that rather than altering the script.

Project: chromium
Moved issue webrtc:8371 to now be  issue chromium:773268 .
Components:
Summary: Make download_audio_quality_tools step have depot_tools in PATH (was: Make tools_webrtc/download_tools.py use third_party/depot_tools)
Blocking: 749696
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/343f25d152690e1b321679b5fb69721283f051b3

commit 343f25d152690e1b321679b5fb69721283f051b3
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Tue Oct 10 16:17:03 2017

WebRTC: Add depot_tools to PATH for executing download_tools.py

When run in LUCI mode, PATH doesn't contain depot_tools by default, causing
this script to fail.

Bug:  773268 
Change-Id: Ice9e3664d6df499c5af8225eaaa59694a7a0a0b3
Reviewed-on: https://chromium-review.googlesource.com/708741
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_experimental.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_webrtc_perf_tests__win_swarming_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_dbg.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_win7.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_x64_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_dbg.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan_vptr.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_dbg.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus7_2_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_msvc_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__clang_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug__clang_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__failing_test.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win10_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg_gerrit.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_asan.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug__arm_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_ubsan.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug__clang_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_dbg.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_dbg.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_dbg.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_linux_trusty.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/README.recipes.md
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_arm_dbg.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__gcc_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug__arm_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win10.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced_invalid.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_webrtc_perf_tests__mac_swarming_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_ubsan.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_mac_10_11.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_experimental.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gcc_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__arm_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_msan.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__n_pixel_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__msvc_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_dbg.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__k_nexus5_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_dbg.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_webrtc_perf_tests__linux_trusty_swarming_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_compile_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux32_dbg.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus6_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release__arm_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder_forced.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_builder.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_dbg.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus4_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_builder.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_dbg.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__n_nexus6_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win8_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_win8.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release__clang_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5_.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipe_modules/webrtc/__init__.py
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_msan.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_arm64_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_compile_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_clang_dbg.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android32_tests__l_nexus5__forced.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_clang_rel.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json
[modify] https://crrev.com/343f25d152690e1b321679b5fb69721283f051b3/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_experimental.json

Status: Fixed (was: Started)
That did the trick!

Sign in to add a comment