App crashes on deleting items of bookmark |
||||||
Issue descriptionApp Version: 63.0.3237.0 Canary iOS Version: 9.3.5, 10.3.3, 11.0 Device: iPad only Prerequisite: Go to chrome://flags & Enable ‘Bookmark New Generation iOS’ Steps to reproduce: 1. Launch chrome 2. Open Bookmarks tab and select Mobile bookmarks 3. Tap on new folder 4. Provide new folder name and tap on dismiss keyboard 5. Tap on select button and select all bookmarks 6. Tap on delete button Observed results: App crashes Note : The app crashes only when all bookmarks are selected. Expected results: App shouldn’t crash Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): NA on M61(Feature is available from M63) Bug reproducible on the current beta channel build (App Version, iOS Version): NA on M62(Feature is available from M63) Link to video/image: https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8dTdrelluQk1FTGs/view?usp=sharing Crash log : https://crash.corp.google.com/browse?stbtiq=e269760ef856e23b&sql_dialect=googlesql#0 Stack Trace: Stack Quality81%Show frame trust levels 0x000000018137edb0 (CoreFoundation + 0x0012adb0 ) __exceptionPreprocess 0x00000001809e3f7c (libobjc.A.dylib + 0x00007f7c ) objc_exception_throw 0x000000018137ec7c (CoreFoundation + 0x0012ac7c ) +[NSException raise:format:arguments:] 0x0000000181d04150 (Foundation + 0x000a4150 ) -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] 0x000000018697a0f8 (UIKit + 0x004b60f8 ) -[UITableViewRowData _assertValidIndexPath:allowEmptySection:] 0x000000018697a170 (UIKit + 0x004b6170 ) -[UITableViewRowData ensureHeightsFaultedInForIndexPath:availHeight:edgeInset:scrollPosition:] 0x000000018671696c (UIKit + 0x0025296c ) -[UITableView _contentOffsetForScrollingToRowAtIndexPath:atScrollPosition:] 0x0000000186716128 (UIKit + 0x00252128 ) -[UITableView scrollToRowAtIndexPath:atScrollPosition:animated:] 0x000000010032267c (Chrome -bookmark_table_view.mm:671 ) __36-[BookmarkTableView refreshContents]_block_invoke 0x0000000180dc94b8 (libdispatch.dylib + 0x000014b8 ) _dispatch_call_block_and_release 0x0000000180dc9478 (libdispatch.dylib + 0x00001478 ) _dispatch_client_callout 0x0000000180dceb80 (libdispatch.dylib + 0x00006b80 ) _dispatch_main_queue_callback_4CF 0x0000000181334d4c (CoreFoundation + 0x000e0d4c ) __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ 0x0000000181332bb4 (CoreFoundation + 0x000debb4 ) __CFRunLoopRun 0x000000018125cc4c (CoreFoundation + 0x00008c4c ) CFRunLoopRunSpecific 0x0000000182b44084 (GraphicsServices + 0x0000c084 ) GSEventRunModal 0x0000000186542084 (UIKit + 0x0007e084 ) UIApplicationMain 0x000000010005346c (Chrome -chrome_exe_main.mm:55 ) main 0x0000000180dfa8b4 (libdyld.dylib + 0x000028b4 ) start
,
Oct 12 2017
,
Oct 12 2017
Root cause: it crash because the new folder is still being edited (keyboard dismissed by down arrow, not done button). The fix is to escape the "new folder naming" when content refresh. I will also handle the following "new folder naming" escape cases: 1. tap on navigation bar's "Done" 2. tap on navigation bar's "Back" 3. tap on other url/folder 4. tap on New Folder again. 5. tap on select.
,
Oct 12 2017
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82f01613f105820a53f606925313ab7417835938 commit 82f01613f105820a53f606925313ab7417835938 Author: Marti Wong <martiw@chromium.org> Date: Thu Oct 12 23:15:38 2017 Fix folder name editing crash bug (new iOS bookmark ui) Commit the folder name when the name editing of new folder is interrupted by the following scenarios: 1. tap on navigation bar's Done. 2. tap on navigation bar's Back. 3. tap on other url/folder. 4. tap on New Folder. 5. tap on Select. 6. Bookmark being updated by sync. Egtests are added accordingly. Bug: 773266 , 695749 Change-Id: I9c578ab1fc9701b09860a321577bbc9e5bd36862 Reviewed-on: https://chromium-review.googlesource.com/714840 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#508527} [modify] https://crrev.com/82f01613f105820a53f606925313ab7417835938/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm [modify] https://crrev.com/82f01613f105820a53f606925313ab7417835938/ios/chrome/browser/ui/bookmarks/bookmark_table_view.h [modify] https://crrev.com/82f01613f105820a53f606925313ab7417835938/ios/chrome/browser/ui/bookmarks/bookmark_table_view.mm [modify] https://crrev.com/82f01613f105820a53f606925313ab7417835938/ios/chrome/browser/ui/bookmarks/bookmarks_new_generation_egtest.mm
,
Oct 12 2017
,
Oct 17 2017
Verified on 64.0.3242.0 canary in iPad Pro 12'5 iOS 11.1beta, iPad Pro iOS 10.3.3 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sczs@chromium.org
, Oct 11 2017Owner: martiw@chromium.org
Status: Assigned (was: Untriaged)