TouchSelection Handles in PDF don't disappear when selection clears |
||||||
Issue descriptionChrome Version: (copy from chrome://version) OS: Win, Linux, CrOS Pre-req: a touchscreen What steps will reproduce the problem? (1) Open a PDF (2) Longpress over some text to select it (3) Tap somewhere else to clear the selection What is the expected result? The longpress should select the text, and place touch selection handles on it. The tap should cause the handles to completely disappear. What happens instead? The handles move to the top-left of the PDF content.
,
Oct 11 2017
,
Oct 11 2017
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8075cfc89c3acb11698f8b736687f9d0451d83b7 commit 8075cfc89c3acb11698f8b736687f9d0451d83b7 Author: W. James MacLean <wjmaclean@chromium.org> Date: Mon Oct 16 14:53:33 2017 Add correct SelectionBound attributes for PDF touch selection handles. At present, PDFWebContentsHelper fails to set the proper attributes on SelectionBounds for the touch selection handles, meaning that they continue to display, in the wrong position, after a selection has been cleared. The CL sets the attributes as expected. Bug: 773265 Change-Id: I28bd4e61c9f2f5b672a468b5bee3b3f1a81bbda8 Reviewed-on: https://chromium-review.googlesource.com/709314 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#509044} [modify] https://crrev.com/8075cfc89c3acb11698f8b736687f9d0451d83b7/components/pdf/browser/pdf_web_contents_helper.cc
,
Oct 16 2017
,
Oct 17 2017
Verified the fix on the latest canary(64.0.3242.0) on Windows 10 touchscreen laptop. Test URL: http://www.pdf995.com/samples/pdf.pdf Long pressing the text to select, shows the TouchSelection handles at correct position. Tapping else where on the page, causes the handles to completely disappear. Note: I was able to repro the issue on the previous canary(64.0.3241.0- which does't have the fix from C#2), where handles where moving to the top left.
,
Nov 30 2017
As per #6 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by wjmaclean@chromium.org
, Oct 10 2017