[MD Settings] Saved password in settings doesn't get updated
Reported by
dchau...@etouch.net,
Oct 10 2017
|
|||||
Issue descriptionChrome Version: 63.0.3236.0 (Official Build)2fa96eead8c5eea003b5b7fb4f9262b3d136d76b-refs/heads/master@{#507286} 32/64-bit. OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6). What steps will reproduce the problem? 1. Launch Chrome, login to www.fb.com with valid credentials and save the password. 2. Navigate to chrome://settings/passwords and click on eye icon to show the password. 3. Again go to Facebook tab, change the Facebook password and click on 'Update password' button. 4. Now, go to 'Manage password' tab and observe. Password doesn't get updated to new password. Password should get updated to new password. This is a non-regression seen from M-58 series. Note: Password is automatically get updated to new password on old Settings page. Kindly review the attached screen-cast for reference.
,
Oct 18 2017
,
Oct 18
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 22
This can still be reproduced on https://rsolomakhin.github.io/autofill/ with Chrome version 69.0.3497.120 (CrOS). Note that clicking the eye icon twice the hide and re-show does result in the password update in the settings page. Jan, do you know what the intended behaviour here is? If not, then I think this would be worth bringing up at the Feature Sync meeting.
,
Oct 22
I believe this is fixed as a by-product of the recent changes to PasswordManagerPresenter, r598929 in particular. I just tried it in Canary and it seems to work there. Canary's behavior matches the pre MD-settings behavior (i.e. password gets updated, but will be hidden), which currently seems the best we can do here. Not hiding the new password and updating the old password in place would require keeping track of quite a lot of state, and likely is infeasible until we have support for password histories. Thus I'm marking this as fixed now. Does that sound good to you, Vaclav?
,
Oct 23
Sounds awesome. I think hiding on update makes sense. Thanks for checking! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ranjitkan@chromium.org
, Oct 10 2017