Issue metadata
Sign in to add a comment
|
Regression: Unwanted white space is seen on plug-in dialog box.
Reported by
aiman.an...@etouch.net,
Oct 10 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 63.0.3236.0 (Official Build)2fa96eead8c5eea003b5b7fb4f9262b3d136d76b-refs/heads/master@{#507286}(64-bit) OS: Win(7,8,10) Mac(10.12.6, 10.13), Linux(14.04 LTS). Test URL: https://chrome.google.com/webstore/detail/cave-run/hgagjefipjphoggnobcenpnjjimejcme?utm_source=chrome-ntp-icon Steps to reproduce: 1.Launch Chrome, go to the above link and add the above extension. 2.Open extension by clicking on extension icon in omni-box and expand the extension window by clicking on expand icon 3.Click on blocked plug-in icon and observe. Actual Result: Unwanted white space is seen on plug-in dialog box. Expected Result: Unwanted white space should not be seen on plug-in dialog box. This is regression issue broken in ‘M-63’ and below per-revision bisect result Using the per-revision bisect providing the bisect results, Good Build: 63.0.3230.0(Revision:505512) Bad Build: 63.0.3231.0(Revision:505897) You are probably looking for a change made after 505887 (known good), but no later than 505888 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/85232302b595f87fb4fe4b78718a428ce968663d..d29f30d27128d92622f8579f84530a9a4c8cc10a Suspect: https://chromium.googlesource.com/chromium/src/+/d29f30d27128d92622f8579f84530a9a4c8cc10a @bsep: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Oct 16 2017
Still we are able to reproduce the issue on latest Canary-63.0.3239.6 on Windows 7. bsep@, Could you please take a look and update the thread accordingly as it is marked as stable blocker. Thanks..!
,
Oct 17 2017
Your screenshot seems really weird. It seems like it has the strings from my patch ("Flash was blocked") but the layout from before my patch (with a "learn more" link instead of the "?" icon).
I attached a screenshot of what I get when I run the example page in Canary, which is what I expect. What am I doing wrong?
,
Oct 24 2017
Note: Retested the above issue on latest Dev #63.0.3239.16 on Win(7,8,10) Mac(10.12.6, 10.13), Linux(14.04 LTS) and still observing the above issue. The issue is unwanted space is seen on the Plugin Bubble.
,
Oct 27 2017
Oh I see, it's a mac-only bug. I'll make sure it gets fixed.
,
Oct 30 2017
[Bulk Edit] URGENT - PTAL. M63 Stable promotion is coming soon and your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP. Thank you.
,
Oct 31 2017
Before/after for CL in https://chromium-review.googlesource.com/c/chromium/src/+/746461
,
Oct 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f966630e46da3fc1fa5858e4d4db4118b09943e commit 5f966630e46da3fc1fa5858e4d4db4118b09943e Author: Trent Apted <tapted@chromium.org> Date: Tue Oct 31 21:53:55 2017 Mac: Make the Cocoa blocked plugins bubble shorter. Now that flash is the only plugin, this dialog has a lot less to say, and has too much unwanted white space. The height of the Cocoa bubble is a hardcoded magic number specific to this dialog. Make it smaller. The dialog will be replaced with a toolkit-views version soon. Bug: 773218 Change-Id: Ie828c7d88415c3e1d42c7e280fdd5bae60e8cb71 Reviewed-on: https://chromium-review.googlesource.com/746461 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#512964} [modify] https://crrev.com/5f966630e46da3fc1fa5858e4d4db4118b09943e/chrome/browser/ui/cocoa/content_settings/blocked_plugin_bubble_controller.mm
,
Nov 1 2017
Requesting merge for r512964 to m63. Also checked using http://get.adobe.com/flashplayer/about/ (note on corp-policy managed machines the "Run flash this time" option might not be present if flash is disabled by policy, but it's not worth adding autolayout logic for that).
,
Nov 1 2017
,
Nov 1 2017
Approving merge for r512964 to m63 branch 3239 based on comment #9 and #10. Please merge ASAP. Thank you.
,
Nov 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8724b3286c6d53a4e8426415fece47212624258e commit 8724b3286c6d53a4e8426415fece47212624258e Author: Trent Apted <tapted@chromium.org> Date: Wed Nov 01 22:58:07 2017 [merge-m63] Mac: Make the Cocoa blocked plugins bubble shorter. Now that flash is the only plugin, this dialog has a lot less to say, and has too much unwanted white space. The height of the Cocoa bubble is a hardcoded magic number specific to this dialog. Make it smaller. The dialog will be replaced with a toolkit-views version soon. TBR=tapted@chromium.org (cherry picked from commit 5f966630e46da3fc1fa5858e4d4db4118b09943e) Bug: 773218 Change-Id: Ie828c7d88415c3e1d42c7e280fdd5bae60e8cb71 Reviewed-on: https://chromium-review.googlesource.com/746461 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#512964} Reviewed-on: https://chromium-review.googlesource.com/749607 Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#338} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/8724b3286c6d53a4e8426415fece47212624258e/chrome/browser/ui/cocoa/content_settings/blocked_plugin_bubble_controller.mm
,
Nov 1 2017
,
Nov 7 2017
Note: Retested the above issue on Beta # 63.0.3239.39 on Mac(10.12.6, 10.13.2) and fix is working as intended.
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Oct 10 2017