Remove chromium IPC in unittests for service workers |
|||
Issue descriptionServiceWorkerVersionTest has several legacy IPCs for testing but it's now useless since we are moving legacy IPCs to Mojo IPCs. https://cs.chromium.org/chromium/src/content/browser/service_worker/service_worker_version_unittest.cc?type=cs&sq=package:chromium&l=44 Let's remove it from unittests. I didn't see other tests, but I guess some tests still have outdated tests related IPCs.
,
Jun 13 2018
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a5e3796fbf5563f0d3ba7a90c570043f7a57093 commit 5a5e3796fbf5563f0d3ba7a90c570043f7a57093 Author: Han Leon <leon.han@intel.com> Date: Thu Jun 14 04:52:00 2018 [ServiceWorker] EmbeddedWorkerTestHelper no longer needs to be IPC::{Sender,Listener} This CL removes all legacy IPCs related things from EmbeddedWorkerTestHelper and do clean up accordingly. BUG= 773193 Change-Id: I01efcb3847fa8eac998918a89e2855f87761e2ad Reviewed-on: https://chromium-review.googlesource.com/1098682 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#567140} [modify] https://crrev.com/5a5e3796fbf5563f0d3ba7a90c570043f7a57093/content/browser/service_worker/embedded_worker_instance_unittest.cc [modify] https://crrev.com/5a5e3796fbf5563f0d3ba7a90c570043f7a57093/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/5a5e3796fbf5563f0d3ba7a90c570043f7a57093/content/browser/service_worker/embedded_worker_test_helper.h [modify] https://crrev.com/5a5e3796fbf5563f0d3ba7a90c570043f7a57093/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
,
Jun 21 2018
After https://chromium.googlesource.com/chromium/src.git/+/74c810c13e9ba0eebcc5fe4e72d750c6d50b54c3, except WorkerFetchContextImpl is sending some FrameHostMsg_* messages, all other IPC:: related things in Service Worker code (including test code) have been removed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by falken@chromium.org
, Jun 12 2018Status: Assigned (was: Available)