New issue
Advanced search Search tips

Issue 773188 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add config to enable categories in background heap profiler

Project Member Reported by ssid@chromium.org, Oct 10 2017

Issue description

Background context: issue 700245

Some traces have a large memory attribution to ipc and net category. To investigate further we need to enable some trace events.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cafb7acf00f59b31ef9bbe2d42117c41d66a26a

commit 4cafb7acf00f59b31ef9bbe2d42117c41d66a26a
Author: Siddhartha <ssid@chromium.org>
Date: Tue Oct 10 20:39:02 2017

Rename kHeapProfilingModeNoStack mode to kHeapProfilingModeBackground

We would need more information in background traces than just context.
To enable categories in future, change the mode name to background.
Use CaptureMode::PSEUDO_STACK in Background mode.

BUG= 773188 

Change-Id: I2dcb71f554b7084b442a0977dca6413e2235d704
Reviewed-on: https://chromium-review.googlesource.com/707789
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507760}
[modify] https://crrev.com/4cafb7acf00f59b31ef9bbe2d42117c41d66a26a/base/trace_event/malloc_dump_provider.cc
[modify] https://crrev.com/4cafb7acf00f59b31ef9bbe2d42117c41d66a26a/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/4cafb7acf00f59b31ef9bbe2d42117c41d66a26a/base/trace_event/memory_dump_manager.h
[modify] https://crrev.com/4cafb7acf00f59b31ef9bbe2d42117c41d66a26a/base/trace_event/memory_dump_manager_unittest.cc
[modify] https://crrev.com/4cafb7acf00f59b31ef9bbe2d42117c41d66a26a/chrome/test/base/memory_tracing_browsertest.cc
[modify] https://crrev.com/4cafb7acf00f59b31ef9bbe2d42117c41d66a26a/content/browser/tracing/background_memory_tracing_observer.cc
[modify] https://crrev.com/4cafb7acf00f59b31ef9bbe2d42117c41d66a26a/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation_struct_traits.cc
[modify] https://crrev.com/4cafb7acf00f59b31ef9bbe2d42117c41d66a26a/services/resource_coordinator/public/interfaces/memory_instrumentation/memory_instrumentation.mojom

Comment 2 by ssid@chromium.org, Oct 10 2017

Summary: Add config to enable categories in background heap profiler (was: Add config to enable cat4egories in background heap profiler)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53441e98cb8ba5ea776ddeb70ff2881b76e924e9

commit 53441e98cb8ba5ea776ddeb70ff2881b76e924e9
Author: Siddhartha <ssid@chromium.org>
Date: Wed Oct 11 01:49:53 2017

Slow-reports: Add support for selecting categories in heap profiling

Add argument to configure which categories to enable for heap profiling.

BUG= 773188 

Change-Id: I443d1e6a09c5a80d73ec3b6a6ba72d30252f4134
Reviewed-on: https://chromium-review.googlesource.com/707772
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507858}
[modify] https://crrev.com/53441e98cb8ba5ea776ddeb70ff2881b76e924e9/content/browser/tracing/background_memory_tracing_observer.cc
[modify] https://crrev.com/53441e98cb8ba5ea776ddeb70ff2881b76e924e9/content/browser/tracing/background_memory_tracing_observer.h
[add] https://crrev.com/53441e98cb8ba5ea776ddeb70ff2881b76e924e9/content/browser/tracing/background_memory_tracing_observer_unittest.cc
[modify] https://crrev.com/53441e98cb8ba5ea776ddeb70ff2881b76e924e9/content/test/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/135cd8135f005658ff9cb670d8d37d7df2c85c4d

commit 135cd8135f005658ff9cb670d8d37d7df2c85c4d
Author: Siddhartha <ssid@chromium.org>
Date: Mon Oct 16 11:40:57 2017

Memory-infra: Enable BackgroundMemoryTracingObserverTest(s)

BUG= 773188 

Change-Id: I0725966c5dcd8732f6b4299617ed1a503713e872
Reviewed-on: https://chromium-review.googlesource.com/714652
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509021}
[modify] https://crrev.com/135cd8135f005658ff9cb670d8d37d7df2c85c4d/content/browser/tracing/background_memory_tracing_observer_unittest.cc
[modify] https://crrev.com/135cd8135f005658ff9cb670d8d37d7df2c85c4d/content/test/BUILD.gn

Comment 5 by ssid@chromium.org, Dec 11 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment