Triggered CQ try jobs but did not wait until the completion |
|
Issue descriptionwpt-importer failure builds: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2838 https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2839 CL: https://chromium-review.googlesource.com/707216 https://chromium-review.googlesource.com/706519 Some logs from https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra.cron%2Fwpt-importer%2F2839%2F%2B%2Frecipes%2Fsteps%2FImport_changes_from_WPT_to_Chromium%2F0%2Fstdout: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX Waiting for try jobs. 6628 seconds passed. Waiting for try jobs. 6869 seconds passed. Waiting for try jobs. 7110 seconds passed. All jobs finished. 2017-10-09 11:18:16,594 - Triggering CQ try jobs. Waiting for try jobs, timeout: 12600 seconds. All jobs finished. 2017-10-09 11:20:21,698 - No CQ try results found in try results: {Build(builder_name=u'mac10.11_retina_blink_rel', build_number=4302): TryJobStatus(status=u'COMPLETED', result=u'SUCCESS'), Build(builder_name=u'mac10.9_blink_rel', build_number=4266): TryJobStatus(status=u'COMPLETED', result=u'SUCCESS'), Build(builder_name=u'win10_blink_rel', build_number=4510): TryJobStatus(status=u'COMPLETED', result=u'SUCCESS'), Build(builder_name=u'mac10.12_blink_rel', build_number=2091): TryJobStatus(status=u'COMPLETED', result=u'SUCCESS'), Build(builder_name=u'android_blink_rel', build_number=4090): TryJobStatus(status=u'COMPLETED', result=u'SUCCESS'), Build(builder_name=u'mac10.10_blink_rel', build_number=4255): TryJobStatus(status=u'COMPLETED', result=u'SUCCESS'), Build(builder_name=u'win7_blink_rel', build_number=4519): TryJobStatus(status=u'COMPLETED', result=u'SUCCESS'), Build(builder_name=u'mac10.11_blink_rel', build_number=4372): TryJobStatus(status=u'COMPLETED', result=u'SUCCESS'), Build(builder_name=u'linux_trusty_blink_rel', build_number=16746): TryJobStatus(status=u'COMPLETED', result=u'SUCCESS')}. step returned non-zero exit code: 1 Notable things for both builds: - unnecessary to update test expectations. - triggered CQ try jobs but immediately considered all jobs have finished. - then tried to get CQ try bots results from the old results of layout test try bots triggered previously.
,
Oct 10 2017
,
Oct 10 2017
Thanks for looking into this Leon -- I think that the problem is that in TestImporter.run_commit_queue_for_cl (https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py?l=176), the importer just waits for *any* try jobs; it doesn't specifically wait for CQ try jobs. I just realized that this is the same bug as bug 754169 which was assigned to me. I was thinking the next step was to change wait_for_try_jobs to specifically wait for CQ try jobs. But since I don't know of any easy way to get the list of CQ builder names, I was thinking we could add a boolean parameter to wait_for_try_jobs to make it either include only the *blink_rel (TestImporter.blink_try_bots()) or to exclude all of those bots. |
|
►
Sign in to add a comment |
|
Comment 1 by leon....@intel.com
, Oct 10 2017