New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773159 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Recent update in Milo Buildbot API timestamp format breaks downstream user (GoldenEye)

Project Member Reported by jinjingl@chromium.org, Oct 10 2017

Issue description

We are using this API to get our builds information. 
https://luci-milo.appspot.com/rpcexplorer/services/milo.Buildbot/GetBuildbotBuildsJSON?request={%20%20%20%20%22master%22:%20%22chromeos%22,%20%20%20%20%22builder%22:%20%22asuka-release%22,%20%20%20%20%22limit%22:%203}

And the timestamp of builds returned were previously longs, but they got changed to doubles recently, which breaks our code that maps the API results to our own entities. 

Although we do plan to migrate from using milo.Buildbot to milo.BuildInfo, this might happen to BuildInfo API as well. Is there a way for us to ensure the upstream changes in data format/values does not break our code? 



 

Comment 1 by hinoka@chromium.org, Oct 12 2017

Components: -Infra>Client>Chrome Infra>Platform>Milo>Buildbot
Owner: no...@chromium.org

Comment 2 by no...@chromium.org, Oct 12 2017

Status: Assigned (was: Untriaged)
I am sorry this happened. Buildbot's format for timestamps is double. It was an inconsistency on our side that that particular field was a long. This was a part of admittedly dangerous refactoring. The protocol change was not intended, but was discovered after the deployment.

We don't plan to do more refactorings to this API the foreseeable future (we would rather turn this API). What is the action you expect from this bug?

re BuildInfo: please refrain from migrating to that. We plan to include whatever data you need to the Buildbucket API v2 responses, so there will be only one API to call.
We do need to migrate to BuildInfo temporarily, as we are moving away from Buildbot. 

As for the action item, is there a repo that we can subscribe to its changes. Or automatically got added as one of the reviewer? 

Comment 4 by no...@chromium.org, Oct 12 2017

the Buildbot API protocols are defined in https://chromium.googlesource.com/infra/luci/luci-go/+/master/milo/api/buildbot/

you can probably subscribe to changes in that dir by adding WATCHLIST file there. I am not sure how such files work though, here is an example https://cs.chromium.org/chromium/src/WATCHLISTS?dr&q=file:WATCH&sq=package:chromium

Comment 5 by no...@chromium.org, Oct 23 2017

did WATCHLIST work for you?
Labels: Legoland
Sorry I haven't tried it yet, but I will soon :-) 

Thank you for cc-ing me in the CLs recently. 

I also added a "Legoland" tag for you to easily identify future issues from us. 

Comment 7 by no...@chromium.org, Oct 30 2017

Owner: jinjingl@chromium.org
I'd like to close this bug because it is assigned to me, but I don't see how can I do it. Assigning to you to try out the WATCHLIST file.

Comment 8 by no...@chromium.org, Oct 30 2017

Cc: no...@chromium.org
Status: WontFix (was: Assigned)

Sign in to add a comment