Recent update in Milo Buildbot API timestamp format breaks downstream user (GoldenEye) |
||||||
Issue descriptionWe are using this API to get our builds information. https://luci-milo.appspot.com/rpcexplorer/services/milo.Buildbot/GetBuildbotBuildsJSON?request={%20%20%20%20%22master%22:%20%22chromeos%22,%20%20%20%20%22builder%22:%20%22asuka-release%22,%20%20%20%20%22limit%22:%203} And the timestamp of builds returned were previously longs, but they got changed to doubles recently, which breaks our code that maps the API results to our own entities. Although we do plan to migrate from using milo.Buildbot to milo.BuildInfo, this might happen to BuildInfo API as well. Is there a way for us to ensure the upstream changes in data format/values does not break our code?
,
Oct 12 2017
I am sorry this happened. Buildbot's format for timestamps is double. It was an inconsistency on our side that that particular field was a long. This was a part of admittedly dangerous refactoring. The protocol change was not intended, but was discovered after the deployment. We don't plan to do more refactorings to this API the foreseeable future (we would rather turn this API). What is the action you expect from this bug? re BuildInfo: please refrain from migrating to that. We plan to include whatever data you need to the Buildbucket API v2 responses, so there will be only one API to call.
,
Oct 12 2017
We do need to migrate to BuildInfo temporarily, as we are moving away from Buildbot. As for the action item, is there a repo that we can subscribe to its changes. Or automatically got added as one of the reviewer?
,
Oct 12 2017
the Buildbot API protocols are defined in https://chromium.googlesource.com/infra/luci/luci-go/+/master/milo/api/buildbot/ you can probably subscribe to changes in that dir by adding WATCHLIST file there. I am not sure how such files work though, here is an example https://cs.chromium.org/chromium/src/WATCHLISTS?dr&q=file:WATCH&sq=package:chromium
,
Oct 23 2017
did WATCHLIST work for you?
,
Oct 30 2017
Sorry I haven't tried it yet, but I will soon :-) Thank you for cc-ing me in the CLs recently. I also added a "Legoland" tag for you to easily identify future issues from us.
,
Oct 30 2017
I'd like to close this bug because it is assigned to me, but I don't see how can I do it. Assigning to you to try out the WATCHLIST file.
,
Oct 30 2017
,
Apr 9 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hinoka@chromium.org
, Oct 12 2017Owner: no...@chromium.org