Device names are shown as trusted UI (like permission names) in Page Info |
||||
Issue descriptionChrome Version:63 Page Info shows the name of a granted device the same way as other permissions. The user must have granted permission to that device, but if they manage to get permission granted they can control what that line says. 1. This may be confusing if the users doesn't recognize and parse the USB icon, especially in the case of something like "Bluetooth Adapter". 2. A site could maybe make it something deceptive or malicious? This is a bit of a stretch, because they have to get the user to pair to a device with that name in the first place. 3. The accessibility text for the permission doesn't mention USB. 4. The line doesn't wrap, possibly pushing the revocation button off the edge. A simple (but possibly obnoxious) way to fix the first two would be to add a heading or change the line to: - USB Device: "Bluetooth Adapter" - Bluetooth Adapter (USB) reillyg@ verified for me in person that the device name associated with the site's permission can never change. I'll file bugs about accessibility and wrapping. palmer@: Could you determine if we are still okay with showing device names as trusted UI? (Or triage.)
,
Oct 10 2017
,
Nov 10 2017
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d8a431da480e92e816a12da0f2eb1dde089e713 commit 1d8a431da480e92e816a12da0f2eb1dde089e713 Author: Patti <patricialor@chromium.org> Date: Fri Jan 19 06:36:11 2018 Page Info Desktop: Chosen objects now show the object type underneath its name. Chosen object views (currently, only USB devices) shown in the Page Info bubble only show the name of the USB device granted to them and don't give any context of what they might be. Add a label in secondary text underneath the chosen object name to make it clear to the user that this is a USB device. Bug: 773156 , 773146 Change-Id: I95af87ed0fe86ff14fd539f44204f9158cc0ff9a Reviewed-on: https://chromium-review.googlesource.com/771060 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Reviewed-by: Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#530439} [modify] https://crrev.com/1d8a431da480e92e816a12da0f2eb1dde089e713/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm [modify] https://crrev.com/1d8a431da480e92e816a12da0f2eb1dde089e713/chrome/browser/ui/page_info/page_info.cc [modify] https://crrev.com/1d8a431da480e92e816a12da0f2eb1dde089e713/chrome/browser/ui/page_info/page_info.h [modify] https://crrev.com/1d8a431da480e92e816a12da0f2eb1dde089e713/chrome/browser/ui/page_info/page_info_ui.cc [modify] https://crrev.com/1d8a431da480e92e816a12da0f2eb1dde089e713/chrome/browser/ui/page_info/page_info_ui.h [modify] https://crrev.com/1d8a431da480e92e816a12da0f2eb1dde089e713/chrome/browser/ui/views/page_info/chosen_object_view.cc [modify] https://crrev.com/1d8a431da480e92e816a12da0f2eb1dde089e713/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc [modify] https://crrev.com/1d8a431da480e92e816a12da0f2eb1dde089e713/chrome/browser/ui/views/page_info/permission_selector_row.cc [modify] https://crrev.com/1d8a431da480e92e816a12da0f2eb1dde089e713/components/page_info_strings.grdp
,
Feb 9 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by raymes@chromium.org
, Oct 10 2017