New issue
Advanced search Search tips

Issue 773145 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

nassh: TypeError when using OpenPGP smart card

Reported by agwa-bugs@mm.beanwood.com, Oct 10 2017

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS armv7l 9592.96.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.114 Safari/537.36
Platform: 9592.96.0 (Official Build) stable-channel veyron_minnie

Steps to reproduce the problem:
Follow the steps at https://chromium.googlesource.com/apps/libapps/+/HEAD/nassh/doc/hardware-keys.md with an OpenPGP card v2.0 in a Gemalto USB Shell Token reader.

What is the expected behavior?
I am prompted for my PIN.

What went wrong?
The following errors are logged to the console:

agent.Agent: registered backends: {stub: ƒ, gsc: ƒ}
nassh_agent.js:68 agent.Agent: loading backend 'gsc'
nassh_agent_backend_gsc.js:195 TypeError: Cannot read property '4' of null
    at nassh.agent.backends.GSC.SmartCardManager.fetchPINVerificationTriesRemaining (nassh_agent_backend_gsc.js:1199)
    at <anonymous>
nassh.agent.backends.GSC.requestReaderIdentities_ @ nassh_agent_backend_gsc.js:195
async function (async)
nassh.agent.backends.GSC.requestReaderIdentities_ @ nassh_agent_backend_gsc.js:173
nassh.agent.backends.GSC.requestIdentities @ nassh_agent_backend_gsc.js:232
async function (async)
nassh.agent.backends.GSC.requestIdentities @ nassh_agent_backend_gsc.js:218
Promise.all.backends_.map @ nassh_agent.js:170
nassh.agent.Agent.requestHandlers_.(anonymous function) @ nassh_agent.js:169
nassh.agent.Agent.handleRequest_ @ nassh_agent.js:141
nassh.agent.Agent.handleRequest @ nassh_agent.js:127
nassh.Stream.SSHAgent.trySendPacket_ @ nassh_stream_sshagent.js:66
setTimeout (async)
nassh.Stream.SSHAgent.asyncWrite @ nassh_stream_sshagent.js:86
nassh.CommandInstance.onPlugin_.write @ nassh_command_instance.js:1180
nassh.CommandInstance.dispatchMessage_ @ nassh_command_instance.js:835
nassh.CommandInstance.onPluginMessage_ @ nassh_command_instance.js:1032
nassh_agent_backend_gsc.js:196 GSC.requestIdentities: failed to get public key ID from reader Gemalto USB Shell Token V2 00 00, skipping

WebStore page: https://chrome.google.com/webstore/detail/secure-shell/pnhechapfaindjhompbnflcldabbghjo?utm_source=chrome-app-launcher-info-dialog

Did this work before? N/A 

Chrome version: 60.0.3112.114  Channel: n/a
OS Version: 9592.96.0
Flash Version:
 

Comment 1 Deleted

Comment 2 Deleted

Comment 3 by vapier@chromium.org, Oct 10 2017

Cc: fabian.h...@gmail.com
i think this has been fixed in latest git version already, so just need to wait for the next release
https://chromium.googlesource.com/apps/libapps/+/44fc4707142a3cf08d21eb913ec9e8d49e1e732f
Yes, this issue is hopefully already resolved on HEAD. The relevant commit is https://chromium.googlesource.com/apps/libapps/+/bcfd61b9f626f76587d0bef2d2395218d0ef030a, which makes the TLV parsing more lenient, working around differences in the OpenPGP implementation among different brands of smart cards.

Comment 5 by vapier@chromium.org, Oct 12 2017

Status: Fixed (was: Unconfirmed)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: archived (was: Fixed)

Comment 7 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment