Get v8_context_snapshot_generator out of critical build path |
||||||||
Issue descriptionOn incremental non-component release builds the linking of v8_context_snapshot_generator.exe can take 90+ s. It blocks the linking of chrome_child.dll which ends up being the long pole which means that the linking of v8_context_snapshot_generator.exe ends up slowing down the build by 90+ s, which often represents 25% of the total build time. I tried disabling it by setting use_v8_context_snapshot to false but that doesn't work. I tried turning of linking with symbols but that only helped a tiny amount. I don't actually have any suggestions, just the observation that this makes non-component builds even more painful.
,
Nov 22 2017
,
Nov 22 2017
,
Dec 14 2017
+peria@, CC'd owner of v8_context_snapshot_generator
,
Dec 20 2017
,
Nov 12
Ikuta-san, wasn't this issue fixed?
,
Nov 12
brucedawson@, is this still problematic? I think this is not so problematic after migration to lld.
,
Nov 12
In my build in the same config with win7_chromium_rel_ng builder, linking time of v8_context_snapshot_generator is around 6 seconds. So I think we can close this now. brucedawson@, if you see slowness yet, please re-open this issue. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by brucedaw...@chromium.org
, Nov 22 2017