Improve UI for choosing mobile networks |
|||||
Issue descriptionUnder Settings > Mobile > "Mobile data network", a few enhancements can be done: 1. The "scan" button is currently enabled when the cellular device is connected. However, we normally observe that the cellular device will fail the scan request with a 'busy' error when it's currently connected to a network. The "scan" action thus appears to have no effect. Instead, we should disable the "scan" button when the cellular device is connected. 2. Before a scan is performed, the "Mobile data network" pull-down list currently shows "No networks", which is a bit confusing. Instead, we can populate an empty list and make it disabled 3. The scan result may contain a few entries that are marked "forbidden". The pull-down list currently makes those forbidden entries "disabled", which can be confusing to users. Instead, perhaps we should filter out all "forbidden" entries in the list. For (1) and (2), an alternative solution is to completely hide the "Mobile data network" section when the cellular device is connected.
,
Oct 12 2017
1. Done. 2. Kept "No networks" but disabled the dropdown which seems OK? 3. I worry that it might be confusing if the disabled scan results do not show up anywhere? We should probably get UX input for that and file a separate issue if we want to change the existing behavior. I opted to improve the UI while connected instead of hiding it since it might provide useful information. CL: https://chromium-review.googlesource.com/c/chromium/src/+/716864
,
Oct 13 2017
2. How about a disabled empty list? It looks a bit confusing to see "No networks" 3. That's a good point. Let's discuss that with UX.
,
Oct 13 2017
I think we should also discuss (2) with UX; an empty dropdown looks like a bug to me.
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/854791c2fac4ad1ad7aa2857ea64933ec6a4341b commit 854791c2fac4ad1ad7aa2857ea64933ec6a4341b Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Oct 16 17:48:40 2017 Settings > Network > Choose Mobile fixes * Disable 'scan' button while connected * Move 'Scanning...' and 'Scan completed' to secondary text line * Show 'Disconnect to enable scanning' in secondary text when connected (and there is no other scan status). * Hide SIM UI until Cellular properties load to avoid incorrect red 'SIM card missing' text while loading. Bug: 773131 , 774401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I843fc6efd5f19137a63a1f12a1389e4ee55a9c8f Reviewed-on: https://chromium-review.googlesource.com/716864 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#509097} [modify] https://crrev.com/854791c2fac4ad1ad7aa2857ea64933ec6a4341b/chrome/app/settings_strings.grdp [modify] https://crrev.com/854791c2fac4ad1ad7aa2857ea64933ec6a4341b/chrome/browser/resources/settings/internet_page/internet_detail_page.js [modify] https://crrev.com/854791c2fac4ad1ad7aa2857ea64933ec6a4341b/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc [modify] https://crrev.com/854791c2fac4ad1ad7aa2857ea64933ec6a4341b/ui/webui/resources/cr_components/chromeos/network/network_choose_mobile.html [modify] https://crrev.com/854791c2fac4ad1ad7aa2857ea64933ec6a4341b/ui/webui/resources/cr_components/chromeos/network/network_choose_mobile.js [modify] https://crrev.com/854791c2fac4ad1ad7aa2857ea64933ec6a4341b/ui/webui/resources/cr_components/chromeos/network/network_property_list.html [modify] https://crrev.com/854791c2fac4ad1ad7aa2857ea64933ec6a4341b/ui/webui/resources/cr_components/chromeos/network/network_shared_css.html
,
Oct 17 2017
Marking this as "fixed" since the initial round of changes are in and the functionality issues ave been addressed; we can open new issues for any additional UX polish.
,
Oct 17 2017
Issue 775489 has been merged into this issue.
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa commit 7c3ae4a0a6229183afbe338f34aa8aa6154f37fa Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Oct 30 16:37:21 2017 Settings > Network > Choose Mobile fixes * Disable 'scan' button while connected * Move 'Scanning...' and 'Scan completed' to secondary text line * Show 'Disconnect to enable scanning' in secondary text when connected (and there is no other scan status). * Hide SIM UI until Cellular properties load to avoid incorrect red 'SIM card missing' text while loading. TBR=stevenjb@chromium.org (cherry picked from commit 854791c2fac4ad1ad7aa2857ea64933ec6a4341b) Bug: 773131 , 774401 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I843fc6efd5f19137a63a1f12a1389e4ee55a9c8f Reviewed-on: https://chromium-review.googlesource.com/716864 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509097} Reviewed-on: https://chromium-review.googlesource.com/744181 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#291} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa/chrome/app/settings_strings.grdp [modify] https://crrev.com/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa/chrome/browser/resources/settings/internet_page/internet_detail_page.js [modify] https://crrev.com/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc [modify] https://crrev.com/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa/ui/webui/resources/cr_components/chromeos/network/network_choose_mobile.html [modify] https://crrev.com/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa/ui/webui/resources/cr_components/chromeos/network/network_choose_mobile.js [modify] https://crrev.com/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa/ui/webui/resources/cr_components/chromeos/network/network_property_list.html [modify] https://crrev.com/7c3ae4a0a6229183afbe338f34aa8aa6154f37fa/ui/webui/resources/cr_components/chromeos/network/network_shared_css.html |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by harpreet@chromium.org
, Oct 10 2017