New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 773086 link

Starred by 2 users
Status: Fixed
Owner:
█ warx@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
█ cernekee@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 742437



Sign in to add a comment

Add UMA for "user unable to connect to wifi due to rate-limiting IP blacklist"

Project Member Reported by warx@chromium.org, Oct 9 2017 
This UMA is used to check if our randomized hosts method is good enough to defeat the rate-limiting IP blacklist.

Plan is: if shill shows is_captive_portal, while chrome's portal detection timeouts within a minute or two, we can assume portal provider is rate-limiting our attempts.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6aa8921b866e6f415793d9728bb96c715b422340

commit 6aa8921b866e6f415793d9728bb96c715b422340
Author: Qiang Xu <warx@chromium.org>
Date: Wed Oct 11 05:38:35 2017

cros: add UMA to record the rate of portal detection ip-based blacklist

changes:
Within one minute that default network reports a portal network, if we
get offline detection result, it is likely we get blacklisted. Record
the boolean rate that Chrome pulls offline vs non-offline detection
result.

Bug:  773086 
Test: added test coverage
Change-Id: If28689f20ee339c1c1e1a2d5d098d20d8cc86ce7
Reviewed-on: https://chromium-review.googlesource.com/707730
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Kevin Cernekee <cernekee@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507903}
[modify] https://crrev.com/6aa8921b866e6f415793d9728bb96c715b422340/chrome/browser/chromeos/net/network_portal_detector_impl.cc
[modify] https://crrev.com/6aa8921b866e6f415793d9728bb96c715b422340/chrome/browser/chromeos/net/network_portal_detector_impl.h
[modify] https://crrev.com/6aa8921b866e6f415793d9728bb96c715b422340/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc
[modify] https://crrev.com/6aa8921b866e6f415793d9728bb96c715b422340/tools/metrics/histograms/histograms.xml

Comment 2 by warx@chromium.org, Oct 11 2017

Status: Fixed (was: Assigned)

Comment 3 by yoshi@chromium.org, Aug 14

Cc: -yoshi@chromium.org
►

Sign in to add a comment