New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773084 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: ----

Blocked on: View detail
issue 708586
issue 865247



Sign in to add a comment

v8.browsing_desktop failing on 3 builders

Project Member Reported by oysteine@chromium.org, Oct 9 2017

Issue description

Cc: dtu@chromium.org
Might be a credentials issue?

Specifically browse:tools:maps is failing.

dtu@: Do I vaguely remember you looking at something similar in the past or knowing who would know about this?

2017-10-02 13:28:25.636 Google Chrome[26504:318840] Errors logged by ksadmin: KSKeyedPersistentStore store directory does not exist. [com.google.UpdateEngine.CommonErrorDomain:501 - '/Library/Google/GoogleSoftwareUpdate/TicketStore' - 'KSKeyedPersistentStore.m:372']
KSPersistentTicketStore failed to load tickets. (productID: com.google.Chrome) [com.google.UpdateEngine.CoreErrorDomain:1051 - '/Library/Google/GoogleSoftwareUpdate/TicketStore/Keystone.ticketstore'] (KSKeyedPersistentStore store directory does not exist. - '/Library/Google/GoogleSoftwareUpdate/TicketStore' [com.google.UpdateEngine.CommonErrorDomain:501])
ksadmin cannot access the ticket store:<KSUpdateError:0x100305530
	domain="com.google.UpdateEngine.CoreErrorDomain"
	code=1051
	userInfo={
		function = "-[KSProductKeyedStore(ProtectedMethods) errorForStoreError:productID:message:timeoutMessage:]";
		date = 2017-10-02 20:28:25 +0000;
		productids = {(
			"com.google.Chrome"
		)};
		filename = "KSProductKeyedStore.m";
		line = 91;
		NSFilePath = "/Library/Google/GoogleSoftwareUpdate/TicketStore/Keystone.ticketstore";
		NSUnderlyingError = <KSError:0x100301dc0
			domain="com.google.UpdateEngine.CommonErrorDomain"
			code=501
			userInfo={
				date = 2017-10-02 20:28:25 +0000;
				line = 372;
				filename = "KSKeyedPersistentStore.m";
				function = "-[KSKeyedPersistentStore(PrivateMethods) validateStorePath]";
				NSFilePath = "/Library/Google/GoogleSoftwareUpdate/TicketStore";
				NSLocalizedDescription = "KSKeyedPersistentStore store directory does not exist.";
			}
		>;
		NSLocalizedDescription = "KSPersistentTicketStore failed to load tickets.";
	}
>


=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: mac_10_12_perf_bisect
  Benchmark    : v8.browsing_desktop
  Metric       : blink-gc-idle-lazy-sweep_avg/browse_tools/browse_tools_maps

Revision             Exit Code      N
chromium@505591      1 +- N/A       5      good
chromium@505688      1 +- N/A       5      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.tools.maps v8.browsing_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8966174146421302672


For feedback, file a bug with component Speed>Bisection

Comment 4 by dtu@chromium.org, Oct 9 2017

Cc: erikc...@chromium.org nednguyen@chromium.org
I think the previous issue you're referring to was a misconfigured Mac Keychain?
https://www.chromium.org/developers/telemetry/telemetry-mac-keychain-setup
But all the bots should be correctly set up now, so not sure if this is the same thing.

+erikchen, +nednguyen for more ideas.
Owner: mythria@chromium.org
Status: Assigned (was: Available)
I believe this test is just flaky.
Yes, I think it is the problem with maps story and not related to credentials, from the following stack trace:

File "/b/s/w/ir/tools/perf/page_sets/system_health/browsing_stories.py", line 743, in _DidLoadDocument
    old_restaurant=prev_restaurant_hash)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 262, in WaitForJavaScriptCondition
    return self._tab.WaitForJavaScriptCondition(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 239, in WaitForJavaScriptCondition
    return self._inspector_backend.WaitForJavaScriptCondition(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 302, in WaitForJavaScriptCondition
    e.message + '\n' + debug_message)
TimeoutException: Timed out while waiting 60s for IsJavaScriptExpressionTrue.
Console output:

It is waiting for the restaurants to be updated. It is failing quite frequently on Mac. I will disable this page on Mac while I investigate this issue. I think I know where the problem is coming from. The restaurants pane does not get refreshed if the scrolled amount is less than a certain amount. On Zoom it always refreshes the pane, but when scrolling it does not refresh it if it is below a certain threshold. Though I am still not sure why it happens so frequently on mac and appears to be stable on linux. Also, the current scroll ratio of 0.5 is much higher than the threshold for refresh. 
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86c5b7140e88a151e10eba064c18375edd3a3248

commit 86c5b7140e88a151e10eba064c18375edd3a3248
Author: Mythri Alle <mythria@chromium.org>
Date: Tue Oct 10 13:48:04 2017

Disable browse:tools:maps story on mac

Disable browse:tools:maps story on mac platform in the following
benchmarks:
v8.runtimestats.browsing_desktop
v8.browsing_desktop
system_health.common_desktop
system_health.memory_desktop

Bug: chromium:773084
Change-Id: Ib865246c8d577efbf3ea6fbbee1959b7075fe5e4
Reviewed-on: https://chromium-review.googlesource.com/708794
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507656}
[modify] https://crrev.com/86c5b7140e88a151e10eba064c18375edd3a3248/tools/perf/page_sets/system_health/expectations.py

Labels: -Pri-1 Pri-2
Lowering the priority since the page is now disabled on Mac. 
Cc: mythria@chromium.org charliea@chromium.org ashleymarie@chromium.org
 Issue 773381  has been merged into this issue.
There are three different events we can use for moving a page:
Mouse wheel event, Mouse drag event and Touch event. 
RepeatableBrowserDrivenScroll generates touch events by default. The touch events seems to work fine on Linux platform. On Mac, this does not work as expected. The scroll event instead zooms into the map. I think the right thing to do here is to use MouseDrag events. Mouse drag events have a known bug (crbug.com/708586) and the drag action does not move the page smoothly. If the physical mouse pointer moves on the page then it changes the scroll location and hence makes the story very noisy.
Blockedon: 708586
Cc: tdres...@chromium.org
+Tim: can we have someone from input team help with issue 708586?
Adding more info to Comment 12, For RepeatableBrowserDrivenScroll, the scroll events gets translated into Mouse wheel events on Mac. Mouse wheel events actually perform zoom operation. On Mac, Touch events are not supported. So we cannot really use them. MouseDrag event is the correct way to go for maps. 
Labels: v8-benchmarks
Components: Blink>JavaScript Speed>Benchmarks
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/1516e485a40000
📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/17fc6e71a40000
Looks like it failed 19/40 runs.

Ned filed a Mac Keychain bug just today. Maybe it's that? Issue 865247
Blockedon: 865247
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3c38ed5d6306f187fb910ea8f382a762067c1be

commit d3c38ed5d6306f187fb910ea8f382a762067c1be
Author: Ned Nguyen <nednguyen@google.com>
Date: Tue Aug 21 22:10:13 2018

Disable v8.browsing_desktop-future/browse:tools:maps on Mac

Bug:773084
Change-Id: I8ef6fe66ad10246e62e926f11d1d54ef209d300c

NOTRY=true

TBR=mythia@chromium.org, ulan@chromium.org

Change-Id: I8ef6fe66ad10246e62e926f11d1d54ef209d300c
Reviewed-on: https://chromium-review.googlesource.com/1183905
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#584907}
[modify] https://crrev.com/d3c38ed5d6306f187fb910ea8f382a762067c1be/tools/perf/expectations.config

Thanks for disabling it on Mac Ned. I think it should have been disabled earlier as well. I am not sure it is related to Keychain bug though. From the comment #12, #14 this story does not work on mac because we should be using Mouse drag event. 

Tim, Any ideas on how to fix crbug.com/708586 or any work around for that? 


(Tim's OOO for a bit, but can respond when he gets back)
Cc: nzolghadr@chromium.org
Navid, any ideas?
Cc: eirage@chromium.org
I believe Ella has enabled the touch events on Mac about a months ago to accommodate for devtools usecase. Would that help?
Mythria, any update?

Sign in to add a comment