New issue
Advanced search Search tips

Issue 773079 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Material chrome://flags Reset and Relaunch buttons don't have a hover effect.

Project Member Reported by lgar...@chromium.org, Oct 9 2017

Issue description

Chrome 63.0.3236.0
macOS 10.12.6

What steps will reproduce the problem?
(1) Visit chrome://flags
(2) Hover over "Reset all to default" (upper right)
(3) Change a setting and hover over "Relaunch" (appears in lower right)

What is the expected result?
Hover effect (e.g. pointer cursor or a change in the button background color).

What happens instead?
No hover effect

The "Enable"/"Disable" buttons (which are actually links styled as buttons) do have a hover cursor.

In addition, the dropdowns (which are styled to look very similar to the links) also do not have a hover effect. This is to expected for natively styled dropdowns, although it feels unusual to me in this case.
 
Cc: -edwardjung@chromium.org
Owner: edwardjung@chromium.org
Status: Assigned (was: Untriaged)
Good point. Will make all of these input elements work consistently. 
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fc5451ac52eac5f141b72af906cb794baa1699b

commit 0fc5451ac52eac5f141b72af906cb794baa1699b
Author: Edward Jung <edwardjung@chromium.org>
Date: Thu Oct 12 08:56:53 2017

Updated chrome://flags UI bug fixes

+ Focus outlines on buttons are now styled rather than the large default blur.
+ Fixed the cropped focus outline due to overflow:hidden being 
  set on the experiment container.
+ Remove elided description text, so full text search works properly.
+ Hide the 'Beta' promo statement by default.
+ Add hover styles for buttons.
+ Improve RTL layout
+ Force scrollbar to fix annoying layout shift
+ Add listener for '/' to focus search box.
+ Add a proper tab index order
+ Uppercase formatting for Restart button

Bug:  772792 , 773079 , 772968 , 772851 , 772809 , 772807 , 772792 , 772784 , 772781 
Change-Id: I9a9c08c2e8aef517d6d0c6e2ac8b634b69a1c6a1
Reviewed-on: https://chromium-review.googlesource.com/707252
Commit-Queue: Edward Jung <edwardjung@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508286}
[modify] https://crrev.com/0fc5451ac52eac5f141b72af906cb794baa1699b/components/flags_ui/resources/flags.css
[modify] https://crrev.com/0fc5451ac52eac5f141b72af906cb794baa1699b/components/flags_ui/resources/flags.html
[modify] https://crrev.com/0fc5451ac52eac5f141b72af906cb794baa1699b/components/flags_ui/resources/flags.js

Status: Fixed (was: Assigned)
Implemented hover over effects on the buttons. 

The enable / disable link and drop downs, not don't have a pointer. Future work is to make all states a drop down so that all experiment toggling is consistent.

Sign in to add a comment