New issue
Advanced search Search tips

Issue 773076 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----

Blocking:
issue 404315
issue 773009



Sign in to add a comment

Android Nougat test bot is failing OSKOverscrollTest#testOnlyVisualViewportResizes

Project Member Reported by gsennton@chromium.org, Oct 9 2017

Issue description

Link to one of the failing runs:
https://build.chromium.org/p/chromium.android.fyi/builders/Nougat%20Phone%20Tester/builds/3954

Link to failure output:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android.fyi%2FNougat_Phone_Tester%2F3954%2F%2B%2Frecipes%2Fsteps%2Fchrome_public_test_apk_on_Android%2F0%2Flogs%2Forg.chromium.chrome.browser.OSKOverscrollTest_testOnlyVisualViewportResizes%2F0


Actual failure output:

java.lang.AssertionError: expected:<Rect(0, 554 - 412, 604)> but was:<Rect(0, 553 - 412, 603)>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.chromium.chrome.browser.OSKOverscrollTest.testOnlyVisualViewportResizes(OSKOverscrollTest.java:149)
	at java.lang.reflect.Method.invoke(Native Method)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
	at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:65)
	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:184)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:41)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:166)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:100)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1932)
 
So it looks like the footer moved one pixel upwards..?
Blocking: 784331
Android sheriff Ping. Any updates here?
This is not assigned to anyone, I don't know who should take it on
Cc: -ymalik@chromium.org estevenson@chromium.org
Owner: ymalik@chromium.org
ymalik - any thoughts on this? If you aren't the right person to look at this feel free to remove yourself.
Cc: bokan@chromium.org skobes@chromium.org
Owner: ----
I don't work blink anymore, bokan@/ skobes@ PTAL

Comment 7 by bokan@chromium.org, Jan 10 2018

Components: Blink>Scroll
Owner: bokan@chromium.org
Status: Assigned (was: Available)
I'll take a look this week

Comment 8 by donnd@chromium.org, Feb 20 2018

bokan@, any update?

Comment 9 by bokan@chromium.org, Feb 28 2018

No, sorry - unfortunately I haven't been able to find time to look at this. I'll disable the test tomorrow to clear the bot (the test isn't really important since the feature is still unshipped and isn't likely to ship soon), though it looks like the bot's been on fire for other reasons...
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2369d502f0d0092bab5f24536de21755ed8c3918

commit 2369d502f0d0092bab5f24536de21755ed8c3918
Author: David Bokan <bokan@chromium.org>
Date: Thu Mar 01 19:27:46 2018

Disable OSKOverscroll test

This test is failing on the Nougat bot. Since the feature is unshipped
and currently unowned, it's best to just disable for now. We'll block
the feature bug on reenabling it.

Bug: 773076
Change-Id: I30d019267116fcae937e86f5f514f2a260829dc4
Reviewed-on: https://chromium-review.googlesource.com/943246
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540248}
[modify] https://crrev.com/2369d502f0d0092bab5f24536de21755ed8c3918/chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java

Blocking: -784331
Removing from sheriff blocking bug since there's an owner.
Blocking: 404315
Components: Tests>Fails

Sign in to add a comment