ChromeOS Simple Chrome gn args: allow_posix_link_time_opt has been removed |
||||||||||
Issue description
We see the following error while building chrome for chromeos using simple chrome:
ninja -C out_amd64-generic/Release/ -j1000 -l20 chrome chrome_sandbox nacl_helper
ninja: Entering directory `out_amd64-generic/Release/'
[1/1] Regenerating ninja files
ERROR at build arg file (use "gn args <out_dir>" to edit):6:29: Build argument has no effect.
allow_posix_link_time_opt = false
^----
The variable "allow_posix_link_time_opt" was set as a build argument
but never appeared in a declare_args() block in any buildfile.
To view all possible args, run "gn args --list <builddir>"
This gn arg was removed here:
https://chromium-review.googlesource.com/c/chromium/src/+/695714
It is referenced here:
https://cs.corp.google.com/chromeos_public/src/third_party/chromiumos-overlay/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild?l=334
,
Oct 9 2017
pasting https://chromium-review.googlesource.com/c/chromium/src/+/695714#message-b9279f4b23969288d135d81039614c1192f00797 : """CrOS build files are currently owned by CrOS team, not chrome team. Oshima, please file bug somewhere on some CrOS person to do something. This isn't something pcc should have to deal with."""
,
Oct 9 2017
This bug seems relevant: https://bugs.chromium.org/p/chromium/issues/detail?id=707803
,
Oct 9 2017
We're all in this together. Fortunately it's just a warning, even though it says 'error'. +oshima@, didn't you have a CL to remove this from the ebuild? We need to: 1. Land a CL to remove it from the chrome ebuild. 2. Wait for a green PFQ run with the change landed. 3. Update CHROMEOS_LKGM. Assigning to this week's gardener, afakhry@. Let me know if you have any questions about the above.
,
Oct 9 2017
I'd like to better understand 'This isn't something pcc should have to deal with.' What is the expectation here - that the cros team get up to speed with the details of this gn arg and figure out a fix? Is it not ok to ask for guidance on what the right fix might be from the chrome team?
,
Oct 9 2017
It is absolutely okay to ask for guidance on the fix from the chrome team. In this case, that arg is now gone (no longer needed) and you can just delete it. The feature is controlled fully by use_thin_lto, which you have on the next line.
,
Oct 11 2017
,
Oct 11 2017
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0f0cc15de0bfb6343eccfccfb8994616c9f59489 commit 0f0cc15de0bfb6343eccfccfb8994616c9f59489 Author: Ahmed Fakhry <afakhry@google.com> Date: Thu Oct 12 01:32:49 2017 Remove allow_posix_link_time_opt from chrome's gn args BUG= chromium:773069 TEST=none Change-Id: Id5829174a7a8ccd461a02c79574589f65d0720ee Reviewed-on: https://chromium-review.googlesource.com/713759 Commit-Ready: Ahmed Fakhry <afakhry@chromium.org> Tested-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/0f0cc15de0bfb6343eccfccfb8994616c9f59489/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Oct 13 2017
The PFQ has gone green yesterday. The CHROMEOS_LKGM is being updated here https://chromium-review.googlesource.com/c/chromium/src/+/718840
,
Oct 14 2017
,
Oct 16 2017
Handing over to next gardener.
,
Oct 16 2017
glevin@ FYI: This is just blocked on updating CHROMEOS_LKGM which is blocked on a failure in the simple chrome trybot (issue 774599, see that for more info). I've tested locally and confirmed that once we do update CHROMEOS_LKGM this will be fixed.
,
Oct 23 2017
Still blocked, passing along to next gardener
,
Oct 23 2017
,
Oct 23 2017
We were able to update CHROMEOS_LKGM to a version that is not affected by issue 774599 so this is now resolved. https://chromium-review.googlesource.com/c/chromium/src/+/726247
,
Jan 22 2018
,
Jan 23 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by achuith@chromium.org
, Oct 9 2017