The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a827230eec3f344ab9ca0c2dea44e100a8ff977

commit 1a827230eec3f344ab9ca0c2dea44e100a8ff977
Author: Eric Karl <ericrk@chromium.org>
Date: Mon Oct 09 22:20:00 2017

Temporarily remove the lower 512MB shared memory limits

This is being done to see if the 512MB limits resulted in a large
OOM rate reduction we saw. Will revert this change within 1 week.

Bug:  773067 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I61acc0f3fdaf911a99beb2b9c97758435583d5f4
Reviewed-on: https://chromium-review.googlesource.com/707774
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507509}
[modify] https://crrev.com/1a827230eec3f344ab9ca0c2dea44e100a8ff977/gpu/command_buffer/client/shared_memory_limits.h

The NextAction date has arrived: 2017-10-15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cac238e06a78ee12d9d67542b07f7c00038ffe40

commit cac238e06a78ee12d9d67542b07f7c00038ffe40
Author: Eric Karl <ericrk@chromium.org>
Date: Mon Oct 16 17:53:58 2017

Revert "Temporarily remove the lower 512MB shared memory limits"

This reverts commit 1a827230eec3f344ab9ca0c2dea44e100a8ff977.

Reason for revert: This was a temporary change to check the impact of certain limits.

Original change's description:
> Temporarily remove the lower 512MB shared memory limits
> 
> This is being done to see if the 512MB limits resulted in a large
> OOM rate reduction we saw. Will revert this change within 1 week.
> 
> Bug:  773067 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I61acc0f3fdaf911a99beb2b9c97758435583d5f4
> Reviewed-on: https://chromium-review.googlesource.com/707774
> Commit-Queue: Eric Karl <ericrk@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#507509}

TBR=piman@chromium.org,ericrk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  773067 
Change-Id: I5db9ec9bdb95ba59e456082dff96c810a5b76bbd
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/721799
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509099}
[modify] https://crrev.com/cac238e06a78ee12d9d67542b07f7c00038ffe40/gpu/command_buffer/client/shared_memory_limits.h

This was supposed to be a temporary revert/reland on dev to check metrics. Want to merge the revert of the temporary change to M63.

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

cmasso@, is it possible to get merge approval. The original change was a temporary experiment (changing something for a week to see impact on UMA), and I'd like to merge the revert to M63. Thanks!

Hello ericrk@, please help me understand. You landed a "dev" experimental CL in M63 after branch point and would like to revert it?
If that is the case then it is very bad practice that should be avoided in order to maintain the stability of our branch. Experimental CLs should be under a flag so it can be turned on/off without any risk of messing up with the branch. 

??

Hi cmasso@, I landed an experimental CL in M63 before the branch point, with the intent of reverting it, but didn't realize we were branching so soon. I'd like to revert this patch now. Thinking about it I understand that it would have better been handled as a finch experiment, and will do so in the future.

I am approving this merge as per our offline discussion since you said there is no risk involved. But please let's do this better in the future.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67daa6a235afed9463f2a508eb84ed15d7cd24c4

commit 67daa6a235afed9463f2a508eb84ed15d7cd24c4
Author: Eric Karl <ericrk@chromium.org>
Date: Wed Oct 25 21:47:28 2017

Revert "Temporarily remove the lower 512MB shared memory limits"

This reverts commit 1a827230eec3f344ab9ca0c2dea44e100a8ff977.

Reason for revert: This was a temporary change to check the impact of certain limits.

Original change's description:
> Temporarily remove the lower 512MB shared memory limits
>
> This is being done to see if the 512MB limits resulted in a large
> OOM rate reduction we saw. Will revert this change within 1 week.
>
> Bug:  773067 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I61acc0f3fdaf911a99beb2b9c97758435583d5f4
> Reviewed-on: https://chromium-review.googlesource.com/707774
> Commit-Queue: Eric Karl <ericrk@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#507509}

TBR=ericrk@chromium.org, piman@chromium.org


(cherry picked from commit cac238e06a78ee12d9d67542b07f7c00038ffe40)

Bug:  773067 
Change-Id: I5db9ec9bdb95ba59e456082dff96c810a5b76bbd
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/721799
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509099}
Reviewed-on: https://chromium-review.googlesource.com/738792
Cr-Commit-Position: refs/branch-heads/3239@{#231}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/67daa6a235afed9463f2a508eb84ed15d7cd24c4/gpu/command_buffer/client/shared_memory_limits.h