Screen rotation animation regression. |
||||||
Issue descriptionToT, Found by oshima@. I tested at kevin, the screen rotation animation does not rotate as smooth as before. The UMA on local device drops from 59% to 39% (mean animation smoothness). Works at M61 and M62. Not M63. I will bisect soon.
,
Oct 9 2017
Correction in #1, it seems the screen rotation animation only "OnProgress" with a few frames, but never call "ProgressToEnd".
,
Oct 9 2017
+sunnyps@
,
Oct 10 2017
Might be because we are waiting for main thread (UI compositor in browser) always. Removing the defer_commits_ case in ShouldBlockDeadlineIndefinitely might fix the regression.
,
Oct 10 2017
#4, sunnyps@, you are right. removing defer_commits_ case fixes it.
,
Oct 10 2017
OK, I'll send a patch to only wait for defer_commits_ in full-pipe mode. (We really do need it for headless / devtools BeginFrameControl.)
,
Oct 11 2017
Fix is out for review here: https://chromium-review.googlesource.com/c/chromium/src/+/708735
,
Oct 11 2017
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f690274ae4a0a09cd28b26900ef46c47044a3809 commit f690274ae4a0a09cd28b26900ef46c47044a3809 Author: Eric Seckler <eseckler@chromium.org> Date: Thu Oct 12 11:38:21 2017 [cc] Only block for deferred draw in full-pipe mode Bug: 773058 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I33e0f97d6e9246b0e5e9ef71e9a462ca191a1f91 Reviewed-on: https://chromium-review.googlesource.com/708735 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#508315} [modify] https://crrev.com/f690274ae4a0a09cd28b26900ef46c47044a3809/cc/scheduler/scheduler_state_machine.cc [modify] https://crrev.com/f690274ae4a0a09cd28b26900ef46c47044a3809/cc/scheduler/scheduler_state_machine_unittest.cc
,
Oct 12 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by wutao@chromium.org
, Oct 9 2017Labels: M-63