After adding some logging it looks like the state that is mismatching is icon.getConstantState:

10-09 21:19:22.990  5364  5380 E ItemChooserRow: icon.getConstantState doesn't match android.support.graphics.drawable.VectorDrawableCompat$VectorDrawableDelegateState@54c15a8 android.support.graphics.drawable.VectorDrawableCompat$VectorDrawableDelegateState@7ee98c1

my guess is that this is caused by the following code, which changes behaviour for API level 24 (Nougat):

https://cs.corp.google.com/android/frameworks/support/graphics/drawable/static/src/main/java/android/support/graphics/drawable/VectorDrawableCompat.java?l=268&rcl=cbe8b1ac8098092913b67efe64f5e78f0b13023c

i.e. VectorDrawableCompat.java:

@Override
public ConstantState getConstantState() {
    if (mDelegateDrawable != null && Build.VERSION.SDK_INT >= 24) {
        // Such that the configuration can be refreshed.
        return new VectorDrawableDelegateState(mDelegateDrawable.getConstantState());
    }
    mVectorState.mChangingConfigurations = getChangingConfigurations();
    return mVectorState;
}

It seems kinda weird to be comparing a pair of object using object.equals when that method is not implemented for the class of objects you are comparing (that will just result in comparing the addresses of the objects).

Comparing the addresses of the objects is what we want. We want to make sure they are the same object.

Right, but that won't work on Nougat and above because of the implementation of getConstantState() as shown in comment #4. So ItemChooserRow.hasSameContents(..) is just wrong on N and above (at least whenever you use VectorDrawableCompat as your Drawable icon).

Android sheriff Ping. Any updates here?

Not that I know of, maybe we could add a method ItemChooserDialog$ItemChooserRow.hasSameContentsForTesting that is the same as hasSameContents except it would avoid checking mIcon.getConstantState() on API level 24 and above. ortuno@ WDYT?

Assigning to ortuno@ to respond when they're back in office.

Checking for getConstantState() was the only way to be sure that the implementation was correct i.e. that the icon being shown was the correct icon. I think removing that check would make it really easy to change the chooser behavior and not notice.

Is there no way to make sure two images are the same in 24?

This test is consistently failing on Oreo, maybe we can disable it for that platform until the underlying problem can be identified.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=BluetoothChooserDialogTest%23testSelectItem

Mailed this CL to disable on Oreo: https://chromium-review.googlesource.com/c/chromium/src/+/927685

Thanks for the patch.

re the problem: I think this affects more than just the test. We update the chooser items based on ItemChooserDialog$ItemChooserRow.hasSameContents. If that function is always returning false (because of the Oreo change), then we are updating every item for every new update (100s per second in a busy environment). This is probably making the chooser unusable in busy environments.

So even if we introduced hasSameContentForTesting the implementation would still be broken.

I no longer work on the project so assigning to reillyg for triage.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e5e511ceb3adf6fea402c6219be3854fec371b2

commit 1e5e511ceb3adf6fea402c6219be3854fec371b2
Author: Donn Denman <donnd@google.com>
Date: Thu Feb 22 01:43:18 2018

Disable BlueToothChooserDialogTest.testSelectItem

Disable this test on Android-Oreo since it is consistently
failing on that platform.

BUG=773043

Change-Id: Ifccc9b6ef76d13b312fecb3956eb4198e7d11ce5
Reviewed-on: https://chromium-review.googlesource.com/927685
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538303}
[modify] https://crrev.com/1e5e511ceb3adf6fea402c6219be3854fec371b2/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java