Missing space in "Contacting Google" dialog in first-run flow |
|||||
Issue descriptionApplication Version (from "Chrome Settings > About Chrome"): 62.0.3202.45 Android Build Number (from "Android Settings > About Phone/Tablet"): NHG470 Device: Pixel Steps to reproduce: - Go through Chrome first-run flow - Select an account to sign into Observed behavior: The dialog box shows up with the text: "Contacting Google...this may take a minute" Expected behavior: There is a missing space between the ellipsis and "this". Standard English style guidelines call for a space before and after ellipsis, but in this case at least after. Frequency: 100%
,
Oct 9 2017
+Shimi Shimi, do we have precedent for this in Chrome? Do we follow standard English style guidelines for including a space before & after the ellipsis (or per Matt's suggestion, at least after)? FYI - this is the dialogue we added in response to another bug you originally filed, Matt ( Issue 650121 - thanks for diligently filing bugs on these flows) :) Shimi, feel free to take a look at that bug for more context. This dialogue is only shown when signing in with an Enterprise account.
,
Oct 10 2017
Per our UX guidelines, no space before the ellipsis. We use the ellipsis to indicate an action in progress. Also, note that UX guidelines often favor removing unnecessary spaces and punctuation over following standard English style guides, which in many cases were written for print. Either alternative would be acceptable: "Contacting Google... This may take a minute." < if adding a space, the string then becomes 2 sentences, not one, and so needs an uppercase "t" and a period after the 2nd sentence. "Contacting Google. This may take a minute..."
,
Oct 10 2017
OK, let's go with "Contacting Google. This may take a minute..." Boris, can you make this quick string change?
,
Oct 25 2017
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aededf57513c3de7c57be3b734013b83f053ff78 commit aededf57513c3de7c57be3b734013b83f053ff78 Author: Boris Sazonov <bsazonov@chromium.org> Date: Wed Oct 25 15:22:09 2017 [Android] Update string for signin progress dialog This CL slightly changes the string displayed by progress dialog while getting account management policy. Bug: 773036 Change-Id: If7b172ca7b570cf8a40bca14a107a6780a8e6670 Reviewed-on: https://chromium-review.googlesource.com/738090 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#511467} [modify] https://crrev.com/aededf57513c3de7c57be3b734013b83f053ff78/chrome/android/java/strings/android_chrome_strings.grd
,
Nov 7 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ligim...@chromium.org
, Oct 9 2017