New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 773034 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Enable tablet power button behavior on non-user-session for forced clamshell flag

Project Member Reported by warx@chromium.org, Oct 9 2017

Issue description

This is an initial thought about forced clamshell flag convertible power button behavior on sign-in/locked screen.

After  issue 758574 , display will be forced off three seconds after screen locking starts when the --force-clamshell-power-button flag is set. One thing not good here is: when locked by the power button and display is off after 3 seconds, then user activity turns the display on, it is not possible to make the display off unless (1) login and then press power button, (2) wait inactivity delays.

Currently in code, with --force-clamshell-power-button, TabletPowerButtonController is not created, propose this:
(1) still creates TabletPowerButtonController with --force-clamshell-power-button flag
(2) in user session, performs the current logic for --force-clamshell-power-button
(3) out user session, performs tablet power button behavior.

The reason we adopted --force-clamshell-power-button is it will set display off when transporting device with hand pressed on power button, which is a bit annoying in user session to get display off. Is it OK when user is not logged in?
 

Comment 1 by derat@chromium.org, Oct 9 2017

I'd strongly prefer that we hold off on making this already-too-complicated code even more complicated unless we receive user complaints about what we have right now. Our testers are already completely confused about what a given Chromebook is expected to do when the power button is pressed or held, and I don't blame them for it. :-(

Comment 2 by warx@chromium.org, Oct 9 2017

Labels: -M-64
OK, then removed milestone label, until we decided to make changes here.
Status: Assigned (was: Untriaged)

Comment 4 by warx@chromium.org, Feb 14 2018

Status: Archived (was: Assigned)
This will be obsolete with new design.

Sign in to add a comment